narendly opened a new pull request #408: Improve equals() on config objects URL: https://github.com/apache/helix/pull/408 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes $407 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: ClusterConfig, InstanceConfig, ResourceConfig's equals() methods were only comparing the IDs, which is not desirable because it is possible to have two instances of each with the same IDs but different contents/fields. This diff improves the equals() methods for these configs so that the actual contents are compared as well. Changelist: 1. Change equals() on the said config classes so that the actual content is compared ### Tests - [ ] The following tests are written for this issue: Simple equals() method. No tests needed. - [ ] The following is the result of the "mvn test" command on the appropriate module: (Copy & paste the result of "mvn test") ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
