narendly opened a new pull request #908: Make Helix REST realm-aware URL: https://github.com/apache/helix/pull/908 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #907 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: Helix REST needs to start using a realm-aware ZkClient on multi-zk mode. Also it needs to become a listener on routing data because we don't want to restart the HelixRestServer every time we update the routing data. Changelist: 1. Make ServerContext listen on routing data paths if run on multi-zk mode 2. Make HelixRestServer use RealmAwareZkClient (FederatedZkClient) on multi-zk mode ### Tests - [x] The following tests are written for this issue: TestRoutingDataUpdate - [x] The following is the result of the "mvn test" command on the appropriate module: on helix-rest module: > [INFO] Results: > [INFO] > [ERROR] Failures: > [ERROR] TestResourceAccessor.testResourceHealth:289 expected:<HEALTHY> but was:<UNHEALTHY> > [INFO] > [ERROR] Tests run: 144, Failures: 1, Errors: 0, Skipped: 7 > [INFO] > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 37.847 s > [INFO] Finished at: 2020-03-23T22:02:47-07:00 > [INFO] ------------------------------------------------------------------------ TestResourceAccessor is an unrelated failure that will be fixed in future iterations. ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
