[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329787035 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MonitorDomainNames.java

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329771293 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329787483 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329780111 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329782151 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329775755 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329769603 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329783344 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329786570 ## File path: helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329773415 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329788124 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329775047 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329785737 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329782959 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329773765 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329781886 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329778506 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329779503 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.

2019-09-30 Thread GitBox
narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer. URL: https://github.com/apache/helix/pull/456#discussion_r329888081 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.

2019-09-30 Thread GitBox
narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer. URL: https://github.com/apache/helix/pull/456#discussion_r329883026 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.

2019-09-30 Thread GitBox
narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer. URL: https://github.com/apache/helix/pull/456#discussion_r329882633 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #499: Add import order for java and javax.

2019-09-30 Thread GitBox
jiajunwang commented on a change in pull request #499: Add import order for java and javax. URL: https://github.com/apache/helix/pull/499#discussion_r329789413 ## File path: helix-style-intellij.xml ## @@ -29,6 +29,10 @@ + + Review comment:

[GitHub] [helix] pkuwm commented on a change in pull request #499: Add import order for java and javax.

2019-09-30 Thread GitBox
pkuwm commented on a change in pull request #499: Add import order for java and javax. URL: https://github.com/apache/helix/pull/499#discussion_r329792799 ## File path: helix-style-intellij.xml ## @@ -29,6 +29,10 @@ + + Review comment:

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329840986 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329840724 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329840601 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] i3wangyi commented on a change in pull request #488: Implement soft constraint based on f(x) = tanh(1/x)

2019-09-30 Thread GitBox
i3wangyi commented on a change in pull request #488: Implement soft constraint based on f(x) = tanh(1/x) URL: https://github.com/apache/helix/pull/488#discussion_r329825395 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329840756 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329840433 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329841995 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/metrics/model/Metric.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329841459 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329839252 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329842143 ## File path: helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329841144 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329840407 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329842461 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/TestWagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329841740 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329840526 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329841039 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329839157 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329842231 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MonitorDomainNames.java ##

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329841131 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329841096 ## File path:

[GitHub] [helix] pkuwm commented on issue #494: #493 Set jersey servlet application name with namespace name.

2019-09-30 Thread GitBox
pkuwm commented on issue #494: #493 Set jersey servlet application name with namespace name. URL: https://github.com/apache/helix/pull/494#issuecomment-536683338 Thanks @i3wangyi . This PR is ready to be merged, approved by @i3wangyi Commit message: Title: [helix-rest]

[GitHub] [helix] dasahcc merged pull request #494: #493 Set jersey servlet application name with namespace name.

2019-09-30 Thread GitBox
dasahcc merged pull request #494: #493 Set jersey servlet application name with namespace name. URL: https://github.com/apache/helix/pull/494 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] alirezazamani opened a new issue #496: Fix job purge logic so that it will remove jobs with null configs from DAG

2019-09-30 Thread GitBox
alirezazamani opened a new issue #496: Fix job purge logic so that it will remove jobs with null configs from DAG URL: https://github.com/apache/helix/issues/496 Currently, the job purge logic outputs a log if a job without config exists in the DAG. Purge logic does not remove this job

[GitHub] [helix] narendly commented on a change in pull request #490: Add the metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: Add the metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329424151 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/metrics/CountMetric.java

[GitHub] [helix] narendly commented on a change in pull request #490: DRAFT: Add the metric components for WAGED rebalancer

2019-09-30 Thread GitBox
narendly commented on a change in pull request #490: DRAFT: Add the metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329423844 ## File path: