[GitHub] [helix] narendly closed pull request #423: Assignment Metadata Store

2019-08-19 Thread GitBox
narendly closed pull request #423: Assignment Metadata Store URL: https://github.com/apache/helix/pull/423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [helix] narendly opened a new pull request #423: Assignment Metadata Store

2019-08-19 Thread GitBox
narendly opened a new pull request #423: Assignment Metadata Store URL: https://github.com/apache/helix/pull/423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [helix] chenboat commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

2019-08-19 Thread GitBox
chenboat commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-522853075 This PR is ready to be merged, approved by [@jiajunwang].

[GitHub] [helix] chenboat commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

2019-08-19 Thread GitBox
chenboat commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-522852156 > Please try to run "mvn test". I ran the mvn for helix-core. There are transient failures which can pass after

[GitHub] [helix] i3wangyi commented on a change in pull request #417: Move partition health check method into dataAccessor layer

2019-08-19 Thread GitBox
i3wangyi commented on a change in pull request #417: Move partition health check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417#discussion_r315478375 ## File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java

[GitHub] [helix] dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer

2019-08-19 Thread GitBox
dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417#discussion_r315476495 ## File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java

[GitHub] [helix] dasahcc commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
dasahcc commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315475010 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraintWeightModel.java

[GitHub] [helix] dasahcc commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
dasahcc commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315475176 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraintWeightModel.java

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-19 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r315474238 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315444535 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315442635 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/HardConstraint.java

[GitHub] [helix] i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315439626 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315439240 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315439144 ## File path:

[GitHub] [helix] jiajunwang commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

2019-08-19 Thread GitBox
jiajunwang commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-522772493 Please try to run "mvn test". This is an automated

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315428362 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/HardConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315428431 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/HardConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315424622 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315429032 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315426836 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315427763 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/HardConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315427077 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/HardConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315425900 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315425615 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315427001 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315428715 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/HardConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r315427318 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/HardConstraint.java

[GitHub] [helix] i3wangyi commented on a change in pull request #417: Move partition health check method into dataAccessor layer

2019-08-19 Thread GitBox
i3wangyi commented on a change in pull request #417: Move partition health check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417#discussion_r315426751 ## File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r315423150 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

2019-08-19 Thread GitBox
jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r315421552 ## File path:

[GitHub] [helix] i3wangyi opened a new issue #421: Create definitions for soft/hard constraints and implementations

2019-08-19 Thread GitBox
i3wangyi opened a new issue #421: Create definitions for soft/hard constraints and implementations URL: https://github.com/apache/helix/issues/421 For Waged Rebalancer This is an automated message from the Apache Git

[GitHub] [helix] dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer

2019-08-19 Thread GitBox
dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417#discussion_r315404402 ## File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java

[GitHub] [helix] i3wangyi removed a comment on issue #417: Move partition health check method into dataAccessor layer

2019-08-19 Thread GitBox
i3wangyi removed a comment on issue #417: Move partition health check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417#issuecomment-521822204 The refactor is not finalized. Because partitions health from ZK is not good enough, it will need to combine the logics

[GitHub] [helix] narendly opened a new issue #420: Investigate race condition in job purging

2019-08-19 Thread GitBox
narendly opened a new issue #420: Investigate race condition in job purging URL: https://github.com/apache/helix/issues/420 Investigate race condition in job purging This is an automated message from the Apache Git Service.

[GitHub] [helix] dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer

2019-08-19 Thread GitBox
dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417#discussion_r315337089 ## File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java

[GitHub] [helix] jiajunwang merged pull request #413: Add cluster level default instance config.

2019-08-19 Thread GitBox
jiajunwang merged pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [helix] jiajunwang commented on issue #413: Add cluster level default instance config.

2019-08-19 Thread GitBox
jiajunwang commented on issue #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#issuecomment-522680174 > Before checking it in, do you think we should leave a comment on what would happen if neither instance capacity nor default value is set?

[GitHub] [helix] alirezazamani commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-19 Thread GitBox
alirezazamani commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r315308557 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@

[GitHub] [helix] alirezazamani commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-19 Thread GitBox
alirezazamani commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r315303268 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@

[GitHub] [helix] alirezazamani commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-19 Thread GitBox
alirezazamani commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r315289200 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java ## @@ -602,4