[GitHub] [helix] narendly commented on a change in pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default")

2019-09-05 Thread GitBox
narendly commented on a change in pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default") URL: https://github.com/apache/helix/pull/449#discussion_r321341842 ## File path:

[GitHub] [helix] i3wangyi commented on issue #450: Implement one of the soft constraints

2019-09-05 Thread GitBox
i3wangyi commented on issue #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#issuecomment-528518668 > Another question, by looking at this soft constraint impl, I am wondering if we just enforce all the soft constraint implementation to return an

[GitHub] [helix] pkuwm commented on a change in pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default")

2019-09-05 Thread GitBox
pkuwm commented on a change in pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default") URL: https://github.com/apache/helix/pull/449#discussion_r321395976 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-05 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321410527 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-05 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321408464 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-05 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321412130 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] pkuwm commented on a change in pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default")

2019-09-05 Thread GitBox
pkuwm commented on a change in pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default") URL: https://github.com/apache/helix/pull/449#discussion_r321387314 ## File path:

[GitHub] [helix] jiajunwang opened a new pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances

2019-09-05 Thread GitBox
jiajunwang opened a new pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances URL: https://github.com/apache/helix/pull/451 ### Issues - [ ] My PR addresses the following Helix issues and references them in the

[GitHub] [helix] jiajunwang commented on a change in pull request #433: HardConstraints Implementation and unit tests

2019-09-04 Thread GitBox
jiajunwang commented on a change in pull request #433: HardConstraints Implementation and unit tests URL: https://github.com/apache/helix/pull/433#discussion_r320897613 ## File path:

[GitHub] [helix] alirezazamani commented on issue #446: Fix the order of workflow context update

2019-09-04 Thread GitBox
alirezazamani commented on issue #446: Fix the order of workflow context update URL: https://github.com/apache/helix/pull/446#issuecomment-528042874 This PR is ready to be merged. Approved by @narendly Final Commit message: Title: Fix the order of workflow context update

[GitHub] [helix] alirezazamani commented on a change in pull request #446: Fix the order of workflow context update

2019-09-04 Thread GitBox
alirezazamani commented on a change in pull request #446: Fix the order of workflow context update URL: https://github.com/apache/helix/pull/446#discussion_r320910067 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestStopWorkflowWithExecutionDelay.java

[GitHub] [helix] i3wangyi closed issue #427: REST: delete unused default namespaces (/namespaces/default)

2019-09-04 Thread GitBox
i3wangyi closed issue #427: REST: delete unused default namespaces (/namespaces/default) URL: https://github.com/apache/helix/issues/427 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] i3wangyi opened a new pull request #452: Implementation of Trie based data model

2019-09-05 Thread GitBox
i3wangyi opened a new pull request #452: Implementation of Trie based data model URL: https://github.com/apache/helix/pull/452 The PR is to collect early feedbacks This is an automated message from the Apache Git Service. To

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
narendly commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320816969 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
narendly commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320818774 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/OptimalAssignment.java

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
narendly commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320810125 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
narendly commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320810934 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
narendly commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320817877 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/OptimalAssignment.java

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
narendly commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320816566 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
narendly commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320818114 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/OptimalAssignment.java

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
narendly commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320811864 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
narendly commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320811801 ## File path:

[GitHub] [helix] narendly merged pull request #446: Fix the order of workflow context update

2019-09-04 Thread GitBox
narendly merged pull request #446: Fix the order of workflow context update URL: https://github.com/apache/helix/pull/446 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [helix] narendly commented on issue #448: TASK: Fix forceDelete for jobs in JobQueue

2019-09-04 Thread GitBox
narendly commented on issue #448: TASK: Fix forceDelete for jobs in JobQueue URL: https://github.com/apache/helix/pull/448#issuecomment-528047787 This PR is ready to be merged, approved by @alirezazamani @dasahcc . This is an

[GitHub] [helix] narendly closed issue #445: TASK: Fix forceDelete for jobs in JobQueue

2019-09-04 Thread GitBox
narendly closed issue #445: TASK: Fix forceDelete for jobs in JobQueue URL: https://github.com/apache/helix/issues/445 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [helix] alirezazamani commented on issue #409: TASK: Execution delay is not respected for the jobs

2019-09-04 Thread GitBox
alirezazamani commented on issue #409: TASK: Execution delay is not respected for the jobs URL: https://github.com/apache/helix/issues/409#issuecomment-528087241 It is fixed in PR #410. This is an automated message from the

[GitHub] [helix] alirezazamani closed issue #409: TASK: Execution delay is not respected for the jobs

2019-09-04 Thread GitBox
alirezazamani closed issue #409: TASK: Execution delay is not respected for the jobs URL: https://github.com/apache/helix/issues/409 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] jiajunwang edited a comment on issue #443: Implement the WAGED rebalancer with the limited functionality.

2019-09-04 Thread GitBox
jiajunwang edited a comment on issue #443: Implement the WAGED rebalancer with the limited functionality. URL: https://github.com/apache/helix/pull/443#issuecomment-528203897 > > > > > Will you wait for my algorithm implementation part to be checked in? I don't think creating a mock class

[GitHub] [helix] i3wangyi commented on issue #443: Implement the WAGED rebalancer with the limited functionality.

2019-09-04 Thread GitBox
i3wangyi commented on issue #443: Implement the WAGED rebalancer with the limited functionality. URL: https://github.com/apache/helix/pull/443#issuecomment-528129970 Will you wait for my algorithm implementation part to be checked in? I don't think creating a mock class is necessary

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-04 Thread GitBox
i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r321016741 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -87,19

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320929768 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320924931 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320908826 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321018321 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/OptimalAssignment.java

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321017369 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-04 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r320930793 ## File path:

[GitHub] [helix] jiajunwang commented on issue #443: Implement the WAGED rebalancer with the limited functionality.

2019-09-04 Thread GitBox
jiajunwang commented on issue #443: Implement the WAGED rebalancer with the limited functionality. URL: https://github.com/apache/helix/pull/443#issuecomment-528133565 > Will you wait for my algorithm implementation part to be checked in? I don't think creating a mock class is necessary

[GitHub] [helix] pkuwm opened a new pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default")

2019-09-04 Thread GitBox
pkuwm opened a new pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default") URL: https://github.com/apache/helix/pull/449 Issues My PR addresses the following Helix issues and references them in the PR title: It's just some simple refactoring

[GitHub] [helix] i3wangyi commented on issue #443: Implement the WAGED rebalancer with the limited functionality.

2019-09-04 Thread GitBox
i3wangyi commented on issue #443: Implement the WAGED rebalancer with the limited functionality. URL: https://github.com/apache/helix/pull/443#issuecomment-528146361 > > Will you wait for my algorithm implementation part to be checked in? I don't think creating a mock class is necessary

[GitHub] [helix] pkuwm closed pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default")

2019-09-04 Thread GitBox
pkuwm closed pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default") URL: https://github.com/apache/helix/pull/449 This is an automated message from the Apache Git Service. To respond to

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-04 Thread GitBox
narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r321043053 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,277

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-04 Thread GitBox
narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r320827999 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,277

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-04 Thread GitBox
narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r321045017 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,277

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-04 Thread GitBox
narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r320831298 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,277

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-04 Thread GitBox
narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r320828938 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -87,19

[GitHub] [helix] jiajunwang commented on issue #443: Implement the WAGED rebalancer with the limited functionality.

2019-09-04 Thread GitBox
jiajunwang commented on issue #443: Implement the WAGED rebalancer with the limited functionality. URL: https://github.com/apache/helix/pull/443#issuecomment-528172606 > > > Will you wait for my algorithm implementation part to be checked in? I don't think creating a mock class is

[GitHub] [helix] pkuwm opened a new pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default")

2019-09-04 Thread GitBox
pkuwm opened a new pull request #449: [helix-rest] Delete unused default namespace (api "/namespaces/default") URL: https://github.com/apache/helix/pull/449 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: It's just some simple

[GitHub] [helix] jiajunwang commented on issue #443: Implement the WAGED rebalancer with the limited functionality.

2019-09-04 Thread GitBox
jiajunwang commented on issue #443: Implement the WAGED rebalancer with the limited functionality. URL: https://github.com/apache/helix/pull/443#issuecomment-528203897 > > > > > Will you wait for my algorithm implementation part to be checked in? I don't think creating a mock class is

[GitHub] [helix] dasahcc commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider.

2019-09-11 Thread GitBox
dasahcc commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider. URL: https://github.com/apache/helix/pull/458#discussion_r323465350 ## File path:

[GitHub] [helix] i3wangyi opened a new pull request #464: Add soft constraint: ResourcePartitionAntiAffinityConstraint

2019-09-11 Thread GitBox
i3wangyi opened a new pull request #464: Add soft constraint: ResourcePartitionAntiAffinityConstraint URL: https://github.com/apache/helix/pull/464 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: (#421) ###

[GitHub] [helix] jiajunwang commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.

2019-09-11 Thread GitBox
jiajunwang commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer. URL: https://github.com/apache/helix/pull/456#discussion_r323370591 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.

2019-09-11 Thread GitBox
jiajunwang commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer. URL: https://github.com/apache/helix/pull/456#discussion_r323370208 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.

2019-09-11 Thread GitBox
jiajunwang commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer. URL: https://github.com/apache/helix/pull/456#discussion_r323367650 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.

2019-09-11 Thread GitBox
narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer. URL: https://github.com/apache/helix/pull/456#discussion_r323372868 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.

2019-09-11 Thread GitBox
jiajunwang commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer. URL: https://github.com/apache/helix/pull/456#discussion_r323369995 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider.

2019-09-11 Thread GitBox
jiajunwang commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider. URL: https://github.com/apache/helix/pull/458#discussion_r323375459 ## File path: helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java

[GitHub] [helix] jiajunwang commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider.

2019-09-11 Thread GitBox
jiajunwang commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider. URL: https://github.com/apache/helix/pull/458#discussion_r323374355 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider.

2019-09-11 Thread GitBox
pkuwm commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider. URL: https://github.com/apache/helix/pull/458#discussion_r323378258 ## File path: helix-core/src/main/java/org/apache/helix/common/caches/BasicClusterDataCache.java

[GitHub] [helix] i3wangyi commented on a change in pull request #463: Implement LeastUsedInstanceConstraint soft constraint

2019-09-11 Thread GitBox
i3wangyi commented on a change in pull request #463: Implement LeastUsedInstanceConstraint soft constraint URL: https://github.com/apache/helix/pull/463#discussion_r323386973 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321896133 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321899609 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321895628 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321896929 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321911395 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321915391 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321912996 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321917845 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances URL: https://github.com/apache/helix/pull/451#discussion_r321919137 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances URL: https://github.com/apache/helix/pull/451#discussion_r321919317 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances URL: https://github.com/apache/helix/pull/451#discussion_r321918935 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321932548 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances URL: https://github.com/apache/helix/pull/451#discussion_r321868644 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321896912 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321896912 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321900946 ## File path:

[GitHub] [helix] jiajunwang commented on issue #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
jiajunwang commented on issue #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#issuecomment-529005521 > > Another question, by looking at this soft constraint impl, I am wondering if we just enforce all the soft constraint implementation to return

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321932266 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] i3wangyi commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances URL: https://github.com/apache/helix/pull/451#discussion_r321938587 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r321855644 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -87,19

[GitHub] [helix] narendly commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
narendly commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321542831 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
narendly commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321542908 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321935707 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/RebalanceAlgorithm.java

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-06 Thread GitBox
narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r321939034 ## File path: helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java ## @@ -112,6

[GitHub] [helix] jiajunwang commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances URL: https://github.com/apache/helix/pull/451#discussion_r321939027 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r321856105 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordJacksonSerializer.java ## @@ -0,0

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r321856020 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordJacksonSerializer.java ## @@ -0,0

[GitHub] [helix] i3wangyi commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321902725 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r321938110 ## File path: helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java ## @@

[GitHub] [helix] i3wangyi removed a comment on issue #441: Enforce capacity key checks in the WAGED rebalancer.

2019-09-06 Thread GitBox
i3wangyi removed a comment on issue #441: Enforce capacity key checks in the WAGED rebalancer. URL: https://github.com/apache/helix/issues/441#issuecomment-528972362 I suggest let's create a capacity class that takes care of everything (validation/initialization/update/), what do you

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321901535 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321905393 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321931586 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/RebalanceAlgorithm.java

[GitHub] [helix] i3wangyi commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321934135 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321937984 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/RebalanceAlgorithm.java

[GitHub] [helix] jiajunwang commented on a change in pull request #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#discussion_r321901535 ## File path:

[GitHub] [helix] i3wangyi commented on issue #450: Implement one of the soft constraints

2019-09-06 Thread GitBox
i3wangyi commented on issue #450: Implement one of the soft constraints URL: https://github.com/apache/helix/pull/450#issuecomment-529008180 > > > Another question, by looking at this soft constraint impl, I am wondering if we just enforce all the soft constraint implementation to return

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #381: Implement the basic constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r321910212 ## File path: helix-core/src/main/java/org/apache/helix/HelixRebalanceException.java ## @@ -23,21

[GitHub] [helix] alirezazamani opened a new pull request #435: Fix the scenario where a Job that has tasks in Running or Init states get canceled but JobContext does not get updated

2019-09-06 Thread GitBox
alirezazamani opened a new pull request #435: Fix the scenario where a Job that has tasks in Running or Init states get canceled but JobContext does not get updated URL: https://github.com/apache/helix/pull/435 ### Issues - [x] My PR addresses the following Helix issues and references

[GitHub] [helix] i3wangyi commented on issue #441: Enforce capacity key checks in the WAGED rebalancer.

2019-09-06 Thread GitBox
i3wangyi commented on issue #441: Enforce capacity key checks in the WAGED rebalancer. URL: https://github.com/apache/helix/issues/441#issuecomment-528972362 I suggest let's create a capacity class that takes care of everything (validation/initialization/update/), what do you think?

[GitHub] [helix] jiajunwang commented on a change in pull request #369: The fix for assigning partitions when instance weight = 0

2019-09-06 Thread GitBox
jiajunwang commented on a change in pull request #369: The fix for assigning partitions when instance weight = 0 URL: https://github.com/apache/helix/pull/369#discussion_r321909370 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Topology.java

<    2   3   4   5   6   7   8   9   10   11   >