[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#11). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#10). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#9). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. IMPALA-8346: Don't create FE

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 6: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 14: (9 comments) Some more

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 17: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7995: part 2: Jenkins script to automate e2e tests

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12937 ) Change subject: IMPALA-7995: part 2: Jenkins script to automate e2e tests .. IMPALA-7995: part 2: Jenkins script to

[Impala-ASF-CR] IMPALA-7995: part 2: Jenkins script to automate e2e tests

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12937 ) Change subject: IMPALA-7995: part 2: Jenkins script to automate e2e tests .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. IMPALA-7995: part 1: fixes for e2e

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: (6 comments) Looks pretty good to me, a bunch of nits

[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Fix the stale comment on

[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 5: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. IMPALA-7971: Add support for insert events in

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 14: (13 comments)

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 ) Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles .. Patch Set 1: Verified+1

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles

2019-04-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13006 Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles .. IMPALA-7892: [DOCS] Described the new

[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 ) Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 13: (12 comments) I think we

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-12 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13005 Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. IMPALA-8369 : Impala should be able to

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. IMPALA-8390: clean up test vectors in

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#5). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#8). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 4: (1 comment)

[native-toolchain-CR] Add ORC 1.5.5 to toolchain

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12998 ) Change subject: Add ORC 1.5.5 to toolchain .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12998 To

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 3: (15 comments)

[native-toolchain-CR] Add ORC 1.5.5 to toolchain

2019-04-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12998 ) Change subject: Add ORC 1.5.5 to toolchain .. Patch Set 1: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread David Knupp (Code Review)
Hello Bharath Vissapragada, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12958 to look at the new patch set (#5). Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally

[Impala-ASF-CR] IMPALA-7995: part 2: Jenkins script to automate e2e tests

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12937 ) Change subject: IMPALA-7995: part 2: Jenkins script to automate e2e tests .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 7: I have bumped impyla and tested PS5 with

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 10: I'm comfortable with the two sets of eyes on it,

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 17: Code-Review+2 Thanks for getting this

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-12 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 10: Code-Review+1 (1 comment) I've done a decent

[Impala-ASF-CR] IMPALA-7995: part 2: Jenkins script to automate e2e tests

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12937 ) Change subject: IMPALA-7995: part 2: Jenkins script to automate e2e tests .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-12 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Thomas Marshall, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12797 to look at the new patch set (#9). Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 8: (8 comments) Thanks for the comments. All good

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 ) Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2 .. Patch Set 1: Build Successful

[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header

2019-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#6). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

[Impala-ASF-CR] IMPALA-7995: part 2: Jenkins script to automate e2e tests

2019-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12937 ) Change subject: IMPALA-7995: part 2: Jenkins script to automate e2e tests .. Patch Set 8: Code-Review+2 rebased -- To view, visit

[Impala-ASF-CR] IMPALA-7995: part 2: Jenkins script to automate e2e tests

2019-04-12 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12937 to look at the new patch set (#8). Change subject: IMPALA-7995: part 2: Jenkins script to automate e2e tests

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Tim Armstrong (Code Review)
Hello David Knupp, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12639 to look at the new patch set (#17). Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Tim Armstrong (Code Review)
Hello David Knupp, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12639 to look at the new patch set (#16). Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-7995: part 2: Jenkins script to automate e2e tests

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12937 ) Change subject: IMPALA-7995: part 2: Jenkins script to automate e2e tests .. Patch Set 7: Code-Review+2 This makes sense to me. --

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 ) Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2 .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

2019-04-12 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13003 Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2 .. IMPALA-8407: Warn when Impala shell fails to

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 4: Code-Review+1 (1 comment) This

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 15: Code-Review+1 (3 comments) This makes

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. IMPALA-8346: Don't create FE testcase files unless

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-12 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 11: (1 comment)

[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 13: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-12 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-12 Thread Thomas Marshall (Code Review)
Hello David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12960 to look at the new patch set (#3). Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py

[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header

2019-04-12 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13001 Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Fix the stale comment on ImpalaServer::RegisterQuery

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 11: (5 comments)

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-12 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12973 to look at the new patch set (#3). Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-12 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 6: Code-Review+1 (1 comment) LGTM

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 5: (1 comment)

  1   2   >