[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist

2019-11-13 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#3). Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 5: Code-Review+1 Carrying +1. -- To view, visit

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 5: Code-Review+2 Looks good to me

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-13 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14641 to look at the new patch set (#5). Change subject: IMPALA-8138: Reintroduce rpc debugging options

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 4: Code-Review+1 LGTM. Patch looks like it needs to be

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-13 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14641 to look at the new patch set (#4). Change subject: IMPALA-8138: Reintroduce rpc debugging options

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 4: (11 comments)

[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster

2019-11-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. IMPALA-9150: Use HBase's stop-hbase.sh script

[Impala-ASF-CR] IMPALA-8855: [DOCS] Document the generic VALUES clause

2019-11-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14661 ) Change subject: IMPALA-8855: [DOCS] Document the generic VALUES clause .. IMPALA-8855: [DOCS] Document the generic VALUES clause

[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile

2019-11-13 Thread Xiaomeng Zhang (Code Review)
Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 ) Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile .. Patch Set 1: Thanks Tim, I will update

[Impala-ASF-CR] IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode

2019-11-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14700 ) Change subject: IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode .. IMPALA-7506: [DOCS] Global

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 5: I hit

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 ) Change subject: IMPALA-9128: part 2: dump traces for slow RPCs .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

2019-11-13 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14668 to look at the new patch set (#7). Change subject: IMPALA-9128: part 2: dump traces for slow RPCs

[Impala-ASF-CR] IMPALA-8906: Fix flaky profile observability test

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14704 ) Change subject: IMPALA-8906: Fix flaky profile observability test .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode

2019-11-13 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14700 ) Change subject: IMPALA-7506: [DOCS] Global INVALIDATE is supported in local catalog mode .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 13:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. ..

[Impala-ASF-CR] IMPALA-8906: Fix flaky profile observability test

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14704 ) Change subject: IMPALA-8906: Fix flaky profile observability test .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-8906: Fix flaky profile observability test

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14704 ) Change subject: IMPALA-8906: Fix flaky profile observability test .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread wangsheng (Code Review)
Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14319 to look at the new patch set (#11). Change subject: IMPALA-8984: Fix race condition in creating Kudu table

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread wangsheng (Code Review)
Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14319 to look at the new patch set (#10). Change subject: IMPALA-8984: Fix race condition in creating Kudu table

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 9: (6 comments)

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread wangsheng (Code Review)
Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14319 to look at the new patch set (#9). Change subject: IMPALA-8984: Fix race condition in creating Kudu table

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 8: > I recently add a similar test: >

[Impala-ASF-CR] IMPALA-8906: Fix flaky profile observability test

2019-11-13 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14704 Change subject: IMPALA-8906: Fix flaky profile observability test .. IMPALA-8906: Fix flaky profile observability test The

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-11-13 Thread wangsheng (Code Review)
Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14319 to look at the new patch set (#8). Change subject: IMPALA-8984: Fix race condition in creating Kudu table