[Impala-ASF-CR] IMPALA-10870: Add Apache Hive 3.1.2 to the minicluster

2021-10-01 Thread abeltian (Code Review)
abeltian has posted comments on this change. ( http://gerrit.cloudera.org:8080/17793 ) Change subject: IMPALA-10870: Add Apache Hive 3.1.2 to the minicluster .. Patch Set 10: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread abeltian (Code Review)
abeltian has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 2: Code-Review+1 > Patch Set 2: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-10935: Impala crashes on old Iceberg table property

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17877 ) Change subject: IMPALA-10935: Impala crashes on old Iceberg table property .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10935: Impala crashes on old Iceberg table property

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17877 ) Change subject: IMPALA-10935: Impala crashes on old Iceberg table property .. IMPALA-10935: Impala crashes on old

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-01 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17894 to look at the new patch set (#3). Change subject: IMPALA-10950: Update expr-benchmark.cc

[Impala-ASF-CR] IMPALA-10936: Fix NPE in collecting policy tables on FailedLoadLocalTable

2021-10-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17888 ) Change subject: IMPALA-10936: Fix NPE in collecting policy tables on FailedLoadLocalTable .. IMPALA-10936: Fix NPE in

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-01 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17894 to look at the new patch set (#2). Change subject: IMPALA-10950: Update expr-benchmark.cc

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-10-01 Thread Sourabh Goyal (Code Review)
Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Patch Set 11: Code-Review+1 The patch looks good to me. --

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-10-01 Thread Sourabh Goyal (Code Review)
Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Patch Set 11: (1 comment)

[Impala-ASF-CR] POC IMPALA-9498: Allow returning arrays in select list

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 ) Change subject: POC IMPALA-9498: Allow returning arrays in select list .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10936: Fix NPE in collecting policy tables on FailedLoadLocalTable

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17888 ) Change subject: IMPALA-10936: Fix NPE in collecting policy tables on FailedLoadLocalTable .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-01 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17894 Change subject: IMPALA-10950: Update expr-benchmark.cc .. IMPALA-10950: Update expr-benchmark.cc Query planner has move the scalar

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10935: Impala crashes on old Iceberg table property

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17877 ) Change subject: IMPALA-10935: Impala crashes on old Iceberg table property .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10935: Impala crashes on old Iceberg table property

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17877 ) Change subject: IMPALA-10935: Impala crashes on old Iceberg table property .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10935: Impala crashes on old Iceberg table property

2021-10-01 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17877 ) Change subject: IMPALA-10935: Impala crashes on old Iceberg table property .. Patch Set 1: Code-Review+2 Looks great. -- To view,

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 2: Code-Review+2 OK I see the note in the Jira

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 2: (2 comments) QQ to see if I understand what

[Impala-ASF-CR] IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables

2021-10-01 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 ) Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables .. Patch Set 1:

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-01 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 3: (17

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17893 Change subject: IMPALA-10942: Fix memory leak in admission controller .. IMPALA-10942: Fix memory leak in admission controller This

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-10-01 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-10-01 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Patch Set 11: > Build failed:

[Impala-ASF-CR] IMPALA-10914: Consistently schedule scan ranges for Iceberg tables

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17857 ) Change subject: IMPALA-10914: Consistently schedule scan ranges for Iceberg tables .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 ) Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. Patch Set 7: Build Successful

[Impala-ASF-CR] POC IMPALA-9498: Allow returning arrays in select list

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 ) Change subject: POC IMPALA-9498: Allow returning arrays in select list .. Patch Set 6: Build Successful

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 3:

[Impala-ASF-CR] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/17872 ) Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. IMPALA-10811 RPC to submit query getting stuck for

[Impala-ASF-CR] [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 ) Change subject: [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. Patch Set 6: Build Failed

[Impala-ASF-CR] POC IMPALA-9498: Allow returning arrays in select list

2021-10-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 ) Change subject: POC IMPALA-9498: Allow returning arrays in select list .. Patch Set 6: Found the query that caused the crash - I

[Impala-ASF-CR] POC IMPALA-9498: Allow returning arrays in select list

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 ) Change subject: POC IMPALA-9498: Allow returning arrays in select list .. Patch Set 6: Build started:

[Impala-ASF-CR] POC IMPALA-9498: Allow returning arrays in select list

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 ) Change subject: POC IMPALA-9498: Allow returning arrays in select list .. Patch Set 6: (2 comments)

[Impala-ASF-CR] POC IMPALA-9498: Allow returning arrays in select list

2021-10-01 Thread Csaba Ringhofer (Code Review)
Hello Daniel Becker, Gabor Kaszab, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17811 to look at the new patch set (#6). Change subject: POC IMPALA-9498: Allow returning arrays in select list

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-01 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 3: Thanks

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 3:

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-01 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. [WIP] IMPALA-9873: Avoid

[Impala-ASF-CR] [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/17872 ) Change subject: [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. [WIP] IMPALA-10811 RPC to submit query getting

[Impala-ASF-CR] IMPALA-10936: Fix NPE in collecting policy tables on FailedLoadLocalTable

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17888 ) Change subject: IMPALA-10936: Fix NPE in collecting policy tables on FailedLoadLocalTable .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-10936: Fix NPE in collecting policy tables on FailedLoadLocalTable

2021-10-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17888 ) Change subject: IMPALA-10936: Fix NPE in collecting policy tables on FailedLoadLocalTable .. Patch Set 1: Code-Review+2 This makes

[Impala-ASF-CR] [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 ) Change subject: [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. Patch Set 5: Build Failed

[Impala-ASF-CR] [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 ) Change subject: [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. Patch Set 4: Build Failed

[Impala-ASF-CR] [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 ) Change subject: [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. Patch Set 5: (2 comments)

[Impala-ASF-CR] [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 ) Change subject: [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. Patch Set 5: (2 comments)

[Impala-ASF-CR] [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17872 ) Change subject: [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. [WIP] IMPALA-10811 RPC to submit query getting

[Impala-ASF-CR] [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-01 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17872 ) Change subject: [WIP] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. [WIP] IMPALA-10811 RPC to submit query getting

[Impala-ASF-CR] IMPALA-10914: Consistently schedule scan ranges for Iceberg tables

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17857 ) Change subject: IMPALA-10914: Consistently schedule scan ranges for Iceberg tables .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-10914: Consistently schedule scan ranges for Iceberg tables

2021-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17857 ) Change subject: IMPALA-10914: Consistently schedule scan ranges for Iceberg tables .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-10914: Consistently schedule scan ranges for Iceberg tables

2021-10-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Qifan Chen, Vihang Karajgaonkar, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17857 to look at the new patch set (#5). Change subject: IMPALA-10914: Consistently schedule scan ranges for Iceberg

[Impala-ASF-CR] POC IMPALA-9498: Allow returning arrays in select list

2021-10-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 ) Change subject: POC IMPALA-9498: Allow returning arrays in select list .. Patch Set 5: Just took a quick look at the failed test jobs