[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: Verified+1 --

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 20: (6 comments)

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: I need to take this

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-10 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21367 to look at the new patch set (#5). Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21420 Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. IMPALA-13020 (part 2): Split out

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 20: (15 comments)

[Impala-ASF-CR] IMPALA-13038: Support profile tab for imported query profiles

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21400 ) Change subject: IMPALA-13038: Support profile tab for imported query profiles .. IMPALA-13038: Support profile tab for

[Impala-ASF-CR] IMPALA-13038: Support profile tab for imported query profiles

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 ) Change subject: IMPALA-13038: Support profile tab for imported query profiles .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 9: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 20: Build Successful

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 19: Build Successful

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-10 Thread Jason Fehr (Code Review)
Jason Fehr has uploaded a new patch set (#9) to the change originally created by Michael Smith. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. IMPALA-13051: Speed

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-10 Thread Jason Fehr (Code Review)
Jason Fehr has uploaded a new patch set (#8) to the change originally created by Michael Smith. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. IMPALA-13051: Speed

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-10 Thread Jason Fehr (Code Review)
Jason Fehr has uploaded a new patch set (#7) to the change originally created by Michael Smith. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. IMPALA-13051: Speed

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#20). Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread gaurav singh (Code Review)
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 19: (12 comments)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#19). Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-13038: Support profile tab for imported query profiles

2024-05-10 Thread Surya Hebbar (Code Review)
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 ) Change subject: IMPALA-13038: Support profile tab for imported query profiles .. Patch Set 6: Oh okay. -- To view, visit

[Impala-ASF-CR] IMPALA-13038: Support profile tab for imported query profiles

2024-05-10 Thread Surya Hebbar (Code Review)
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 ) Change subject: IMPALA-13038: Support profile tab for imported query profiles .. Patch Set 6: Oh okay. I guess that's what caused the

[Impala-ASF-CR] IMPALA-13038: Support profile tab for imported query profiles

2024-05-10 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 ) Change subject: IMPALA-13038: Support profile tab for imported query profiles .. Patch Set 5: It seems browser caching issue. It's

[Impala-ASF-CR] IMPALA-13038: Support profile tab for imported query profiles

2024-05-10 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 ) Change subject: IMPALA-13038: Support profile tab for imported query profiles .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-13038: Support profile tab for imported query profiles

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 ) Change subject: IMPALA-13038: Support profile tab for imported query profiles .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-13038: Support profile tab for imported query profiles

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 ) Change subject: IMPALA-13038: Support profile tab for imported query profiles .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#18). Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 18: (1 comment)

[Impala-ASF-CR] xxxx HA

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21418 ) Change subject: HA .. Patch Set 2: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/16163/ :

[Impala-ASF-CR] xxxx HA

2024-05-10 Thread ttttttz (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21418 to look at the new patch set (#2). Change subject: HA .. HA Change-Id:

[Impala-ASF-CR] IMPALA-13036: Document Iceberg metadata tables

2024-05-10 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21387 ) Change subject: IMPALA-13036: Document Iceberg metadata tables .. IMPALA-13036: Document Iceberg metadata tables This change

[Impala-ASF-CR] IMPALA-13036: Document Iceberg metadata tables

2024-05-10 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21387 ) Change subject: IMPALA-13036: Document Iceberg metadata tables .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11328: [DOCS] Fix incorrect default value for max errors

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21419 ) Change subject: IMPALA-11328: [DOCS] Fix incorrect default value for max_errors .. IMPALA-11328: [DOCS] Fix incorrect

[Impala-ASF-CR] IMPALA-11328: [DOCS] Fix incorrect default value for max errors

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21419 ) Change subject: IMPALA-11328: [DOCS] Fix incorrect default value for max_errors .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11328: [DOCS] Fix incorrect default value for max errors

2024-05-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21419 ) Change subject: IMPALA-11328: [DOCS] Fix incorrect default value for max_errors .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11328: [DOCS] Fix incorrect default value for max errors

2024-05-10 Thread Anonymous Coward (Code Review)
malhotrasanjana1...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/21419 ) Change subject: IMPALA-11328: [DOCS] Fix incorrect default value for max_errors .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11328: [DOCS] Fix incorrect default value for max errors

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21419 ) Change subject: IMPALA-11328: [DOCS] Fix incorrect default value for max_errors .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-11328: [DOCS] Fix incorrect default value for max errors

2024-05-10 Thread Anonymous Coward (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21419 to look at the new patch set (#2). Change subject: IMPALA-11328: [DOCS] Fix incorrect default value for max_errors

[Impala-ASF-CR] incorrect default value for max errors mentioned in documentation

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21419 ) Change subject: incorrect default value for max_errors mentioned in documentation .. Patch Set 1: Verified+1 Build

[Impala-ASF-CR] incorrect default value for max errors mentioned in documentation

2024-05-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21419 ) Change subject: incorrect default value for max_errors mentioned in documentation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] incorrect default value for max errors mentioned in documentation

2024-05-10 Thread Anonymous Coward (Code Review)
malhotrasanjana1...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21419 Change subject: incorrect default value for max_errors mentioned in documentation .. incorrect default value for

[Impala-ASF-CR] incorrect default value for max errors mentioned in documentation

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21419 ) Change subject: incorrect default value for max_errors mentioned in documentation .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-13038: Support profile tab for imported query profiles

2024-05-10 Thread Surya Hebbar (Code Review)
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 ) Change subject: IMPALA-13038: Support profile tab for imported query profiles .. Patch Set 5: I tried across multiple browsers and

[Impala-ASF-CR] xxxx HA

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21418 ) Change subject: HA .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/16162/ :

[Impala-ASF-CR] xxxx HA

2024-05-10 Thread ttttttz (Code Review)
ttz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21418 Change subject: HA .. HA Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3 --- M be/src/statestore/statestore-catalogd-mgr.cc M

[Impala-ASF-CR] IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 ) Change subject: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables .. Patch Set

[Impala-ASF-CR] IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables

2024-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21409 ) Change subject: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables ..