[Impala-ASF-CR] IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr

2021-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 ) Change subject: IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr .. Patch Set 9: Glad to see someone new getting

[Impala-ASF-CR] IMPALA-10503: testdata load hits hive memory limit errors during hive inserts

2021-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17061 ) Change subject: IMPALA-10503: testdata load hits hive memory limit errors during hive inserts .. Patch Set 2: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9745: Propagate source type when doing constant propagation

2021-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17064 ) Change subject: IMPALA-9745: Propagate source type when doing constant propagation .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 35: (4 comments) I think we should merge this

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char

2021-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char .. Patch Set 13: (5 comments) I looked at the backend change and the

[Impala-ASF-CR] IMPALA-9745: Propagate source type when doing constant propagation

2021-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17064 ) Change subject: IMPALA-9745: Propagate source type when doing constant propagation .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9234: Support Ranger row filtering policies

2021-02-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16976 ) Change subject: IMPALA-9234: Support Ranger row filtering policies .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-4805: Avoid hash exchange before analytic function if appropriate

2021-02-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16888 ) Change subject: IMPALA-4805: Avoid hash exchange before analytic function if appropriate .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10470: Add link to quickstart container from README

2021-02-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17058 ) Change subject: IMPALA-10470: Add link to quickstart container from README .. IMPALA-10470: Add link to quickstart container

[Impala-ASF-CR] IMPALA-10470: Add link to quickstart container from README

2021-02-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17058 ) Change subject: IMPALA-10470: Add link to quickstart container from README .. Patch Set 1: Manually verifying since it's only a

[Impala-ASF-CR] IMPALA-10470: Add link to quickstart container from README

2021-02-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17058 ) Change subject: IMPALA-10470: Add link to quickstart container from README .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

2021-02-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 ) Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output .. Patch Set 4: Hit IMPALA-10501 -- To view, visit

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

2021-02-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 ) Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output .. Patch Set 4: Code-Review+2 fix rat exclusdes -- To

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

2021-02-10 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17050 to look at the new patch set (#4). Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output

[Impala-ASF-CR] IMPALA-10470: Add link to quickstart container from README

2021-02-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17058 Change subject: IMPALA-10470: Add link to quickstart container from README .. IMPALA-10470: Add link to quickstart container from

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

2021-02-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 ) Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output .. Patch Set 2: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

2021-02-10 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17050 to look at the new patch set (#2). Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

2021-02-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 ) Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-09 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#34). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 33: (2 comments)

[Impala-ASF-CR] IMPALA-10469: push quickstart to apache repo

2021-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17030 ) Change subject: IMPALA-10469: push quickstart to apache repo .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10469: push quickstart to apache repo

2021-02-09 Thread Tim Armstrong (Code Review)
Hello Grant Henke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17030 to look at the new patch set (#3). Change subject: IMPALA-10469: push quickstart to apache repo

[Impala-ASF-CR] IMPALA-9586: update query option docs for mt dop

2021-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17043 ) Change subject: IMPALA-9586: update query option docs for mt_dop .. IMPALA-9586: update query option docs for mt_dop There

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

2021-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17050 Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output .. IMPALA-9382: part 3/3 clean up runtime profile v2 text

[Impala-ASF-CR] IMPALA-9586: update query option docs for mt dop

2021-02-08 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17043 to look at the new patch set (#2). Change subject: IMPALA-9586: update query option docs for mt_dop

[Impala-ASF-CR] IMPALA-9586: update query option docs for mt dop

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17043 Change subject: IMPALA-9586: update query option docs for mt_dop .. IMPALA-9586: update query option docs for mt_dop There are

[Impala-ASF-CR] IMPALA-8721: re-enable test hive impala interop

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17042 Change subject: IMPALA-8721: re-enable test_hive_impala_interop .. IMPALA-8721: re-enable test_hive_impala_interop The test now passes

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: (21 comments)

[Impala-ASF-CR] wip

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/17040 ) Change subject: wip .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/17040 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#32). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#31). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] wip

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17040 Change subject: wip .. wip Change-Id: If1919b896ee3e4eaef2d02cf8b1d29d7a0996632 --- M be/src/exec/topn-node.cc M

[Impala-ASF-CR] IMPALA-10469: push quickstart to apache repo

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17030 ) Change subject: IMPALA-10469: push quickstart to apache repo .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10469: push quickstart to apache repo

2021-02-05 Thread Tim Armstrong (Code Review)
Hello Grant Henke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17030 to look at the new patch set (#2). Change subject: IMPALA-10469: push quickstart to apache repo

[Impala-ASF-CR] IMPALA-10469: push quickstart to apache repo

2021-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17030 Change subject: IMPALA-10469: push quickstart to apache repo .. IMPALA-10469: push quickstart to apache repo This adds a script,

[Impala-ASF-CR] IMPALA-10475: [DOCS] elaborate SYNC DDL option

2021-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17027 ) Change subject: IMPALA-10475: [DOCS] elaborate SYNC_DDL option .. IMPALA-10475: [DOCS] elaborate SYNC_DDL option call out

[Impala-ASF-CR] IMPALA-10475: [DOCS] elaborate SYNC DDL option

2021-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17027 ) Change subject: IMPALA-10475: [DOCS] elaborate SYNC_DDL option .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-04 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17015 to look at the new patch set (#2). Change subject: IMPALA-10389: impala-profile-tool container

[Impala-ASF-CR] IMPALA-10274: Initialize impala-python as part of the CMake build

2021-02-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16607 ) Change subject: IMPALA-10274: Initialize impala-python as part of the CMake build .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#30). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#29). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 28: (7 comments)

[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests

2021-02-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 ) Change subject: IMPALA-9588: Add extra logging to cancel tests .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17015 Change subject: IMPALA-10389: impala-profile-tool container .. IMPALA-10389: impala-profile-tool container Add a build step for an

[Impala-ASF-CR] IMPALA-10454: Bump --ssl minimum version to tls1.2

2021-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16988 ) Change subject: IMPALA-10454: Bump --ssl_minimum_version to tls1.2 .. Patch Set 2: Code-Review+2 Thanks for fixing this! -- To

[Impala-ASF-CR] [WIP] IMPALA-9234: Support Ranger row filtering policies

2021-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16976 ) Change subject: [WIP] IMPALA-9234: Support Ranger row filtering policies .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-10382: fix invalid outer join simplification

2021-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16845 ) Change subject: IMPALA-10382: fix invalid outer join simplification .. IMPALA-10382: fix invalid outer join simplification

[Impala-ASF-CR] IMPALA-10382: fix invalid outer join simplification

2021-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16845 ) Change subject: IMPALA-10382: fix invalid outer join simplification .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10274: Initialize impala-python as part of the CMake build

2021-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16607 ) Change subject: IMPALA-10274: Initialize impala-python as part of the CMake build .. Patch Set 4: (3 comments) Seems overall fine,

[Impala-ASF-CR] IMPALA-10382: fix invalid outer join simplification

2021-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16845 ) Change subject: IMPALA-10382: fix invalid outer join simplification .. Patch Set 2: (1 comment) Looks good to me except for a typo

[Impala-ASF-CR] IMPALA-8306: clarify wording on /sessions UI

2021-01-26 Thread Tim Armstrong (Code Review)
Hello Vincent Tran, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16981 to look at the new patch set (#2). Change subject: IMPALA-8306: clarify wording on /sessions UI

[Impala-ASF-CR] IMPALA-8306: clarify wording on /sessions UI

2021-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16981 ) Change subject: IMPALA-8306: clarify wording on /sessions UI .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16982 ) Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support .. IMPALA-10404: Update docs to reflect

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 ) Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 ) Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support .. Patch Set 2: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-26 Thread Tim Armstrong (Code Review)
Hello Zoltan Borok-Nagy, Shajini Thayasingh, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16982 to look at the new patch set (#2). Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 11: Hit IMPALA-10316 -- To view, visit

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#28). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16982 Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support .. IMPALA-10404: Update docs to reflect RLE_DICTIONARY

[Impala-ASF-CR] IMPALA-8306: clarify wording on /sessions UI

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16981 Change subject: IMPALA-8306: clarify wording on /sessions UI .. IMPALA-8306: clarify wording on /sessions UI Change-Id:

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 11: Thanks for the review! -- To view,

[Impala-ASF-CR] WIP: IMPALA-1652: fix char semantics

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/16339 ) Change subject: WIP: IMPALA-1652: fix char semantics .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/16339 To unsubscribe, visit

[Impala-ASF-CR] WIP: IMPALA-1652: fix char semantics

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16339 Change subject: WIP: IMPALA-1652: fix char semantics .. WIP: IMPALA-1652: fix char semantics select 'expected 2',count(*) from ax

[Impala-ASF-CR] WIP: IMPALA-2138: part 4: implicit cast handling

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14399 Change subject: WIP: IMPALA-2138: part 4: implicit cast handling .. WIP: IMPALA-2138: part 4: implicit cast handling This solves some

[Impala-ASF-CR] WIP: IMPALA-2138: part 4: implicit cast handling

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/14399 ) Change subject: WIP: IMPALA-2138: part 4: implicit cast handling .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/14399 To

[Impala-ASF-CR] WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/14216 ) Change subject: WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges .. Abandoned not doing for now -- To view, visit

[Impala-ASF-CR] WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14216 Change subject: WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges .. WIP: IMPALA-2138,IMPALA-1306: project tuples before

[Impala-ASF-CR] WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/16214 ) Change subject: WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen .. Abandoned Now redundant, this was solved in a different way

[Impala-ASF-CR] WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16214 Change subject: WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen .. WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator

[Impala-ASF-CR] IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16908 ) Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions .. Patch Set 11: Code-Review+2

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 27: Rebased onto master after the previous patch was merged --

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#27). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-01-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 32: (4 comments) Few comments related to the

[Impala-ASF-CR] IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions

2021-01-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16908 ) Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns

2021-01-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16947 ) Change subject: IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns .. IMPALA-10435: Extend

[Impala-ASF-CR] IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns

2021-01-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16947 ) Change subject: IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns

2021-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16947 ) Change subject: IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 9: (8 comments)

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-20 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, Grant Henke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15966 to look at the new patch set (#10). Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose

[Impala-ASF-CR] IMPALA-10441: Skip test bytes read per column if not on local minicluster

2021-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16964 ) Change subject: IMPALA-10441: Skip test_bytes_read_per_column if not on local minicluster .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10448: Build impala-profile-tool early for Docker-based tests

2021-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16965 ) Change subject: IMPALA-10448: Build impala-profile-tool early for Docker-based tests .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 30: (10 comments) I think I'm pretty close to

[Impala-ASF-CR] IMPALA-10434: Fix impala-shell's unicode regressions on Python2

2021-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16960 ) Change subject: IMPALA-10434: Fix impala-shell's unicode regressions on Python2 .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns

2021-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16947 ) Change subject: IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns .. Patch Set 2: How does this

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16942 ) Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present .. Patch Set 11: (11 comments)

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-19 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16942 to look at the new patch set (#14). Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16942 ) Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present .. Patch Set 13: (10 comments)

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-15 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16942 to look at the new patch set (#13). Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-15 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16942 to look at the new patch set (#12). Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-15 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#26). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-01-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 27: (19 comments) Another round of comments. I

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 25: Latest patchset fixes the test failure and is ready for

[Impala-ASF-CR] IMPALA-9865: part 2/2: add verbosity to profile tool

2021-01-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16881 ) Change subject: IMPALA-9865: part 2/2: add verbosity to profile tool .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-14 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#25). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#24). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16942 to look at the new patch set (#11). Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present

[Impala-ASF-CR] WIP

2021-01-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/16950 ) Change subject: WIP .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/16950 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16942 to look at the new patch set (#10). Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#23). Change subject: IMPALA-9979: part 2: partitioned top-n

  1   2   3   4   5   6   7   8   9   10   >