[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. IMPALA-10984: Improve TimestampValue to String

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 10: Code-Review+2 Submitting as the GVO failed

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has removed a vote on this change. Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/17980

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has removed a vote on this change. Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Removed -Verified by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/17980 To

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 9: > Patch Set 9: > > Build failed:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 9: Build failed:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 9: GVO over patch set 9 hit flaky test previously

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 8: The GVO failed because I forgot handling for

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-04 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#8). Change subject: IMPALA-10984: Improve TimestampValue to String casting

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-02 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#6). Change subject: IMPALA-10984: Improve TimestampValue to String casting

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-02 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 5: Code-Review+1 Looks great! -- To view, visit

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 5: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 5: (16 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-01 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-01 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#5). Change subject: IMPALA-10984: Improve TimestampValue to String casting

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-01 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#4). Change subject: IMPALA-10984: Improve TimestampValue to String casting

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (1 comment) Thanks for the quick answer of my

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (4 comments) Thank you everyone for the

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (12 comments) Just have some very minor

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: Code-Review+1 (3 comments) lgtm I have some

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-28 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#3). Change subject: IMPALA-10984: Improve TimestampValue to String casting