[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 9: Thank you all for the reviews. -- To view, visit htt

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. IMPALA-3282: Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 8: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/8900

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#7). Change subject: IMPALA-3282: Adds regexp_escape built-in function ..

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/890

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8900

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#6). Change subject: IMPALA-3282: Adds regexp_escape built-in function ..

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 5: (2 comments) Thanks for the iteration! http://ger

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8900

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-16 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#5). Change subject: IMPALA-3282: Adds regexp_escape built-in function ..

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/890

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 4: Code-Review-1 (1 comment) Performance comparison: lin

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 4: (1 comment) Once this makes it in, we should be su

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-06 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#4). Change subject: IMPALA-3282: Adds regexp_escape built-in function ...

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/8900

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-06 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#3). Change subject: IMPALA-3282: Adds regexp_escape built-in function ...

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8900/2/b

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-04 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/8900/

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 2: (1 comment) I didn't take a close look at the code -

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2017-12-20 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. IMPALA-3282: Adds regexp_escape built-in function Escapes the followi

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2017-12-20 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8900 Change subject: IMPALA-3282: Adds regexp_escape built-in function .. IMPALA-3282: Adds regexp_escape built-in function Escapes the follow