[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has abandoned this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8890 To unsubscribe,

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: decided to assert that all plans should be the same on all

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: What's the consensus on this one? If we're not

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: noticed a discrepancy in the s3 ranges from run-to-run for

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: alex, pls have a look and let me know if you have

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: Code-Review+2 I am fine with the change to unblock

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#5). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 4: (1 comment) yes, missed adding the file when renaming.

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 4: (1 comment) Is there a file missing (tpch.test)?

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#4). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-08 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#3). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: For an explanation for the plan difference, pls have a look

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: Thanks for working on that. I am not sure I

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: I agree that it's probably best to unblock first.

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: I thought about it, but since it was relatively localized,

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 1: It might be worth thinking about how to address the

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#2). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 1: Code-Review+1 (1 comment)