[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 24: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. IMPALA-4123: Columnar decoding in Parquet The idea is to

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 24: Build started:

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 24: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 23: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 22: Code-Review+1 I filed IMPALA-7862 and updated the comments

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-16 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#23). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 22: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 21: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 20: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 21: (1 comment) Rebased

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#21). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: (6 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#20). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: (5 comments) I did a pass out of curiosity and only had a

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: Code-Review+1 (1 comment) I read it through again and

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: I think Zoltan was also planning to do a pass over it, so

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 17: (2 comments) WRT to your earlier comment about breaking up

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-14 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#19). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 17: (2 comments) lgtm - I can also give +2 if you do not

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 17: (7 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-12 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#18). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 17: (7 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 16: (5 comments) Addressed comments and ran exhaustive tests

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-09 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#17). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 16: (5 comments) For some reason I did not realize until now

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#16). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 16: Rebased and added HS2_TYPES to test_chars -- To view,

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 14: (2 comments) I'm planning to do another passes in the

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 14: (5 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#15). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 14: Still rerunning exhaustive tests but I feel sufficiently

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 14: (4 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 13: (3 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-23 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#14). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-23 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#13). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#12). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#11). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 12: (3 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 10: Build Failed

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 9: Build Failed

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#10). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 9: Good news! I finally added the missing test coverage. --

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-10-04 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#9). Change subject: IMPALA-4123: Columnar decoding in Parquet