[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-05-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. IMPALA-5031: signed overflow in TimestampValue The

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-05-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-05-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-05-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-04-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-04-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-04-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 4: > Uploaded patch set 4. This has no benchmark

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-04-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4) to the change originally created by Jim Apple. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. IMPALA-5031: signed overflow

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-03-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 3: > > I like the current solution, but I think that it

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-03-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 3: > I like the current solution, but I think that it should

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-03-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 3: I like the current solution, but I think that it

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-03-11 Thread Jim Apple (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11919 to look at the new patch set (#3). Change subject: IMPALA-5031: signed overflow in TimestampValue

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-02-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-02-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-02-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-02-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2018-11-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 1: (1 comment) I have two concerns with the solution:

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2018-11-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2018-11-10 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11919 Change subject: IMPALA-5031: signed overflow in TimestampValue .. IMPALA-5031: signed overflow in TimestampValue The standard says that