[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/12950/4/fe/src/m

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: (6 comments) Looks pretty good to me, a bunch of nits an

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/g

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-c

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-veri

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12950/

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Yongzhi Chen, Vihang Karajgaonkar, Anonymous Coward (486), Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12950 to look at the new patch set (#4). Change subject: Refactor file descriptor loading code

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 3: Got a few test failures on the first dryrun due to not properly ha

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-c

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-veri

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 3: Just uploaded a new version which should be ready for review after

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12950/

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-10 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Yongzhi Chen, Vihang Karajgaonkar, Anonymous Coward (486), Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12950 to look at the new patch set (#3). Change subject: Refactor file descriptor loading code