[Impala-ASF-CR] Update version to 3.2.0-SNAPSHOT

2018-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12053 ) Change subject: Update version to 3.2.0-SNAPSHOT .. Patch Set 2: No, it was my mistake. I shouldn't have done that. I had to

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Greg Rahn, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11955 to look at the new patch set (#6). Change subject: IMPALA-7844: HAVING clause cannot support ordinals

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 5: (3 comments) Thanks for the additional comments.

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12016 to look at the new patch set (#4). Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#12). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 13: Seeing a pre-review test failure; need to investigate.

[Impala-ASF-CR] Symbolize stacktraces in debug builds.

2018-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 ) Change subject: Symbolize stacktraces in debug builds. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 13: Thanks much for making the changes: the code is

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2018-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 7: (22 comments) Thanks! I took a first pass.

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Patch Set 2: Code-Review+2 > tmp-file-mgr-test exercises the code paths.

[Impala-ASF-CR] IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py"

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12096 ) Change subject: IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py" .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-7978: [DOCS] Clarify the memory requirements

2018-12-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12081 ) Change subject: IMPALA-7978: [DOCS] Clarify the memory requirements .. IMPALA-7978: [DOCS] Clarify the memory requirements

[Impala-ASF-CR] IMPALA-7978: [DOCS] Clarify the memory requirements

2018-12-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12081 ) Change subject: IMPALA-7978: [DOCS] Clarify the memory requirements .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] Symbolize stacktraces in debug builds.

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 ) Change subject: Symbolize stacktraces in debug builds. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#11). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 12: Code-Review+2 Thanks for the fixes. This LGTM. -- To view, visit

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 13: Build started:

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Patch Set 2: tmp-file-mgr-test exercises the code paths. It checks the

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Patch Set 3: Build started:

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 13: (14 comments)

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Patch Set 2: Do we have tests for these code paths? -- To view, visit

[Impala-ASF-CR] IMPALA-7963: Don't underflow uint64 t when time goes backwards

2018-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12091 ) Change subject: IMPALA-7963: Don't underflow uint64_t when time goes backwards .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#13). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 11: (6 comments) Thanks for the reviews. Addressed comments and

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 2: Build Successful

[Impala-ASF-CR] Symbolize stacktraces in debug builds.

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 ) Change subject: Symbolize stacktraces in debug builds. .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 4: > To what extent is this the Jackson streaming API?

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#4). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 3: (2 comments) Addressed review comments. Rebased

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12079 to look at the new patch set (#2). Change subject: IMPALA-7968, Part 1: JSON serialization framework ..

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12079 to look at the new patch set (#4). Change subject: IMPALA-7968, Part 1: JSON serialization framework

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 3: (19 comments)

[Impala-ASF-CR] Symbolize stacktraces in debug builds.

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 ) Change subject: Symbolize stacktraces in debug builds. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 4: (5 comments)

[Impala-ASF-CR] Symbolize stacktraces in debug builds.

2018-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 ) Change subject: Symbolize stacktraces in debug builds. .. Patch Set 2: Failure seemed to look flaky to me; retrying before digging

[Impala-ASF-CR] Symbolize stacktraces in debug builds.

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 ) Change subject: Symbolize stacktraces in debug builds. .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py"

2018-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12096 ) Change subject: IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py" .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py"

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12096 ) Change subject: IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py" .. Patch Set 1: Verified+1

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 4: > > To what extent is this the Jackson streaming

[Impala-ASF-CR] Symbolize stacktraces in debug builds.

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 ) Change subject: Symbolize stacktraces in debug builds. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2018-12-14 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12049 to look at the new patch set (#2). Change subject: IMPALA-4555: Make QueryState's status reporting more robust

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2018-12-14 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2018-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 2: Hue polls the HS2 GetLog() endpoint -

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py"

2018-12-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12096 Change subject: IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py" .. IMPALA-7989: Revert "Remove

[Impala-ASF-CR] IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py"

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12096 ) Change subject: IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py" .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7980: Fix spinning threads because of buggy handling of num unqueued files .

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning threads because of buggy handling of num_unqueued_files_. .. Patch Set 1: (2

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12079 to look at the new patch set (#3). Change subject: IMPALA-7968, Part 1: JSON serialization framework

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7980: Fix spinning threads because of buggy handling of num unqueued files .

2018-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12097 Change subject: IMPALA-7980: Fix spinning threads because of buggy handling of num_unqueued_files_. .. IMPALA-7980: Fix spinning

[Impala-ASF-CR] IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py"

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12096 ) Change subject: IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py" .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. IMPALA-7915: Wrap SQL parser to avoid

[Impala-ASF-CR] IMPALA-7980: Fix spinning threads because of buggy handling of num unqueued files .

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning threads because of buggy handling of num_unqueued_files_. .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. IMPALA-7807: Analysis test fixture Refactors the existing

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 13: Verified+1 -- To view, visit

[Impala-ASF-CR] Symbolize stacktraces in debug builds.

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 ) Change subject: Symbolize stacktraces in debug builds. .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Improve SCRATCH_ALLOCATION_FAILED error Adds additional

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12086 Change subject: Added timeout to run-all-tests .. Added timeout to run-all-tests Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 4: Build Failed

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 6: Build Failed

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 12: (1 comment)

[Impala-ASF-CR] Symbolize stacktraces in debug builds.

2018-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12092 Change subject: Symbolize stacktraces in debug builds. .. Symbolize stacktraces in debug builds. It's convenient to have symbols if

[Impala-ASF-CR] IMPALA-7978: [DOCS] Clarify the memory requirements

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12081 ) Change subject: IMPALA-7978: [DOCS] Clarify the memory requirements .. Patch Set 2: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-7963: Don't underflow uint64 t when time goes backwards

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12091 ) Change subject: IMPALA-7963: Don't underflow uint64_t when time goes backwards .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 13: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 2: (21 comments)

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 2: To what extent is this the Jackson streaming API?

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 1: (5 comments) Thanks! This is just below my threshold for asking

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12088 Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Improve SCRATCH_ALLOCATION_FAILED error Adds additional context about how

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Improve SCRATCH_ALLOCATION_FAILED error Adds additional context about how

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Patch Set 1: Build Successful

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 1: Build Failed

[Impala-ASF-CR] Improve SCRATCH ALLOCATION FAILED error

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12088 ) Change subject: Improve SCRATCH_ALLOCATION_FAILED error .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7978: [DOCS] Clarify the memory requirements

2018-12-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12081 ) Change subject: IMPALA-7978: [DOCS] Clarify the memory requirements .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7978: [DOCS] Clarify the memory requirements

2018-12-14 Thread Alex Rodoni (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12081 to look at the new patch set (#2). Change subject: IMPALA-7978: [DOCS] Clarify the memory requirements

[Impala-ASF-CR] IMPALA-7963: Don't underflow uint64 t when time goes backwards

2018-12-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12091 Change subject: IMPALA-7963: Don't underflow uint64_t when time goes backwards .. IMPALA-7963: Don't underflow uint64_t when time goes

[Impala-ASF-CR] IMPALA-7978: [DOCS] Clarify the memory requirements

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12081 ) Change subject: IMPALA-7978: [DOCS] Clarify the memory requirements .. Patch Set 2: Build Started

[Impala-ASF-CR] IMPALA-7978: [DOCS] Clarify the memory requirements

2018-12-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12081 ) Change subject: IMPALA-7978: [DOCS] Clarify the memory requirements .. Patch Set 2: Code-Review+2 Editorial format changes that did not

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#3). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers