[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6109: xfail TestHdfsUnknownErrors::test hdfs safe mode error 255

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8590 ) Change subject: IMPALA-6109: xfail TestHdfsUnknownErrors::test_hdfs_safe_mode_error_255 .. IMPALA-6109: xfail

[Impala-ASF-CR] IMPALA-6109: xfail TestHdfsUnknownErrors::test hdfs safe mode error 255

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8590 ) Change subject: IMPALA-6109: xfail TestHdfsUnknownErrors::test_hdfs_safe_mode_error_255 .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-17 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 9: Added the outer join case in the comment. --

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-17 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. IMPALA-5976: Remove equivalence class computation in FE

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 6: (2 comments)

[Impala-ASF-CR] Pin gen build version's git handling to typical git dir.

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8500 ) Change subject: Pin gen_build_version's git handling to typical git dir. .. Pin gen_build_version's git handling to

[Impala-ASF-CR] Pin gen build version's git handling to typical git dir.

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8500 ) Change subject: Pin gen_build_version's git handling to typical git dir. .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-17 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. IMPALA-5976: Remove equivalence class computation in FE

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-17 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. IMPALA-5976: Remove equivalence class computation in FE

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 5: > The only way to

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8546 to look at the new patch set (#5). Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 4: Code-Review-1 The current plan is to go in a

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 5: (4 comments) We

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-17 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 8: > Patch Set 8: > > > Patch Set

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-17 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 8: > Patch Set 8: > > (1 comment)

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 5: Code-Review+1 Carrying the +1 from Tim -- To view, visit

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. IMPALA-5019: Decimal V2 addition In this patch, we implement the new decimal

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-17 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Michael Brown, Zoltan Borok-Nagy, Philip Zeyliger, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8549 to look at the new patch set (#5). Change subject:

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-17 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Michael Brown, Zoltan Borok-Nagy, Philip Zeyliger, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8549 to look at the new patch set (#4). Change subject:

[Impala-ASF-CR] IMPALA-6109: xfail TestHdfsUnknownErrors::test hdfs safe mode error 255

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8590 ) Change subject: IMPALA-6109: xfail TestHdfsUnknownErrors::test_hdfs_safe_mode_error_255 .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-17 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 4: Lars, can you take care of doing the +2

[Impala-ASF-CR] IMPALA-6109: xfail TestHdfsUnknownErrors::test hdfs safe mode error 255

2017-11-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8590 ) Change subject: IMPALA-6109: xfail TestHdfsUnknownErrors::test_hdfs_safe_mode_error_255 .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 4: Code-Review+1 Looks fine as far as

[Impala-ASF-CR] IMPALA-6109: xfail TestHdfsUnknownErrors::test hdfs safe mode error 255

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8590 Change subject: IMPALA-6109: xfail TestHdfsUnknownErrors::test_hdfs_safe_mode_error_255 .. IMPALA-6109: xfail

[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 ) Change subject: IMPALA-6210: Add query id to lineage graph logging .. Patch Set 1: (4 comments) Thanks! This looks largely good to

[Impala-ASF-CR] IMPALA-4591: Bound Kudu client error mem usage

2017-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8464 ) Change subject: IMPALA-4591: Bound Kudu client error mem usage .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 3: Even simpler, we don't need a new target at all. --

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8581 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 1: Code-Review+2 Walked through this and compared

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Zach Amsden (Code Review)
Hello Michael Brown, Philip Zeyliger, David Knupp, Tim Armstrong, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8580 to look at the new patch set (#3). Change subject: IMPALA-6206: Fix data load failure with -notests

[Impala-ASF-CR] IMPALA-4591: Bound Kudu client error mem usage

2017-11-17 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8464 to look at the new patch set (#3). Change subject: IMPALA-4591: Bound Kudu client error mem usage ..

[Impala-ASF-CR] IMPALA-4591: Bound Kudu client error mem usage

2017-11-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8464 ) Change subject: IMPALA-4591: Bound Kudu client error mem usage .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging

2017-11-17 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8589 Change subject: IMPALA-6210: Add query id to lineage graph logging .. IMPALA-6210: Add query id to lineage graph logging Some tools use

[Impala-ASF-CR] IMPALA-4927: Impala should be able to handle invalid input from Sentry

2017-11-17 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8588 Change subject: IMPALA-4927: Impala should be able to handle invalid input from Sentry .. IMPALA-4927: Impala should be able to handle

[Impala-ASF-CR] Pin gen build version's git handling to typical git dir.

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8500 ) Change subject: Pin gen_build_version's git handling to typical git dir. .. Patch Set 3: Build started:

[Impala-ASF-CR] Pin gen build version's git handling to typical git dir.

2017-11-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8500 ) Change subject: Pin gen_build_version's git handling to typical git dir. .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] Removing testdata/bin/run-hive.sh.

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8503 Change subject: Removing testdata/bin/run-hive.sh. .. Removing testdata/bin/run-hive.sh. I can't find any uses of it. Change-Id:

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. IMPALA-4252: Min-max runtime filters for Kudu This

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 16: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-11-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 3: Code-Review+1 (3 comments) I'm fine with

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 3: > > > > Patch Set 3: > >

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > > Patch Set 3: > > > > > Dan, what's

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-17 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Lars Volker, Matthew Jacobs, Anonymous Coward #345, Tim Armstrong, Todd Lipcon, Mostafa Mokhtar, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7793 to look at the new patch set (#16). Change

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: Taras, can you summarize where we are at (should

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 3: > > > Dan, what's your

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > > Dan, what's your take? > > I think

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Dan, what's your take? I think the

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 9: rebased and tweaked the #define guard to

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-17 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8424 to look at the new patch set (#9). Change subject: IMPALA-4835 (prep only): create io subfolder and namespace

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-11-17 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#10). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 2: Code-Review+2 This makes sense to me. -- To view,

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 6: (26 comments) Patch is looking good!