[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 6: (4 comments) I have some questions on the

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-07 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8784 to look at the new patch set (#3). Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-07 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 2: (9 comments) Thanks

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-07 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, Vuk Ercegovac, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8783 to look at the new patch set (#6). Change subject: IMPALA-6286: Remove invalid runtime filter targets.

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 5: A test failed because the backend expression

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-07 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, Vuk Ercegovac, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8783 to look at the new patch set (#5). Change subject: IMPALA-6286: Remove invalid runtime filter targets.

[Impala-ASF-CR] IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8796 ) Change subject: IMPALA-6292: Fix incorrect DCHECK in decimal subtraction .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8796 ) Change subject: IMPALA-6292: Fix incorrect DCHECK in decimal subtraction .. IMPALA-6292: Fix incorrect DCHECK in

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 18: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

2017-12-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8796 Change subject: IMPALA-6292: Fix incorrect DCHECK in decimal subtraction .. IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: (2 comments) > Nice catch ! Do we have a

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 18: Build started:

[Impala-ASF-CR] IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

2017-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8796 ) Change subject: IMPALA-6292: Fix incorrect DCHECK in decimal subtraction .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5058: Improve the concurrency of DDL/DML operations

2017-12-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8752 ) Change subject: IMPALA-5058: Improve the concurrency of DDL/DML operations .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8796 ) Change subject: IMPALA-6292: Fix incorrect DCHECK in decimal subtraction .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-07 Thread Lars Volker (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#3). Change subject: IMPALA-6190/6246: Add instances tab and event sequence ..

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-07 Thread Tianyi Wang (Code Review)
Hello Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8670 to look at the new patch set (#3). Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest ..

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Hello Philip Zeyliger, Sailesh Mukil, Tim Armstrong, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8788 to look at the new patch set (#4). Change subject: IMPALA-6285: Don't print stack trace on RPC errors.

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 18: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8790 to look at the new patch set (#2). Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 17: Code-Review+1 This looks good to me.

[Impala-ASF-CR] IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts

2017-12-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8791 ) Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. IMPALA-6285: Don't print stack trace on RPC

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 8: (10 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 2: Code-Review+2 (2 comments) I'm assuming Sailesh

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-07 Thread John Russell (Code Review)
Hello Greg Rahn, sandeep akinapelli, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8768 to look at the new patch set (#2). Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

[Impala-ASF-CR] IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts

2017-12-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8791 Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts .. IMPALA-6280: Materialize TupleIsNullPredicate

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 2: Patch set 2 has 'nanoseconds' and 'quarter' removed.

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6081: Fix test basic filters runtime profile failure

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8754 ) Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure .. IMPALA-6081: Fix test_basic_filters

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8569 ) Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function. .. Patch Set 6: Code-Review+2 Rebase and trivial size fix. Tests passed.

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-07 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8569 to look at the new patch set (#6). Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function.

[Impala-ASF-CR] IMPALA-6081: Fix test basic filters runtime profile failure

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8754 ) Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 1: Nice catch ! Do we have a similar problem with the

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-07 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 4: Code-Review+2 Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 1: (2 comments) Seems like the right fix.

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 3: Code-Review+2 Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-07 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8784 to look at the new patch set (#2). Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Hello Philip Zeyliger, Sailesh Mukil, Tim Armstrong, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8788 to look at the new patch set (#3). Change subject: IMPALA-6285: Don't print stack trace on RPC errors.

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8541 Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. IMPALA-6177: Cleanup incomplete

[native-toolchain-CR] Prepare to move automated toolchain builds to a new environment

2017-12-07 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8787 Change subject: Prepare to move automated toolchain builds to a new environment .. Prepare to move automated toolchain builds to a new

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8790 Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-12-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: > Patch Set 2: > > I spoke to Gabor about this a few days ago.

[native-toolchain-CR] Prepare to move automated toolchain builds to a new environment

2017-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8787 ) Change subject: Prepare to move automated toolchain builds to a new environment .. Patch Set 1: Code-Review+2 LGTM once it's tested.

[native-toolchain-CR] Prepare to move automated toolchain builds to a new environment

2017-12-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8787 ) Change subject: Prepare to move automated toolchain builds to a new environment .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 9: Verified+1

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. IMPALA-4671:

[Impala-ASF-CR] IMPALA-6081: Fix test basic filters runtime profile failure

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8754 ) Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 16: Code-Review+1 LGTM; what do you think, Michael? --

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Philip Zeyliger, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8621 to look at the new patch set (#5). Change subject: IMPALA-3703: Store query context in thread-local variables

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 5: (1 comment) Thanks for the review, I

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 9: Build

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 9: Code-Review+2

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-07 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#9). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

[Impala-ASF-CR] IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8471 ) Change subject: IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace .. IMPALA-4671: (part-1) Copy

[Impala-ASF-CR] IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8471 ) Change subject: IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace .. Patch Set 7: Verified+1 Code-Review+2 Since the

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 13: (3 comments) Thanks!

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#13). Change subject: IMPALA-2248: Make

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. IMPALA-6281: Fix use-after-free in InitAuth()

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. IMPALA-6262: Always initialize runtime

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (7 comments) Thanks, for

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 2: (2 comments) The output messages were confirmed with

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. IMPALA-6285: Don't print stack trace on RPC errors. There is not