[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 4: Code-Review+2 Fixed the issue with the

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 3: Code-Review-1 Looks like there's a Python test

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Move symlinked auxiliary tests/* to

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8910 Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. IMPALA-5557: Disable rpc_default_keepalive_time_ms This change makes

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

Michael Ho has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/8909 ) Change subject: KUDU-2237: Allow idle server connection scanning to be disabled .. Removed reviewer Todd Lipcon. -- To view, visit

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8909 ) Change subject: KUDU-2237: Allow idle server connection scanning to be disabled .. Removed reviewer Kudu Jenkins. -- To view,

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8909 ) Change subject: KUDU-2237: Allow idle server connection scanning to be disabled .. Patch Set 1: Clean cherry-pick. -- To view, visit

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8909 to review the following change. Change subject: KUDU-2237: Allow idle server connection scanning to be disabled

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Patch Set 4: Build started:

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Patch Set 4: Code-Review+2 Carrying +2 after rebase. -- To

[Impala-ASF-CR] IMPALA-6231: Implement decimal v2 fuzz test

Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8898 ) Change subject: IMPALA-6231: Implement decimal_v2 fuzz test .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 3: (2 comments) Thanks for the review,

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 3: (2 comments) Let me give the math one last

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 9: (6 comments) LGTM. Some minor comments.

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: I agree that it's probably best to unblock first.

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: I thought about it, but since it was relatively localized,

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 ) Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' .. Patch Set 2: (2 comments) looks pretty solid to me

[Impala-ASF-CR] IMPALA-5528: Add a knob to tune TCMalloc total thread caches size

Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8906 Change subject: IMPALA-5528: Add a knob to tune TCMalloc total thread caches size .. IMPALA-5528: Add a knob to tune TCMalloc total thread

[Impala-ASF-CR] IMPALA-6231: Implement decimal v2 fuzz test

Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8898 ) Change subject: IMPALA-6231: Implement decimal_v2 fuzz test .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 1: It might be worth thinking about how to address the

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#2). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 2: Code-Review+1 (1 comment) I manually compared this