[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 4: (4 comments)

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 5: @Quanlong I sorted out the infra issues. Going forward all

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. IMPALA-5717: Build ORC C++ lib in toolchain This adds the C++

[native-toolchain-CR] CDH-65655: use ssh instead of https for Kudu github

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9560 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. CDH-65655: use ssh instead of https for Kudu github

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 5: Verified+1 Successful build with ID 65-33162f8c3f -- To

[native-toolchain-CR] CDH-65655: use ssh instead of https for Kudu github

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9560 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. Patch Set 2: Successful build with ID 65-33162f8c3f -- To

[native-toolchain-CR] CDH-65655: use ssh instead of https for Kudu github

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9560 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. Patch Set 2: Verified+1 -- To view, visit

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 5: In the time waiting for the infrastructure issues to be

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9564 Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS ALTER

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9563 ) Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6240: [DOCS] Document PARQUET ARRAY RESOLUTION query option

2018-03-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9534 ) Change subject: IMPALA-6240: [DOCS] Document PARQUET_ARRAY_RESOLUTION query option .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 4: Code-Review+2 Thanks for continuing to try and

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has removed Anonymous Coward #381 from this change. ( http://gerrit.cloudera.org:8080/9563 ) Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format .. Removed reviewer null. -- To

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9563 Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format .. IMPALA-6627: [DOCS] Hive incompatibility with

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9544 ) Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9544 ) Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values .. IMPALA-6500: gracefully handle invalid

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9562 Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. IMPALA-6576: Add metrics for data stream service memory

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-08 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly .. Patch Set 4: The above code is added for

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic

2018-03-08 Thread Alan Choi (Code Review)
Alan Choi has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6240: [DOCS] Document PARQUET ARRAY RESOLUTION query option

2018-03-08 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, John Russell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9534 to look at the new patch set (#4). Change subject: IMPALA-6240: [DOCS] Document PARQUET_ARRAY_RESOLUTION query option

[Impala-ASF-CR] IMPALA-6240: [DOCS] Document PARQUET ARRAY RESOLUTION query option

2018-03-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9534 ) Change subject: IMPALA-6240: [DOCS] Document PARQUET_ARRAY_RESOLUTION query option .. Patch Set 2: (12 comments)

[Impala-ASF-CR] IMPALA-6240: [DOCS] Document PARQUET ARRAY RESOLUTION query option

2018-03-08 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, John Russell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9534 to look at the new patch set (#3). Change subject: IMPALA-6240: [DOCS] Document PARQUET_ARRAY_RESOLUTION query option

[Impala-ASF-CR] IMPALA-6523: [DOCS] Allowed values for PARQUET FALLBACK SCHEMA RESOLUTION

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9536 ) Change subject: IMPALA-6523: [DOCS] Allowed values for PARQUET_FALLBACK_SCHEMA_RESOLUTION .. IMPALA-6523: [DOCS]

[Impala-ASF-CR] IMPALA-6523: [DOCS] Allowed values for PARQUET FALLBACK SCHEMA RESOLUTION

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9536 ) Change subject: IMPALA-6523: [DOCS] Allowed values for PARQUET_FALLBACK_SCHEMA_RESOLUTION .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6523: [DOCS] Allowed values for PARQUET FALLBACK SCHEMA RESOLUTION

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9536 ) Change subject: IMPALA-6523: [DOCS] Allowed values for PARQUET_FALLBACK_SCHEMA_RESOLUTION .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6523: [DOCS] Allowed values for PARQUET FALLBACK SCHEMA RESOLUTION

2018-03-08 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9536 ) Change subject: IMPALA-6523: [DOCS] Allowed values for PARQUET_FALLBACK_SCHEMA_RESOLUTION .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6605: Exception hidden on complex types

2018-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/9514 ) Change subject: IMPALA-6605: Exception hidden on complex types .. IMPALA-6605: Exception hidden on complex types This patch fixes the

[Impala-ASF-CR] IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9540 ) Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6523: [DOCS] Allowed values for PARQUET FALLBACK SCHEMA RESOLUTION

2018-03-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9536 ) Change subject: IMPALA-6523: [DOCS] Allowed values for PARQUET_FALLBACK_SCHEMA_RESOLUTION .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6523: [DOCS] Allowed values for PARQUET FALLBACK SCHEMA RESOLUTION

2018-03-08 Thread Alex Rodoni (Code Review)
Hello John Russell, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9536 to look at the new patch set (#5). Change subject: IMPALA-6523: [DOCS] Allowed values for PARQUET_FALLBACK_SCHEMA_RESOLUTION

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic

2018-03-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. IMPALA-6227: more logging in

[native-toolchain-CR] CDH-65655: use ssh instead of https for Kudu github

2018-03-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9560 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. IMPALA-6515: [DOCS]

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 5: Build started:

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic

2018-03-08 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic .. Patch Set 4: (1 comment) Ready for +2 after

[Impala-ASF-CR] IMPALA-6523: [DOCS] Allowed values for PARQUET FALLBACK SCHEMA RESOLUTION

2018-03-08 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9536 ) Change subject: IMPALA-6523: [DOCS] Allowed values for PARQUET_FALLBACK_SCHEMA_RESOLUTION .. Patch Set 4: (1 comment) Ready for a +2

[native-toolchain-CR] CDH-65655: use ssh instead of https for Kudu github

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9560 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. CDH-65655: use ssh instead of https for Kudu github Some

[Impala-ASF-CR] IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9540 ) Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 4: (1 comment)

[native-toolchain-CR] Bump LLVM to 5.0.1

2018-03-08 Thread Bikramjeet Vig (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8932 to look at the new patch set (#2). Change subject: Bump LLVM to 5.0.1 .. Bump LLVM to 5.0.1

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. IMPALA-6394: Restart HDFS when blocks are under replicated

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: I had done the same, but it's still running:

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9544 ) Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9544 ) Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values .. Patch Set 4: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9544 ) Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

2018-03-08 Thread Tim Armstrong (Code Review)
Hello Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9544 to look at the new patch set (#3). Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values ..

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: I started a dry run build:

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 ) Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 ) Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-08 Thread Tim Armstrong (Code Review)
Hello Pranay Singh, Lars Volker, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9556 to look at the new patch set (#2). Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-08 Thread Pranay Singh (Code Review)
Hello anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8936 to look at the new patch set (#10). Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-08 Thread Pranay Singh (Code Review)
Hello anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8936 to look at the new patch set (#9). Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-08 Thread Pranay Singh (Code Review)
Hello anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8936 to look at the new patch set (#8). Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: Code-Review+2 Cherry-picked and resolved

[Impala-ASF-CR] IMPALA-6605: Exception hidden on complex types

2018-03-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9514 ) Change subject: IMPALA-6605: Exception hidden on complex types .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 ) Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

2018-03-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9544 ) Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values .. Patch Set 2: Code-Review+2 (1 comment) Looks good, up

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9555 to look at the new patch set (#2). Change subject: IMPALA-6227: more logging in test_admission_controller

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9501 ) Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. Patch Set 4: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9501 ) Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. Patch Set 4: Code-Review+1 Carry Sailesh's +1 -- To

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9501 ) Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

2018-03-08 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/9494 ) Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5 .. IMPALA-5886 & IMPALA-4812 Update

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 ) Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9556 Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader .. IMPALA-6589: remove invalid DCHECK in parquet reader The DCHECK

[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9538 ) Change subject: IMPALA-6602: fixes flaky expiration test .. Patch Set 5: (1 comment)

[impala-udf-samples-CR] Add Contributing section to README

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9529 ) Change subject: Add Contributing section to README .. Add Contributing section to README Change-Id:

[impala-udf-samples-CR] Add Contributing section to README

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9529 ) Change subject: Add Contributing section to README .. Patch Set 2: (1 comment) I think ultimately we should try to remove the

[impala-udf-samples-CR] Add Contributing section to README

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9529 ) Change subject: Add Contributing section to README .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9529

[impala-udf-samples-CR] Add Contributing section to README

2018-03-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9529 ) Change subject: Add Contributing section to README .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9529

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. Patch Set 1: (1 comment) Seems fine to me, let's hope the extra

[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9538 ) Change subject: IMPALA-6602: fixes flaky expiration test .. Patch Set 5: (1 comment)

[impala-udf-samples-CR] Add Contributing section to README

2018-03-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9529 ) Change subject: Add Contributing section to README .. Patch Set 2: Code-Review+2 (1 comment)

[impala-udf-samples-CR] Add Contributing section to README

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9529 ) Change subject: Add Contributing section to README .. Patch Set 2: You can see how this looks here:

[impala-udf-samples-CR] Add Contributing section to README

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9529 ) Change subject: Add Contributing section to README .. Add Contributing section to README Change-Id:

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9555 Change subject: IMPALA-6227: more logging in test_admission_controller .. IMPALA-6227: more logging in test_admission_controller To

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-08 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 7: Code-Review+1 Thanks -- To view, visit

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-03-08 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-08 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#7). Change subject: IMPALA-3866 Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-6615: CTE query in Impala shell does not show query web links

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9537 ) Change subject: IMPALA-6615: CTE query in Impala shell does not show query web links .. Patch Set 7: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6615: CTE query in Impala shell does not show query web links

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9537 ) Change subject: IMPALA-6615: CTE query in Impala shell does not show query web links .. IMPALA-6615: CTE query in

[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9538 ) Change subject: IMPALA-6602: fixes flaky expiration test .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-08 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9527 to look at the new patch set (#4). Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-08 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9527 to look at the new patch set (#3). Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr