[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-04-02 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 19: (2 comments) Hi Alex, Sorry for the late response.

[Impala-ASF-CR] IMPALA-6769: Avoid pulling incoherent Hadoop dependencies.

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9860 ) Change subject: IMPALA-6769: Avoid pulling incoherent Hadoop dependencies. .. IMPALA-6769: Avoid pulling incoherent

[Impala-ASF-CR] IMPALA-6769: Avoid pulling incoherent Hadoop dependencies.

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9860 ) Change subject: IMPALA-6769: Avoid pulling incoherent Hadoop dependencies. .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. IMPALA-6719: Reset metadata database name

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 ) Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py .. Patch Set 2: Build started:

[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9869 ) Change subject: [DOCS] Updates to the load balancing algorithms section .. [DOCS] Updates to the load balancing

[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9869 ) Change subject: [DOCS] Updates to the load balancing algorithms section .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

2018-04-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9892 ) Change subject: IMPALA-6776: Increase region move timeout. .. Patch Set 1: Code-Review+2 Seems fine; it seems weirdly coincidental that

[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9869 ) Change subject: [DOCS] Updates to the load balancing algorithms section .. Patch Set 5: Build started:

[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9869 ) Change subject: [DOCS] Updates to the load balancing algorithms section .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 2: Build failed:

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-04-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 13: Code-Review+1 (2 comments) I'm happy with this change.

[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py

2018-04-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 ) Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py .. Patch Set 1: Very odd failures that look unrelated.

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-04-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 9: (14 comments) I'm still reading, but figured I'd push

[Impala-ASF-CR] Do clean as part of "bootstrap development.sh"

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9841 ) Change subject: Do clean as part of "bootstrap_development.sh" .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] Do clean as part of "bootstrap development.sh"

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9841 ) Change subject: Do clean as part of "bootstrap_development.sh" .. Do clean as part of "bootstrap_development.sh" This

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-04-02 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#13). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-6711: loosen shell test prompt regex

2018-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9831 ) Change subject: IMPALA-6711: loosen shell test prompt regex .. Patch Set 2: Code-Review+1 carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-6711: loosen shell test prompt regex

2018-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9831 ) Change subject: IMPALA-6711: loosen shell test prompt regex .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6711: loosen shell test prompt regex

2018-04-02 Thread Tim Armstrong (Code Review)
Hello Alex Behm, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9831 to look at the new patch set (#2). Change subject: IMPALA-6711: loosen shell test prompt regex ..

[Impala-ASF-CR] Fixing typo in SimpleLogger::Flush()

2018-04-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9893 ) Change subject: Fixing typo in SimpleLogger::Flush() .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fixing type in SimpleLogger::Flush()

2018-04-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9893 Change subject: Fixing type in SimpleLogger::Flush() .. Fixing type in SimpleLogger::Flush() Change-Id:

[Impala-ASF-CR] Fixing typo in SimpleLogger::Flush()

2018-04-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9893 ) Change subject: Fixing typo in SimpleLogger::Flush() .. Fixing typo in SimpleLogger::Flush() Change-Id:

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

2018-04-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9892 ) Change subject: IMPALA-6776: Increase region move timeout. .. Patch Set 1: I've run the tests with this change, and nothing looked

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

2018-04-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9892 Change subject: IMPALA-6776: Increase region move timeout. .. IMPALA-6776: Increase region move timeout. Some builds are experiencing

[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 ) Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6711: loosen shell test prompt regex

2018-04-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9831 ) Change subject: IMPALA-6711: loosen shell test prompt regex .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6769: Avoid pulling incoherent Hadoop dependencies.

2018-04-02 Thread Philip Zeyliger (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9860 to look at the new patch set (#2). Change subject: IMPALA-6769: Avoid pulling incoherent Hadoop dependencies.

[Impala-ASF-CR] IMPALA-6769: Avoid pulling incoherent Hadoop dependencies.

2018-04-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9860 ) Change subject: IMPALA-6769: Avoid pulling incoherent Hadoop dependencies. .. Patch Set 2: Code-Review+2 Carrying +2. I added

[Impala-ASF-CR] IMPALA-6769: Avoid pulling incoherent Hadoop dependencies.

2018-04-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9860 ) Change subject: IMPALA-6769: Avoid pulling incoherent Hadoop dependencies. .. Patch Set 1: (2 comments) > One question I have: Is

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

2018-04-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9891 ) Change subject: IMPALA-6771: Fix in-predicate set up bug .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. IMPALA-6649: Add fine-grained ALTER privilege Updated

[Impala-ASF-CR] IMPALA-6724: Allow creating/dropping functions with the same name as built-ins

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Allow creating/dropping functions with the same name as built-ins .. IMPALA-6724: Allow

[Impala-ASF-CR] IMPALA-6724: Allow creating/dropping functions with the same name as built-ins

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Allow creating/dropping functions with the same name as built-ins .. Patch Set 16: Verified+1

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-04-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6546: [DOCS] Add the new ODBC functions to docs

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9880 ) Change subject: IMPALA-6546: [DOCS] Add the new ODBC functions to docs .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6546: [DOCS] Add the new ODBC functions to docs

2018-04-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9880 ) Change subject: IMPALA-6546: [DOCS] Add the new ODBC functions to docs .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6445: Test for kudu master address with whitespace

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9876 ) Change subject: IMPALA-6445: Test for kudu master address with whitespace .. IMPALA-6445: Test for kudu master address

[Impala-ASF-CR] Do clean as part of "bootstrap development.sh"

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9841 ) Change subject: Do clean as part of "bootstrap_development.sh" .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables

2018-04-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 ) Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables .. Patch Set 1: I was curious to see if

[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables

2018-04-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9884 ) Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables .. IMPALA-6571: NullPointerException in SHOW

[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 ) Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py

2018-04-02 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9886 Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py .. IMPALA-6780: Fix always-true asserts in

[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables

2018-04-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 ) Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6724: Allow creating/dropping functions with the same name as built-ins

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Allow creating/dropping functions with the same name as built-ins .. Patch Set 16: Build

[Impala-ASF-CR] IMPALA-6739: Exception in ALTER TABLE SET statements

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9819 ) Change subject: IMPALA-6739: Exception in ALTER TABLE SET statements .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-04-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 19: Hi Jinchul, are you planning to continue the work on

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-04-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 10: if we're not going forward with this change, pls

[Impala-ASF-CR] IMPALA-6445: Test for kudu master address with whitespace

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9876 ) Change subject: IMPALA-6445: Test for kudu master address with whitespace .. Patch Set 1: Build started: