[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. IMPALA-6916: Implement COMMENT ON DATABASE This patch

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 11: Verified+1 -- To view, visit

[Impala-ASF-CR] Put ASAN options in CMakeLists.

2018-05-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10404 ) Change subject: Put ASAN options in CMakeLists. .. Patch Set 1: By way of testing, I ran an ASAN build with test-with-docker

[Impala-ASF-CR] Put ASAN options in CMakeLists.

2018-05-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10404 Change subject: Put ASAN options in CMakeLists. .. Put ASAN options in CMakeLists. When running tests with ASAN, you need to set

[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. IMPALA-7018: fix spill-to-disk encryption

[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10366 ) Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon .. Patch Set 2: Verified-1

[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate

2018-05-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. Patch Set 2: Is the invariant that the tree of Exprs

[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate

2018-05-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. IMPALA-7029: Clone LHS when rewriting a between predicate

[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate

2018-05-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. Patch Set 1: (1 comment) > Patch Set 1: > > Do you have a

[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate

2018-05-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. Patch Set 1: Do you have a test case that shows what can

[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate

2018-05-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10401 ) Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10401 ) Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. IMPALA-3813: [DOCS] How

[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate

2018-05-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10402 Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. IMPALA-7029: Clone LHS when rewriting a between predicate

[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling

2018-05-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor

2018-05-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has abandoned this change. ( http://gerrit.cloudera.org:8080/10400 ) Change subject: IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor .. Abandoned Duplicate with the wrong Jira ID -- To

[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10401 ) Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor

2018-05-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10401 ) Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Code-Review+2 --

[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

2018-05-14 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 ) Change subject: IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates .. Patch Set 5: (2

[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor

2018-05-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10401 Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. IMPALA-3813: [DOCS] How to create a Kudu

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. IMPALA-6916: Implement COMMENT ON DATABASE This patch implements updating

[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

2018-05-14 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 ) Change subject: IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates .. Patch Set 8: (4

[Impala-ASF-CR] IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor

2018-05-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10400 ) Change subject: IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor

2018-05-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10400 ) Change subject: IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Code-Review+1 Thanks for

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor

2018-05-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10400 Change subject: IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor .. IMPALA-6827: [DOCS] How to create a Kudu

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: > Safety is one thing, control is

[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling

2018-05-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-14 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 1: Ping? -- To view, visit

[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10366 ) Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 10: (1 comment)

[Impala-ASF-CR] Remove IMPALA THRIFT JAVA VERSION and untested Darwin Thrift versions.

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10361 ) Change subject: Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. .. Remove

[Impala-ASF-CR] Remove IMPALA THRIFT JAVA VERSION and untested Darwin Thrift versions.

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10361 ) Change subject: Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. .. Patch Set 2: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Alex Rodoni (Code Review)
Hello Michael Brown, Harsh J, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10393 to look at the new patch set (#2). Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. IMPALA-6916: Implement COMMENT ON DATABASE This patch implements updating

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 2: (9 comments)

[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10398 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner

2018-05-14 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10398 to review the following change. Change subject: IMPALA-6957: calc thread resource requirement in planner ..

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-14 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10396 to look at the new patch set (#2). Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: > I just checked and Cwiki won't

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10396 Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. IMPALA-3134: Support

[Impala-ASF-CR] IMPALA-7017: deflake/fix test catalog restart test

2018-05-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10397 Change subject: IMPALA-7017: deflake/fix test_catalog_restart test .. IMPALA-7017: deflake/fix test_catalog_restart test The

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: > Ibis looked like a legit site.

[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10392 ) Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. IMPALA-7024: Convert

[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10392 ) Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6957: calc thread resource requirement in planner

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10256 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 9: This change did not cherrypick

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10389 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. IMPALA-5384, part 2: Simplify

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10389 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: > (1 comment) Ibis looked like a

[Impala-ASF-CR] Add a missing PrintId()

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Add a missing PrintId() For consistency, add a PrintId() around a

[Impala-ASF-CR] Add a missing PrintId()

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10391

[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. impala-6233: [DOCS] Documented

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: (1 comment)

[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 3: Build started:

[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

2018-05-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

2018-05-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 2: (1 comment)

[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

2018-05-14 Thread Alex Rodoni (Code Review)
Hello Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10312 to look at the new patch set (#3). Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon

2018-05-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10366 ) Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon .. Patch Set 1: Code-Review+2 --

[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

2018-05-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation

2018-05-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 ) Change subject: IMPALA-6035: Add query options to limit thread reservation .. Patch Set 4: Rebased -- To view, visit

[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE

2018-05-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation

2018-05-14 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10365 to look at the new patch set (#4). Change subject: IMPALA-6035: Add query options to limit thread reservation ..

[Impala-ASF-CR] PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode

2018-05-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10394 Change subject: PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode .. PREVIEW: IMPALA-110 (part 1): Refactor

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 10: (5 comments)

[Impala-ASF-CR] Add a missing PrintId()

2018-05-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Patch Set 2: > Do we have a way to catch these automatically? > > I started looking at

[Impala-ASF-CR] IMPALA-4464: Remove /bin/remote data load.py

2018-05-14 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10388 ) Change subject: IMPALA-4464: Remove /bin/remote_data_load.py .. IMPALA-4464: Remove /bin/remote_data_load.py This file was

[Impala-ASF-CR] IMPALA-4464: Remove /bin/remote data load.py

2018-05-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10388 ) Change subject: IMPALA-4464: Remove /bin/remote_data_load.py .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10393 Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. IMPALA-6827: [DOCS] Updated the download link for

[Impala-ASF-CR] IMPALA-4464: Remove /bin/remote data load.py

2018-05-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10388 ) Change subject: IMPALA-4464: Remove /bin/remote_data_load.py .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Add a missing PrintId()

2018-05-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Patch Set 2: Do we have a way to catch these automatically? I started looking at

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 2: Code-Review+2 IMPALA-7026 -- To view, visit

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-05-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 17: (5 comments) Only a few minor comments, otherwise looks

[Impala-ASF-CR] Remove IMPALA THRIFT JAVA VERSION and untested Darwin Thrift versions.

2018-05-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10361 ) Change subject: Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 1: > Patch Set 1: Verified-1 > > Build failed:

[Impala-ASF-CR] test-with-docker: work with git worktree

2018-05-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10335 ) Change subject: test-with-docker: work with git worktree .. Patch Set 1: (1 comment)

[Impala-ASF-CR] test-with-docker: work with git worktree

2018-05-14 Thread Philip Zeyliger (Code Review)
Hello Joe McDonnell, Kim Jin Chul, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10335 to look at the new patch set (#2). Change subject: test-with-docker: work with git worktree ..

[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

2018-05-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 2: Hi Alex, Could you please review

[Impala-ASF-CR] IMPALA-7000: [DOCS] Correct info about dedicated executors

2018-05-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10357 ) Change subject: IMPALA-7000: [DOCS] Correct info about dedicated executors .. Patch Set 1: Hi Juan, Could you tell me if I can do +2

[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10392 ) Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock

2018-05-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10392 ) Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock

2018-05-14 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10392 Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock For

[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling

2018-05-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] Add a missing PrintId()

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Patch Set 2: Build started:

[Impala-ASF-CR] Add a missing PrintId()

2018-05-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10391 To

[Impala-ASF-CR] Add a missing PrintId()

2018-05-14 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Add a missing PrintId() For consistency, add a PrintId() around a query_id() used in a stream,

[Impala-ASF-CR] Add a missing PrintId()

2018-05-14 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10391 Change subject: Add a missing PrintId() .. Add a missing PrintId() For consistency, add a PrintId() around a query_id() used in a stream,

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10389 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 2: Build started:

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10389 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 2: Code-Review+2 Add missing a

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-14 Thread Dan Hecht (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10389 to look at the new patch set (#2). Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

  1   2   >