[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 6: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 7: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. IMPALA-7135. Skeleton implementation of LocalCa

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. IMPALA-7174: fix test_cancellation for RELEASE

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 3: Verified+1 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-7111: avoid use of boost::split in CheckPluginEnabled

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10709 ) Change subject: IMPALA-7111: avoid use of boost::split in CheckPluginEnabled .. IMPALA-7111: avoid use of boost::split

[Impala-ASF-CR] IMPALA-7111: avoid use of boost::split in CheckPluginEnabled

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10709 ) Change subject: IMPALA-7111: avoid use of boost::split in CheckPluginEnabled .. Patch Set 4: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-5604: document DISABLE CODEGEN ROWS THRESHOLD

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10727 ) Change subject: IMPALA-5604: document DISABLE_CODEGEN_ROWS_THRESHOLD .. IMPALA-5604: document DISABLE_CODEGEN_ROWS_THRE

[Impala-ASF-CR] IMPALA-5604: document DISABLE CODEGEN ROWS THRESHOLD

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10727 ) Change subject: IMPALA-5604: document DISABLE_CODEGEN_ROWS_THRESHOLD .. Patch Set 1: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-5604: document DISABLE CODEGEN ROWS THRESHOLD

2018-06-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10727 ) Change subject: IMPALA-5604: document DISABLE_CODEGEN_ROWS_THRESHOLD .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-5604: document DISABLE CODEGEN ROWS THRESHOLD

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10727 ) Change subject: IMPALA-5604: document DISABLE_CODEGEN_ROWS_THRESHOLD .. Patch Set 1: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7140 (part 3): load partitions for FS tables

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10713 ) Change subject: IMPALA-7140 (part 3): load partitions for FS tables .. Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 7: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 7: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: (3 comments) This looks ok to me. I trust Taras has a deeper

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 7: This change did not c

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. IMPALA-6917: Implement COMMENT ON TABLE/VIEW This patc

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 3: Code-Review-1 (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 2: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 6: Verified+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. IMPALA-6942: Reword error

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. Patch Set 3: Verified+1 -- To v

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 3: Hit HBase flake in data log -- To view, visit

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 3: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 3: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 2: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5604: document DISABLE CODEGEN ROWS THRESHOLD

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10727 Change subject: IMPALA-5604: document DISABLE_CODEGEN_ROWS_THRESHOLD .. IMPALA-5604: document DISABLE_CODEGEN_ROWS_THRESHOLD Also fix a

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 2: Code-Review+2 Sounds fine. And I'll be sure not to r

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 2: Verified-1 Build failed: https://jenkins

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 6: Verified+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. IMPALA-7128 (part 2): add an interface for d

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. IMPALA-5168: Codegen HASH_PARTIT

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 9: Verified+1 -- To view, vi

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 4: I'm fine with it.. one more small change needed to

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-7111: avoid use of boost::split in CheckPluginEnabled

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10709 ) Change subject: IMPALA-7111: avoid use of boost::split in CheckPluginEnabled .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7111: avoid use of boost::split in CheckPluginEnabled

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10709 ) Change subject: IMPALA-7111: avoid use of boost::split in CheckPluginEnabled .. Patch Set 4: Build started: https://jenkins.im

[Impala-ASF-CR] Fail cleanly when in process server can't bind

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10726 Change subject: Fail cleanly when in process server can't bind .. Fail cleanly when in process server can't bind This doesn't solve IMP

[Impala-ASF-CR] IMPALA-7111: avoid use of boost::split in CheckPluginEnabled

2018-06-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10709 ) Change subject: IMPALA-7111: avoid use of boost::split in CheckPluginEnabled .. Patch Set 3: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7111: avoid use of boost::split in CheckPluginEnabled

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10709 ) Change subject: IMPALA-7111: avoid use of boost::split in CheckPluginEnabled .. Patch Set 3: Does someone want to +2? -- To view, vi

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 4: I think this should be ok to merge whenever Vuk is

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 2: (12 comments) Can also update the AuthorizationTes

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. IMPALA-5552: Add support for authorized proxy groups T

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 2: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/10719 ) Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation .. Abandoned Replaced with the actual fix. -- To view, visit htt

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. IMPALA-7174: fix test_cancellation for RELEASE builds The test

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10722 Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. IMPALA-7174: fix test_cancellation for RELEASE builds The test

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 2: This looks good to the best of my knowledge but I

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-14 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10720 Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. IMPALA-6305: Allow column definitions in ALTER VIEW This chan

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 3: Code-Review+1 Got it.. thanks for pointing me to that. -- To

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10719 ) Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation .. Patch Set 2: I'm pretty sure I figured out the root

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10503/3/test

[Impala-ASF-CR] IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare()

2018-06-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10680 ) Change subject: IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare() .. Patch Set 3: (2 comments) http://g

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 3: (1 comment) Thanks for doing this, seems like a really pragmat

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10719 Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation .. IMPALA-7174: xfail test_admission_controller.test_canc

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10719 ) Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation .. Patch Set 2: Build started: https://jenkins.

[Impala-ASF-CR] IMPALA-7140 (part 2). Create skeleton for LocalFsTable

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10712 ) Change subject: IMPALA-7140 (part 2). Create skeleton for LocalFsTable .. Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#6). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 6: Build started: https://jenkins.impala.

[Impala-ASF-CR] Optimize dependencies for Codegen

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 ) Change subject: Optimize dependencies for Codegen .. Patch Set 1: Looks like the current way was done as a result of IMPALA-1896. Could yo

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread Thomas Marshall (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10503 to look at the new patch set (#3). Change subject: IMPALA-6812: Fix flaky Kudu scan tests

[Impala-ASF-CR](2.x) IMPALA-5216: Make admission control queuing async

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10715 ) Change subject: IMPALA-5216: Make admission control queuing async .. IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR](2.x) IMPALA-5216: Make admission control queuing async

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10715 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

2018-06-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10679 ) Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/10

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. Patch Set 2: Code-Review+2 (1 comment) Carr

[Impala-ASF-CR] [DOCS] Wording changes in DPP examples for clarity

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10718 ) Change subject: [DOCS] Wording changes in DPP examples for clarity .. [DOCS] Wording changes in DPP examples for clarit

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. Patch Set 3: Code-Review+2 -- T

[Impala-ASF-CR] [DOCS] Wording changes in DPP examples for clarity

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10718 ) Change subject: [DOCS] Wording changes in DPP examples for clarity .. Patch Set 1: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. Patch Set 3: Build started: http

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10717 to look at the new patch set (#2). Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .

[Impala-ASF-CR] IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled" .. Patch Set 1: Code-Review+2 I agree wi

[Impala-ASF-CR] IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled" .. Patch Set 1: (1 comment) http://gerrit.c

[Impala-ASF-CR] [DOCS] Wording changes in DPP examples for clarity

2018-06-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10718 ) Change subject: [DOCS] Wording changes in DPP examples for clarity .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] [DOCS] Wording changes in DPP examples for clarity

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10718 ) Change subject: [DOCS] Wording changes in DPP examples for clarity .. Patch Set 1: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] [DOCS] Wording changes in DPP examples for clarity

2018-06-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10718 Change subject: [DOCS] Wording changes in DPP examples for clarity .. [DOCS] Wording changes in DPP examples for clarity Change-Id: If786

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 6: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 6: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 5: Verified-1 Build failed: https://jenki

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 2: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10631 ) Change subject: IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading .. Patch Set 7: Code-Review+2 -- To v

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 7: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 9: Build started: https://jen

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 6: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10717 Change subject: IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled" .. IMPALA-6942: Reword error message to be say

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 9: Code-Review+2 Fixed another clang-tid

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10421 to look at the new patch set (#8). Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. IMPALA-7016: Implement ALTER DATABASE SET OWNER Alt

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 5: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#5). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .

[Impala-ASF-CR] IMPALA-7046: introduce "global" debug actions

2018-06-14 Thread Dan Hecht (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10690 to look at the new patch set (#5). Change subject: IMPALA-7046: introduce "global" debug_actions .. IMPALA-7046:

  1   2   >