[Impala-ASF-CR] IMPALA-8850: is percent not initialized in TmpFileMgr parser

2019-08-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14040 ) Change subject: IMPALA-8850: is_percent not initialized in TmpFileMgr parser .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8848: fix UNION missing input cardinality bug

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14036 ) Change subject: IMPALA-8848: fix UNION missing input cardinality bug .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 ) Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala .. Patch Set 5: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 7: Verified+1 Build

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

2019-08-09 Thread Alex Rodoni (Code Review)
Hello Gabor Kaszab, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13983 to look at the new patch set (#5). Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 ) Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala .. Patch Set 5: Build Started

[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 7: Build Started

[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala

2019-08-09 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Tamas Mate, Lars Volker, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14021 to look at the new patch set (#7). Change subject:

[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala

2019-08-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-8848: fix UNION missing input cardinality bug

2019-08-09 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14036 to look at the new patch set (#3). Change subject: IMPALA-8848: fix UNION missing input cardinality bug

[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-8839: Remove COLUMN STATS ACCURATE from properties

2019-08-09 Thread Yongzhi Chen (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14037 to look at the new patch set (#4). Change subject: IMPALA-8839: Remove COLUMN_STATS_ACCURATE from properties

[Impala-ASF-CR] IMPALA-8766: Undo hadoop-cloud-storage + HWX Nexus

2019-08-09 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14024 ) Change subject: IMPALA-8766: Undo hadoop-cloud-storage + HWX Nexus .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables

2019-08-09 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14038 ) Change subject: IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala

2019-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 3: Verified-1 Build

[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-08-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 1: Can you rebase? I can submit for a GVO. --

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 ) Change subject: IMPALA-4551: Limit the size of SQL statements .. Patch Set 1: (4 comments) lgtm overall. Some general

[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS

2019-08-09 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14039 to look at the new patch set (#3). Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS

[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS

2019-08-09 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 3: > Uploaded patch set 3. Fixed a few

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 ) Change subject: IMPALA-4551: Limit the size of SQL statements .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8755: Frontend support for Z-ordering

2019-08-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13955 ) Change subject: IMPALA-8755: Frontend support for Z-ordering .. Patch Set 6: (4 comments)

[Impala-ASF-CR] WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2.

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 ) Change subject: WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 ) Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-09 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14026 to look at the new patch set (#3). Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

[Impala-ASF-CR] IMPALA-8848: fix UNION missing input cardinality bug

2019-08-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14036 ) Change subject: IMPALA-8848: fix UNION missing input cardinality bug .. Patch Set 2: (4 comments) lgtm, just a bunch of

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 ) Change subject: IMPALA-4551: Limit the size of SQL statements .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 ) Change subject: IMPALA-4551: Limit the size of SQL statements .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-09 Thread Joe McDonnell (Code Review)
Hello Bharath Vissapragada, Michael Ho, Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14012 to look at the new patch set (#2). Change subject: IMPALA-4551: Limit the size of SQL statements

[Impala-ASF-CR] WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2.

2019-08-09 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14043 ) Change subject: WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. .. WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. HIVE-22046

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

2019-08-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 ) Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. .. Patch Set 7: (6 comments)

[Impala-ASF-CR] WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2.

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 ) Change subject: WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8839: Remove COLUMN STATS ACCURATE from properties

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14037 ) Change subject: IMPALA-8839: Remove COLUMN_STATS_ACCURATE from properties .. Patch Set 3: Build Successful

[Impala-ASF-CR] WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2.

2019-08-09 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14043 Change subject: WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. .. WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. HIVE-22046

[Impala-ASF-CR] IMPALA-8839: Remove COLUMN STATS ACCURATE from properties

2019-08-09 Thread Yongzhi Chen (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14037 to look at the new patch set (#3). Change subject: IMPALA-8839: Remove COLUMN_STATS_ACCURATE from properties

[Impala-ASF-CR] WIP: IMPALA-8842: Change column stat HMS calls to accommodate HIVE-22046.

2019-08-09 Thread Attila Jeges (Code Review)
Attila Jeges has abandoned this change. ( http://gerrit.cloudera.org:8080/14032 ) Change subject: WIP: IMPALA-8842: Change column stat HMS calls to accommodate HIVE-22046. .. Abandoned Accommodating HIVE-22046 in Impala will

[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14042 ) Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put

2019-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14042 ) Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14038 ) Change subject: IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put

2019-08-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14042 Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put .. IMPALA-8846: Undefined behaviour in RleEncoder::Put To test for

[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 ) Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 ) Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8796: Restrict bit unpacking to unsigned integer types

2019-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14031 ) Change subject: IMPALA-8796: Restrict bit unpacking to unsigned integer types .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues

2019-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 ) Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables

2019-08-09 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14038 to look at the new patch set (#5). Change subject: IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables

[Impala-ASF-CR] IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14038 ) Change subject: IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables .. Patch Set 4: Build Failed

[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 ) Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables

2019-08-09 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14038 to look at the new patch set (#4). Change subject: IMPALA-8823 WIP: DROP TABLE support for insert-only ACID tables

[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues

2019-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 ) Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues

2019-08-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14004 ) Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues .. IMPALA-8796: Add unit tests to UnpackAndDecodeValues Adding

[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues

2019-08-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14004 ) Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues .. IMPALA-8796: Add unit tests to UnpackAndDecodeValues Adding

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

2019-08-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 ) Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala .. Patch Set 4: Code-Review+1 I'm fine with the review.