[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. IMPALA-8944: Update and re-enable S3PlannerTest

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 4: Verified-1 Build

[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. IMPALA-8761: Improve events

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 5: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Sahil Takiar (Code Review)
Hello Bharath Vissapragada, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14248 to look at the new patch set (#5). Change subject: IMPALA-8944: Update and re-enable S3PlannerTest

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 18: Verified-1 Build

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 19: (11 comments) Thanks for

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 5: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14246 to look at the new patch set (#5). Change subject: IMPALA-8634: Catalog client should retry RPCs

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14247 ) Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-18 Thread Sahil Takiar (Code Review)
Hello Alex Rodoni, David Rorke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14247 to look at the new patch set (#3). Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14247 ) Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-18 Thread Sahil Takiar (Code Review)
Hello Alex Rodoni, David Rorke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14247 to look at the new patch set (#2). Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 4: Code-Review+2 (1 comment)

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 10: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 4: Build started:

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 10: I'm going to do a full docker build with the

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 4: Code-Review+2 -- To

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 9: (3 comments)

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#10). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 22: Build Successful

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (9 comments)

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-09-18 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#22). ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.

2019-09-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.

2019-09-18 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. IMPALA-8761: Improve events processor

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14247 ) Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores .. Patch Set 1: (1 comment) First pass, the

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 18: Build started:

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 18: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 17: Code-Review+2 Carrying

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-18 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#17). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 17: (2 comments)

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 3: Code-Review+2 Carrying +2. -- To view, visit

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Sahil Takiar (Code Review)
Hello Bharath Vissapragada, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14248 to look at the new patch set (#3). Change subject: IMPALA-8944: Update and re-enable S3PlannerTest

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Sahil Takiar (Code Review)
Hello Bharath Vissapragada, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14248 to look at the new patch set (#2). Change subject: IMPALA-8944: Update and re-enable S3PlannerTest

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14246 to look at the new patch set (#4). Change subject: IMPALA-8634: Catalog client should retry RPCs

[Impala-ASF-CR] IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 19: Verified-1 Build

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-09-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 20: Code-Review+1 (4 comments) I'll

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 1: Code-Review+1 This makes sense to me. (I'm willing to

[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.

2019-09-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. Patch Set 2: Code-Review+2 (4 comments)

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 9: Code-Review+2 (3 comments) Couple nits, but

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 1: Code-Review+1 (1 comment) I'll let Joe take

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 16: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-18 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14214 to look at the new patch set (#3). Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

[Impala-ASF-CR] IMPALA-8948: [DOCS] Impala cannot write to compressed text file

2019-09-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14237 ) Change subject: IMPALA-8948: [DOCS] Impala cannot write to compressed text file .. IMPALA-8948: [DOCS] Impala cannot write to

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 3: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-8948: [DOCS] Impala cannot write to compressed text file

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14237 ) Change subject: IMPALA-8948: [DOCS] Impala cannot write to compressed text file .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8948: [DOCS] Impala cannot write to compressed text file

2019-09-18 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/14237 ) Change subject: IMPALA-8948: [DOCS] Impala cannot write to compressed text file .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-18 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Norbert Luksa, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14249 to look at the new patch set (#3). Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 3: Build Started

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 8: (2 comments) I had to make a couple of other

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#9). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#8). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[Impala-ASF-CR] [DOCS] Fixed a typo in Impala logs location to /var/log

2019-09-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14254 ) Change subject: [DOCS] Fixed a typo in Impala logs location to /var/log .. [DOCS] Fixed a typo in Impala logs location to

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 20: Build Successful

[Impala-ASF-CR] [DOCS] Fixed a typo in Impala logs location to /var/log

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14254 ) Change subject: [DOCS] Fixed a typo in Impala logs location to /var/log .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] [DOCS] Fixed a typo in Impala logs location to /var/log

2019-09-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14254 ) Change subject: [DOCS] Fixed a typo in Impala logs location to /var/log .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Fixed a typo in Impala logs location to /var/log

2019-09-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14254 Change subject: [DOCS] Fixed a typo in Impala logs location to /var/log .. [DOCS] Fixed a typo in Impala logs location to /var/log

[Impala-ASF-CR] [DOCS] Fixed a typo in Impala logs location to /var/log

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14254 ) Change subject: [DOCS] Fixed a typo in Impala logs location to /var/log .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-09-18 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

[Impala-ASF-CR] IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-09-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 19: Code-Review+1 I'm

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 2: Code-Review+1 Lgtm, I can give the

[Impala-ASF-CR] IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 19: Build started:

[Impala-ASF-CR] IMPALA-8842 part 2: (Hive3) Use 'engine' field in HMS stat API

2019-09-18 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14108 ) Change subject: IMPALA-8842 part 2: (Hive3) Use 'engine' field in HMS stat API .. Patch Set 1: > (2 comments) Thanks for taking a

[Impala-ASF-CR] IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1

2019-09-18 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13722 ) Change subject: IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1 .. Patch Set 22: (2 comments) Thanks for making the

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14234 to look at the new patch set (#3). Change subject: IMPALA-7637: Add more hash table stats to profile

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 2: (3 comments) New patch refactoring code to address

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14234 to look at the new patch set (#2). Change subject: IMPALA-7637: Add more hash table stats to profile

[Impala-ASF-CR] IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13722 ) Change subject: IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1 .. Patch Set 22: Build Successful

[Impala-ASF-CR] IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1

2019-09-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13722 ) Change subject: IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1 .. Patch Set 22: (9 comments)

[Impala-ASF-CR] IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1

2019-09-18 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13722 to look at the new patch set (#22). Change subject: IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 1: (3 comments)