[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 8: Verified-1 Build

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 8: Build Successful

[Impala-ASF-CR] Filter out "Checksum validation failed" messages during the maven build

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15775 ) Change subject: Filter out "Checksum validation failed" messages during the maven build .. Patch Set 4: Build started:

[Impala-ASF-CR] [WIP] IMPALA-2658: Extend the NDV function to accept a precision

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 ) Change subject: [WIP] IMPALA-2658: Extend the NDV function to accept a precision .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. IMPALA-9791: Support validWriteIdList in

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. IMPALA-9782: fix Kudu DML with mt_dop In general, ScalarExpr

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] [WIP] IMPALA-2658: Extend the NDV function to accept a precision

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 ) Change subject: [WIP] IMPALA-2658: Extend the NDV function to accept a precision .. Patch Set 11: (16 comments)

[Impala-ASF-CR] [WIP] IMPALA-2658: Extend the NDV function to accept a precision

2020-06-04 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/15997 ) Change subject: [WIP] IMPALA-2658: Extend the NDV function to accept a precision .. [WIP] IMPALA-2658: Extend the NDV function to accept a

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 11: Build failed:

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (4 comments)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (4 comments) I'm thinking through

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. IMPALA-9791: Support validWriteIdList in

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 5: Build Failed

[Impala-ASF-CR] Filter out "Checksum validation failed" messages during the maven build

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15775 ) Change subject: Filter out "Checksum validation failed" messages during the maven build .. Patch Set 4: Verified-1 Build

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. IMPALA-9791: Support validWriteIdList in

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. Patch Set 3: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16029 to look at the new patch set (#3). Change subject: IMPALA-9782: fix Kudu DML with mt_dop

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 11: Build started:

[Impala-ASF-CR] Filter out "Checksum validation failed" messages during the maven build

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15775 ) Change subject: Filter out "Checksum validation failed" messages during the maven build .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-9824: MetastoreClientPool should be singleton

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16030 ) Change subject: IMPALA-9824: MetastoreClientPool should be singleton .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-06-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 24: Could you do a pass over this with

[Impala-ASF-CR] IMPALA-9824: MetastoreClientPool should be singleton

2020-06-04 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16030 Change subject: IMPALA-9824: MetastoreClientPool should be singleton .. IMPALA-9824: MetastoreClientPool should be singleton

[Impala-ASF-CR] IMPALA-9782: fix Kudu DML with mt dop

2020-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16029 ) Change subject: IMPALA-9782: fix Kudu DML with mt_dop .. IMPALA-9782: fix Kudu DML with mt_dop In general, ScalarExpr subclasses should

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (7 comments)

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (7 comments) The change looks good

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16001 to look at the new patch set (#4). Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate a

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. IMPALA-9791: Support validWriteIdList in

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate a

2020-06-04 Thread Martin Zink (Code Review)
Martin Zink has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and