[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9797 to look at the new patch set (#3). Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9797 to look at the new patch set (#4). Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 4: Code-Review+2 Carry +2. Fixed clang-tidy

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 3: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 5: (13 comments)

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. IMPALA-6685: Improve profiles in

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-28 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#7). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-28 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#8). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 8: Code-Review+2 Fix

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#6). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 6: Code-Review+2 Rebase.

[Impala-ASF-CR] Revert "IMPALA-6747: Automate diagnostics collection."

2018-03-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9872 ) Change subject: Revert "IMPALA-6747: Automate diagnostics collection." .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9842 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Do clean as part of "bootstrap development.sh"

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9841 ) Change subject: Do clean as part of "bootstrap_development.sh" .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9844 ) Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 4: (16 comments)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-24 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#4). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-25 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9797 Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. IMPALA-6728: Always use Kudu based kinit if

[Impala-ASF-CR] Revert "IMPALA-6747: Automate diagnostics collection."

2018-03-30 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9872 ) Change subject: Revert "IMPALA-6747: Automate diagnostics collection." .. Revert "IMPALA-6747: Automate diagnostics collection."

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 1: (4 comments)

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9807 to review the following change. Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() ..

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Patch Set 1: Clean cherry-pick. -- To view, visit

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Removed reviewer Todd Lipcon. -- To view, visit

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9797 to look at the new patch set (#2). Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-16 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9690 Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. IMPALA-6685: Improve profiles in

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6713: Fix format string error in Sorter

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9740 Change subject: IMPALA-6713: Fix format string error in Sorter .. IMPALA-6713: Fix format string error in Sorter This change fixes a

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 2: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#2). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#3). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9748 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9446 to look at the new patch set (#5). Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() ..

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 6: Code-Review+2 Rebased and reverted bumping the memory limit in

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-04 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#5). Change subject: IMPALA-2567: Enable KRPC by default

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-04 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#6). Change subject: IMPALA-2567: Enable KRPC by default

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#3). Change subject: IMPALA-2567: Enable KRPC by default .. IMPALA-2567:

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 2: (3 comments) The existing jenkins jobs to test with KRPC enabled

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#4). Change subject: IMPALA-2567: Enable KRPC by default .. IMPALA-2567:

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 4: Hold off from merging until the builds are in better shape. -- To

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. IMPALA-7213, IMPALA-7241: Port ReportExecStatus()

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 14: (8 comments)

[Impala-ASF-CR] IMPALA-2063 Remove newline characters in query status.

2018-10-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 ) Change subject: IMPALA-2063 Remove newline characters in query status. .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2063 Remove newline characters in query status.

2018-10-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 ) Change subject: IMPALA-2063 Remove newline characters in query status. .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2063 Remove newline characters in query status.

2018-10-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 ) Change subject: IMPALA-2063 Remove newline characters in query status. .. Patch Set 10: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11615 Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. IMPALA-4063: Merge report of query fragment

[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"

2018-10-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: Code-Review+2 --

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 11: (8 comments)

[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"

2018-10-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: Is this a clean

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-12 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. IMPALA-7213, IMPALA-7241: Port ReportExecStatus()

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 16: (3 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-15 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Tim Armstrong, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11615 to look at the new patch set (#5). Change subject: IMPALA-4063: Merge report of query fragment instances per

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-17 Thread Michael Ho (Code Review)
Michael Ho has removed Michael Ho from this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Removed reviewer Michael Ho. -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code"

2018-10-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11699 ) Change subject: Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code" .. Patch Set 2: Lars, what's the status of this

[Impala-ASF-CR] IMPALA-7272: Fix crash in StringMinMaxFilter

2018-10-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11650 ) Change subject: IMPALA-7272: Fix crash in StringMinMaxFilter .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: (3 comments) Hey sorry for not getting back

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-19 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Todd Lipcon, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, Michal Ostrowski, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#19). Change subject: IMPALA-7213, IMPALA-7241: Port

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 19: Code-Review+1 Carry +1 -- To view,

[Impala-ASF-CR] IMPALA-7272: Fix crash in StringMinMaxFilter

2018-10-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11650 ) Change subject: IMPALA-7272: Fix crash in StringMinMaxFilter .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7272: Fix crash in StringMinMaxFilter

2018-10-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11650 ) Change subject: IMPALA-7272: Fix crash in StringMinMaxFilter .. Patch Set 3: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 18: (8 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 18: Code-Review+1 Carry +1 -- To view,

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-13 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Tim Armstrong, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11615 to look at the new patch set (#4). Change subject: IMPALA-4063: Merge report of query fragment instances per

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-13 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Todd Lipcon, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, Michal Ostrowski, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#18). Change subject: IMPALA-7213, IMPALA-7241: Port

[Impala-ASF-CR](asf-site) Download 3.0.1

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11766 ) Change subject: Download 3.0.1 .. Patch Set 1: Code-Review+2 Thanks for doing it. -- To view, visit

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 6: Code-Review+1 Carry +1 -- To view,

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-24 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Todd Lipcon, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, Michal Ostrowski, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#20). Change subject: IMPALA-7213, IMPALA-7241: Port

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-24 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Tim Armstrong, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11615 to look at the new patch set (#6). Change subject: IMPALA-4063: Merge report of query fragment instances per

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 20: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 4: OK. Will do a pass tonight. -- To view, visit

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-11-01 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Tim Armstrong, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11615 to look at the new patch set (#7). Change subject: IMPALA-4063: Merge report of query fragment instances per

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-11-01 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Todd Lipcon, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, Michal Ostrowski, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#21). Change subject: IMPALA-7213, IMPALA-7241: Port

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 7: Code-Review+2 Carry +2 -- To view,

<    1   2   3   4   5   6   7   8   9   10   >