[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-28 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#8). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-03-28 Thread Zoltan Borok-Nagy (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9090 to look at the new patch set (#5). Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-03-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-29 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#19). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-29 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#9). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 5: (16 comments) Thanks Csaba! (and I also updated my

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#5). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#17). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9693 Change subject: IMPALA-5842: Write page index in Parquet files .. IMPALA-5842: Write page index in Parquet files This commit builds

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#2). Change subject: IMPALA-5842: Write page index in Parquet files ..

[Impala-ASF-CR] IMPALA-6415: [DOCS] fix invalid

2018-03-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9731 ) Change subject: IMPALA-6415: [DOCS] fix invalid .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6415: [DOCS] fix invalid

2018-03-21 Thread Zoltan Borok-Nagy (Code Review)
Hello Alex Rodoni, Michael Brown, John Russell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9731 to look at the new patch set (#2). Change subject: IMPALA-6415: [DOCS] fix invalid ..

[Impala-ASF-CR] IMPALA-6415: [DOCS] fix invalid

2018-03-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9731 Change subject: IMPALA-6415: [DOCS] fix invalid .. IMPALA-6415: [DOCS] fix invalid The current conref returned an error and the

[Impala-ASF-CR] IMPALA-6415: [DOCS] fix invalid

2018-03-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9731 ) Change subject: IMPALA-6415: [DOCS] fix invalid .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 15: (7 comments) Thanks

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-21 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#16). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-21 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#15). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-21 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#14). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-23 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#4). Change subject: IMPALA-5842: Write page index in Parquet files ..

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (20 comments)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#3). Change subject: IMPALA-5842: Write page index in Parquet files ..

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (12 comments) Thanks for the comments! I fixed

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Gabor Kaszab, Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9381 to look at the new patch set (#5). Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 5: (2 comments) Thanks for

[Impala-ASF-CR] IMPALA-6934: Wrong results with EXISTS subquery containing ORDER BY, LIMIT, and OFFSET

2018-04-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10218 Change subject: IMPALA-6934: Wrong results with EXISTS subquery containing ORDER BY, LIMIT, and OFFSET .. IMPALA-6934: Wrong

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-06-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 6: Code-Review+1 (5 comments) Looks good, only had some

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-09-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11520 to look at the new patch set (#2). Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-09-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11520 to look at the new patch set (#3). Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 15: Code-Review+1 Just skimmed through what have

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-05 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11520 to look at the new patch set (#4). Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 4: (4 comments) Thanks for the comments.

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 7: Code-Review+2 Needed to adjust

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11563 to look at the new patch set (#7). Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11694 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. IMPALA-7644: Hide Parquet page index writing with

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11694 Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. IMPALA-7644: Hide Parquet page index writing with

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11694 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11694 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 2: PS1 produces the ASAN error. It is

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11694 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 2: (3 comments) Thanks for the

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11694 to look at the new patch set (#3). Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11694 to look at the new patch set (#4). Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11694 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-10-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 15: (2

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11694 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-10-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11520 to look at the new patch set (#7). Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges

[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-11-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 18: (2

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 14: (4 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: Code-Review+1 (1 comment) I read it through again and

[Impala-ASF-CR] IMPALA-7477: Batch-oriented query set construction

2018-11-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11879 ) Change subject: IMPALA-7477: Batch-oriented query set construction .. Patch Set 1: Code-Review+2 Thanks for the comment that

[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-11-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 20:

[Impala-ASF-CR] IMPALA-7806: [DOCS] Updated Known Issues in 3.1

2018-11-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11921 ) Change subject: IMPALA-7806: [DOCS] Updated Known Issues in 3.1 .. Patch Set 1: Code-Review+1 I've checked all the Jiras

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 14: (2 comments) I'm planning to do another passes in the

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-05 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11563 to look at the new patch set (#5). Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11563 to look at the new patch set (#2). Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 2: (5 comments) Thanks for the

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11563 Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. IMPALA-7644: Hide Parquet page index writing with

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 3: (1 comment) Thanks Tim! I just don't know

[Impala-ASF-CR] IMPALA-7595: Check the validity of the time part of Parquet timestamps

2018-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11521 ) Change subject: IMPALA-7595: Check the validity of the time part of Parquet timestamps .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-7492: Add support for DATE text parser/formatter

2018-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11450 ) Change subject: IMPALA-7492: Add support for DATE text parser/formatter .. Patch Set 5: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11520 to look at the new patch set (#5). Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11520 to look at the new patch set (#6). Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11563 to look at the new patch set (#3). Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11563 to look at the new patch set (#4). Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11444 to look at the new patch set (#3). Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11444 ) Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism .. Patch Set 3: (21 comments)

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-21 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11444 to look at the new patch set (#8). Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11444 ) Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11520 Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. IMPALA-7543: Enhance scan ranges to support sub-ranges

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11444 to look at the new patch set (#4). Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11444 to look at the new patch set (#5). Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11444 ) Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism .. Patch Set 4: (12 comments)

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11444 to look at the new patch set (#7). Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11444 ) Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism .. Patch Set 7: (8 comments)

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11444 to look at the new patch set (#6). Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism

[Impala-ASF-CR] IMPALA-7556: part 1: handle different file systems via polymorphism

2018-09-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11444 ) Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 16: Code-Review+2 LGTM! Thank you Quanlong for

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7595: Check the validity of the time part of Parquet timestamps

2018-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11521 ) Change subject: IMPALA-7595: Check the validity of the time part of Parquet timestamps .. Patch Set 4: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12172 to look at the new patch set (#4). Change subject: IMPALA-7979: Enhance decoders to support value-skipping

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-6664: Tag log statements with fragment or query ids.

2019-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 ) Change subject: IMPALA-6664: Tag log statements with fragment or query ids. .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12172 to look at the new patch set (#3). Change subject: IMPALA-7979: Enhance decoders to support value-skipping

[Impala-ASF-CR] IMPALA-6664: Tag log statements with fragment or query ids.

2019-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 ) Change subject: IMPALA-6664: Tag log statements with fragment or query ids. .. Patch Set 6: Code-Review+2 Thanks for applying the

[Impala-ASF-CR] IMPALA-8090: race when reusing ScanRange in test

2019-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12238 ) Change subject: IMPALA-8090: race when reusing ScanRange in test .. Patch Set 2: (2 comments) When I have some time I'll come

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-21 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12172 to look at the new patch set (#5). Change subject: IMPALA-7979: Enhance decoders to support value-skipping

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-01-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 3: (7 comments)

[Impala-ASF-CR] Update version to 3.2.0-SNAPSHOT

2018-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12053 ) Change subject: Update version to 3.2.0-SNAPSHOT .. Update version to 3.2.0-SNAPSHOT Change-Id:

[Impala-ASF-CR] Update version to 3.2.0-SNAPSHOT

2018-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12053 ) Change subject: Update version to 3.2.0-SNAPSHOT .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 4: (1 comment) I like the direction where this

[Impala-ASF-CR] WIP: IMPALA-5843: Use page index in Parquet files to skip pages

2018-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12065 Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages .. WIP: IMPALA-5843: Use page index in Parquet

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 5: (1 comment) Thanks for adding the flag, lgtm.

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 5: Code-Review+1 -- To view, visit

<    1   2   3   4   5   6   7   8   9   10   >