[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Patch Set 3: Code-Review+2 LGTM.

[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations

2019-09-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14290 Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. IMPALA-8969:

[Impala-ASF-CR] ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8742: Switch to ScanRange::bytes to read() instead of len()

2019-10-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14348 Change subject: IMPALA-8742: Switch to ScanRange::bytes_to_read() instead of len() .. IMPALA-8742: Switch to

[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables

2019-09-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-09-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-09-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has removed a vote on this change. Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Removed Code-Review+2 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-9045: Filter base directories of open/aborted compactions

2019-11-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14547 to look at the new patch set (#4). Change subject: IMPALA-9045: Filter base directories of open/aborted compactions

[Impala-ASF-CR] IMPALA-9045: Filter base directories of open/aborted compactions

2019-11-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14547 to look at the new patch set (#5). Change subject: IMPALA-9045: Filter base directories of open/aborted compactions

[Impala-ASF-CR] IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table

2019-11-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14588 ) Change subject: IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-9045: Filter base directories of open/aborted compactions

2019-11-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14547 ) Change subject: IMPALA-9045: Filter base directories of open/aborted compactions .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9045: Filter base directories of open/aborted compactions

2019-11-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14547 to look at the new patch set (#3). Change subject: IMPALA-9045: Filter base directories of open/aborted compactions

[Impala-ASF-CR] IMPALA-9045: Filter base directories of open/aborted compactions

2019-11-05 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14547 to look at the new patch set (#2). Change subject: IMPALA-9045: Filter base directories of open/aborted compactions

[Impala-ASF-CR] IMPALA-9045: Filter base directories of open/aborted compactions

2019-11-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14547 ) Change subject: IMPALA-9045: Filter base directories of open/aborted compactions .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-11-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-11-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Norbert Luksa, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1 to look at the new patch set (#5). Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

[Impala-ASF-CR] [WIP]IMPALA-8778: Support Apache Hudi Read Optimized Table

2019-11-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: [WIP]IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 3: (1 comment) Thanks for working on

[Impala-ASF-CR] WIP: IMPALA-8046: Support CREATE TABLE from an ORC file

2019-12-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14811 ) Change subject: WIP: IMPALA-8046: Support CREATE TABLE from an ORC file .. Patch Set 7: (11 comments) Found a few nits, other

[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key

2019-12-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14830 Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key .. IMPALA-9215: report_benchmark_results.py fails

[Impala-ASF-CR] IMPALA-9207: [DOCS] Documented the #Inst in exec summary

2019-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14860 ) Change subject: IMPALA-9207: [DOCS] Documented the #Inst in exec summary .. Patch Set 2: LGTM once Norbert's comments are

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14804 ) Change subject: IMPALA-9174: Speedup allocations of ORC Scanner .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-12-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14804 to look at the new patch set (#4). Change subject: IMPALA-9174: Speedup allocations of ORC Scanner

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14804 to look at the new patch set (#5). Change subject: IMPALA-9174: Speedup allocations of ORC Scanner

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14804 ) Change subject: IMPALA-9174: Speedup allocations of ORC Scanner .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-8184: Add timestamp validation to ORC scanner

2019-12-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14832 ) Change subject: IMPALA-8184: Add timestamp validation to ORC scanner .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14854 ) Change subject: Update mvn snapshot dependencies in "clean" checkouts .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-12-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14804 to look at the new patch set (#3). Change subject: IMPALA-9174: Speedup allocations of ORC Scanner

[Impala-ASF-CR] IMPALA-9071: Fix wrong table path of transaction table created by CTAS

2019-10-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14546 ) Change subject: IMPALA-9071: Fix wrong table path of transaction table created by CTAS .. Patch Set 1: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-9055: Impala shouldn't set expiration to NEVER for cache directives.

2019-10-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14485 ) Change subject: IMPALA-9055: Impala shouldn't set expiration to NEVER for cache directives. .. IMPALA-9055: Impala

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2019-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-6501: Optimize count(star) for Kudu scans

2019-10-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14347 ) Change subject: IMPALA-6501: Optimize count(star) for Kudu scans .. Patch Set 8: Code-Review+1 Lgtm once Csaba's comments are

[Impala-ASF-CR] WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-10-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/1 Change subject: WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs .. WIP: IMPALA-8648: Add stress tests for ACID

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-10-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-10-24 Thread Zoltan Borok-Nagy (Code Review)
Hello Norbert Luksa, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1 to look at the new patch set (#4). Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-10-24 Thread Zoltan Borok-Nagy (Code Review)
Hello Norbert Luksa, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1 to look at the new patch set (#3). Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

[Impala-ASF-CR] WIP IMPALA-9045: Filter base directories of open/aborted compactions

2019-10-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14547 ) Change subject: WIP IMPALA-9045: Filter base directories of open/aborted compactions .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6663 Expose current DDL metrics on WebUI

2019-10-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13806 ) Change subject: IMPALA-6663 Expose current DDL metrics on WebUI .. Patch Set 7: (6 comments) Found a couple of nits, other than

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-10-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1 to look at the new patch set (#2). Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

[Impala-ASF-CR] IMPALA-9055: Impala shouldn't set expiration to NEVER for cache directives.

2019-10-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14485 Change subject: IMPALA-9055: Impala shouldn't set expiration to NEVER for cache directives. .. IMPALA-9055: Impala shouldn't set

[Impala-ASF-CR] IMPALA-9071: Fix wrong table path of transaction table created by CTAS

2019-10-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14546 ) Change subject: IMPALA-9071: Fix wrong table path of transaction table created by CTAS .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] WIP IMPALA-9045: Filter base directories of open/aborted compactions

2019-10-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14547 Change subject: WIP IMPALA-9045: Filter base directories of open/aborted compactions .. WIP IMPALA-9045: Filter base directories

[Impala-ASF-CR] IMPALA-9167: stress/test acid stress.py gets TimeoutError on s3

2019-11-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14754 Change subject: IMPALA-9167: stress/test_acid_stress.py gets TimeoutError on s3 .. IMPALA-9167: stress/test_acid_stress.py gets

[Impala-ASF-CR] [WIP]IMPALA-8778: Support Apache Hudi Read Optimized Table

2019-11-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: [WIP]IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 3: Thanks, Yanija. I think that makes

[Impala-ASF-CR] IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table

2019-11-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14588 ) Change subject: IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table

2019-11-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14588 ) Change subject: IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table .. Patch Set 8: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table

2019-11-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14588 ) Change subject: IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table .. Patch Set 9: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-11-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14804 Change subject: IMPALA-9174: Speedup allocations of ORC Scanner .. IMPALA-9174: Speedup allocations of ORC Scanner The ORC library

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-11-28 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14804 to look at the new patch set (#2). Change subject: IMPALA-9174: Speedup allocations of ORC Scanner

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-11-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14804 ) Change subject: IMPALA-9174: Speedup allocations of ORC Scanner .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-11-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14804 ) Change subject: IMPALA-9174: Speedup allocations of ORC Scanner .. Patch Set 1: (4 comments) Fixed the alignment issue. There

[Impala-ASF-CR] IMPALA-8709: Add Damerau-Levenshtein edit distance built-in function

2019-11-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13794 ) Change subject: IMPALA-8709: Add Damerau-Levenshtein edit distance built-in function .. Patch Set 8: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8755: Frontend support for Z-ordering

2019-09-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13955 ) Change subject: IMPALA-8755: Frontend support for Z-ordering .. Patch Set 14: (1 comment) Found a nit and

[Impala-ASF-CR] IMPALA-6501: Optimize count(star) for Kudu scans

2019-10-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14347 ) Change subject: IMPALA-6501: Optimize count(star) for Kudu scans .. Patch Set 6: (10 comments)

[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-10-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Patch Set 5: Code-Review+1 (3

[Impala-ASF-CR] IMPALA-8742: Switch to ScanRange::bytes to read() instead of len()

2019-10-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14348 to look at the new patch set (#3). Change subject: IMPALA-8742: Switch to ScanRange::bytes_to_read() instead of len()

[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-10-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Patch Set 9: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-8742: Switch to ScanRange::bytes to read() instead of len()

2019-10-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14348 ) Change subject: IMPALA-8742: Switch to ScanRange::bytes_to_read() instead of len() .. Patch Set 3: In PS3 I removed the check

[Impala-ASF-CR] IMPALA-8184: Add timestamp validation to Orc scanner

2019-12-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14832 ) Change subject: IMPALA-8184: Add timestamp validation to Orc scanner .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. Patch Set 8: (1 comment)

[Impala-ASF-CR] [WIP] IMPALA-6772: Enable test scanners fuzz for ORC

2020-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15062 ) Change subject: [WIP] IMPALA-6772: Enable test_scanners_fuzz for ORC .. Patch Set 3: (2 comments) Thanks for applying the

[native-toolchain-CR] IMPALA-6772: Add ORC 1.6.2 to toolchain

2020-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15073 ) Change subject: IMPALA-6772: Add ORC 1.6.2 to toolchain .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] [WIP] IMPALA-6772: Enable test scanners fuzz for ORC

2020-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15062 ) Change subject: [WIP] IMPALA-6772: Enable test_scanners_fuzz for ORC .. Patch Set 4: Code-Review+1 Nice job, thanks for working

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 19: (5 comments)

[Impala-ASF-CR] IMPALA-8778: Support Apache Hudi Read Optimized Table

2020-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 16: (5 comments) Thanks for applying the

[Impala-ASF-CR] IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object

2020-03-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15281 ) Change subject: IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object .. Patch Set 5:

[Impala-ASF-CR] IMPALA-6506: Codegen in ORC scanner for primitives and struct

2020-03-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15350 ) Change subject: IMPALA-6506: Codegen in ORC scanner for primitives and struct .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9228: ORC scanner reads rows into scratch batch

2020-03-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 ) Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch .. Patch Set 7: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9228: ORC scanner reads rows into scratch batch

2020-03-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 ) Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch .. Patch Set 5: Code-Review+1 (3 comments) Only found

[Impala-ASF-CR] IMPALA-6506: Codegen in ORC scanner for primitives and struct

2020-03-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15350 ) Change subject: IMPALA-6506: Codegen in ORC scanner for primitives and struct .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6506: Codegen in ORC scanner for primitives and struct

2020-03-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15350 ) Change subject: IMPALA-6506: Codegen in ORC scanner for primitives and struct .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6663: Expose current DDL metrics on WebUI

2020-03-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13806 ) Change subject: IMPALA-6663: Expose current DDL metrics on WebUI .. Patch Set 16: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-02-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 29: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-02-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6663: Expose current DDL metrics on WebUI

2020-02-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13806 ) Change subject: IMPALA-6663: Expose current DDL metrics on WebUI .. Patch Set 14: Code-Review+2 Thanks for applying the changes!

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. Patch Set 16: (3 comments) The code LGTM, only found a few nits.

[Impala-ASF-CR] IMPALA-9228: ORC scanner reads rows into scratch batch

2020-02-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 ) Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash

2020-03-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15347 ) Change subject: IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9228: ORC scanner reads rows into scratch batch

2020-03-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 ) Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4224: execute separate join builds fragments

2020-02-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14859 ) Change subject: IMPALA-4224: execute separate join builds fragments .. Patch Set 35: (6 comments) I focused on the backend. It

[Impala-ASF-CR] IMPALA-8778: Support Apache Hudi Read Optimized Table

2020-02-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 21: Code-Review+1 (5 comments) Found some

[Impala-ASF-CR] IMPALA-6772: Enable test scanners fuzz for ORC

2020-01-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15062 ) Change subject: IMPALA-6772: Enable test_scanners_fuzz for ORC .. Patch Set 7: Code-Review+2 Nice job! It's good that you moved

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 21: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4224: execute separate join builds fragments

2020-01-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14859 ) Change subject: IMPALA-4224: execute separate join builds fragments .. Patch Set 32: (11 comments) Did a first pass, found some

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-02-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8778: Support Apache Hudi Read Optimized Table

2020-02-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 16: (8 comments)

[Impala-ASF-CR] IMPALA-9174: Emit WARNING when ORC lib leaks memory

2020-02-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15153 Change subject: IMPALA-9174: Emit WARNING when ORC lib leaks memory .. IMPALA-9174: Emit WARNING when ORC lib leaks memory Added a

[Impala-ASF-CR] IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types

2020-02-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15152 ) Change subject: IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types .. Patch Set 2: (6

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-02-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 22: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2020-02-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has abandoned this change. ( http://gerrit.cloudera.org:8080/14804 ) Change subject: IMPALA-9174: Speedup allocations of ORC Scanner .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/14804 To

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2020-02-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14804 ) Change subject: IMPALA-9174: Speedup allocations of ORC Scanner .. Patch Set 7: Based on my newest measurements it doesn't cause

[Impala-ASF-CR] IMPALA-8778: Support Apache Hudi Read Optimized Table

2020-02-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 22: Code-Review+2 LGTM! Thanks for your great

[Impala-ASF-CR] IMPALA-8778: Support Apache Hudi Read Optimized Table

2020-02-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 22: (3 comments) The verify job failed. The

[Impala-ASF-CR] IMPALA-8778: Support Apache Hudi Read Optimized Table

2020-02-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-9324: Correctly handle ORC UNION type in scanner

2020-01-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15103 ) Change subject: IMPALA-9324: Correctly handle ORC UNION type in scanner .. Patch Set 5: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 20: Code-Review+1 (5 comments) Found some nits, but I

[Impala-ASF-CR] IMPALA-9324: Correctly handle ORC UNION type in scanner

2020-01-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15103 ) Change subject: IMPALA-9324: Correctly handle ORC UNION type in scanner .. Patch Set 6: Code-Review+2 Thanks for the additional

[Impala-ASF-CR] IMPALA-4224: execute separate join builds fragments

2020-02-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14859 ) Change subject: IMPALA-4224: execute separate join builds fragments .. Patch Set 35: (6 comments)

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 20: (1 comment)

<    3   4   5   6   7   8   9   10   11   12   >