[Impala-ASF-CR] [WIP] IMPALA-7555: Set socket timeout in impala-shell

2018-10-01 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 ) Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell .. Patch Set 3: (18 comments)

[Impala-ASF-CR] [WIP] IMPALA-7555: Set socket timeout in impala-shell

2018-10-01 Thread anujphadke (Code Review)
Hello Thomas Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11540 to look at the new patch set (#3). Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell

[Impala-ASF-CR] [WIP] IMPALA-7555: Set socket timeout in impala-shell

2018-10-01 Thread anujphadke (Code Review)
Hello Thomas Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11540 to look at the new patch set (#2). Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell

[Impala-ASF-CR] [WIP] IMPALA-7555: Impala-shell should timeout if it fails to connect

2018-09-28 Thread anujphadke (Code Review)
anujphadke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11540 Change subject: [WIP] IMPALA-7555: Impala-shell should timeout if it fails to connect .. [WIP] IMPALA-7555: Impala-shell should timeout

[Impala-ASF-CR] IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue

2018-08-06 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11020 ) Change subject: IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue

2018-08-06 Thread anujphadke (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11020 to look at the new patch set (#2). Change subject: IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-07-24 Thread anujphadke (Code Review)
anujphadke has abandoned this change. ( http://gerrit.cloudera.org:8080/9619 ) Change subject: IMPALA-5695: restart_first_impalad() does not start impalad .. Abandoned This is not the right fix. Will send a new patch. The

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Tim Armstrong, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#21). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-28 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-28 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Tim Armstrong, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#20). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-28 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Tim Armstrong, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#19). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-22 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 16: (3 comments)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-22 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#16). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-19 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: (1 comment) After rebasing I am seeing a few test failures

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-19 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7179: allow multiple scratch dirs per device=true by default

2018-06-15 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10736 ) Change subject: IMPALA-7179: allow_multiple_scratch_dirs_per_device=true by default .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-25 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-08 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-08 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#15). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-04-02 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#13). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-03-27 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 12: (5 comments)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-03-27 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#12). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-15 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9619 ) Change subject: IMPALA-5695: restart_first_impalad() does not start impalad .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-14 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9619 ) Change subject: IMPALA-5695: restart_first_impalad() does not start impalad .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-13 Thread anujphadke (Code Review)
anujphadke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9619 Change subject: IMPALA-5695: restart_first_impalad() does not start impalad .. IMPALA-5695: restart_first_impalad() does not start impalad

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-02 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-02 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. Patch Set 1: impalad crashes with this patch

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-02 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-21 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 ) Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-21 Thread anujphadke (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9154 to look at the new patch set (#6). Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-02-21 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 11: (16 comments)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-02-21 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#11). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-21 Thread anujphadke (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9154 to look at the new patch set (#5). Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-21 Thread anujphadke (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9154 to look at the new patch set (#4). Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: Code-Review+1 Thanks for fixing

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-09 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 ) Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-09 Thread anujphadke (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9154 to look at the new patch set (#3). Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-01 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-01-30 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()

2018-01-29 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-01-29 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9154 ) Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. IMPALA-6008: Creating a UDF from a

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-01-29 Thread anujphadke (Code Review)
anujphadke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9154 Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. IMPALA-6008: Creating a UDF from a

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-25 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9102 to look at the new patch set (#4). Change subject: IMPALA-6435: Disable codegen for CHAR literals.

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9102 to look at the new patch set (#3). Change subject: IMPALA-6435: Disable codegen for CHAR literals. ..

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9102 to look at the new patch set (#2). Change subject: IMPALA-6435: Disable codegen for CHAR literals. ..

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
anujphadke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9102 Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. IMPALA-6435: Disable codegen for CHAR literals. Currently we do not

[Impala-ASF-CR] IMPALA-6422: Use ldexp() instead of powf() in HLL.

2018-01-19 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9078 ) Change subject: IMPALA-6422: Use ldexp() instead of powf() in HLL. .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-01-16 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 10: (19 comments)

[Impala-ASF-CR] IMPALA-5052: Read and write signed integer logical types in Parquet

2018-01-08 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8548 ) Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-5052: Read and write signed integer logical types in Parquet

2018-01-08 Thread anujphadke (Code Review)
Hello Tianyi Wang, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8548 to look at the new patch set (#3). Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-01-05 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 2: Can we test all the cases fixed

[Impala-ASF-CR] IMPALA-5052: Read and write signed integer logical types in Parquet

2018-01-04 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8548 ) Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-5052: Read and write signed integer logical types in Parquet

2018-01-04 Thread anujphadke (Code Review)
Hello Tianyi Wang, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8548 to look at the new patch set (#2). Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-11-15 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 7: (4 comments)