[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d Gerrit-Change-Number: 10759 Gerrit-PatchSet: 12 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Thu, 12 Jul 2018 21:35:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. IMPALA-7006: [KSECURITY] Update security library integration This commit is part of a set of changes for IMPALA-7006. It started based on an original change (f51c4435), which integrated Kudu's security folder into our build. This change removes several compile time checks that are now either done in Kudu's own cmake files or that can be removed due to Impala deprecating support for older OS versions in the 3.x line. The removed checks are: HAVE_KRB5_GET_INIT_CREDS_OPT_SET_OUT_CCACHE: We now check for this in Kudu's code. HAVE_KRB5_IS_CONFIG_PRINCIPAL, HAVE_KRB5_GET_INIT_CREDS_OPT_SET_FAST_CCACHE_NAME: These checks are not needed anymore. All OS versions supported by Impala now have sufficiently recent versions of Kerberos. Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d Reviewed-on: http://gerrit.cloudera.org:8080/10759 Reviewed-by: Lars Volker Tested-by: Lars Volker --- M be/CMakeLists.txt M be/src/common/config.h.in 2 files changed, 0 insertions(+), 9 deletions(-) Approvals: Lars Volker: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d Gerrit-Change-Number: 10759 Gerrit-PatchSet: 13 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 12: Code-Review+2 Rebased, carrying Michael's +2. -- To view, visit http://gerrit.cloudera.org:8080/10759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d Gerrit-Change-Number: 10759 Gerrit-PatchSet: 12 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Thu, 12 Jul 2018 17:23:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 10: Code-Review+2 Rebased, carrying Michael's +2. -- To view, visit http://gerrit.cloudera.org:8080/10759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d Gerrit-Change-Number: 10759 Gerrit-PatchSet: 10 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Wed, 11 Jul 2018 22:04:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d Gerrit-Change-Number: 10759 Gerrit-PatchSet: 9 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Wed, 11 Jul 2018 01:58:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/10759/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10759/8//COMMIT_MSG@13 PS8, Line 13: The original commit message is below: > I see. This patch along with the other 2 patches for rpc and util directori I updated the commit message. -- To view, visit http://gerrit.cloudera.org:8080/10759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d Gerrit-Change-Number: 10759 Gerrit-PatchSet: 8 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Tue, 10 Jul 2018 20:24:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10905 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/10905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I9579eeb8b6a604bf91e81d080f5b245878b45afc Gerrit-Change-Number: 10905 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker
[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration
Hello Michael Ho, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10759 to look at the new patch set (#9). Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. IMPALA-7006: [KSECURITY] Update security library integration This commit is part of a set of changes for IMPALA-7006. It started based on an original change (f51c4435), which integrated Kudu's security folder into our build. This change removes several compile time checks that are now either done in Kudu's own cmake files or that can be removed due to Impala deprecating support for older OS versions in the 3.x line. The removed checks are: HAVE_KRB5_GET_INIT_CREDS_OPT_SET_OUT_CCACHE: We now check for this in Kudu's code. HAVE_KRB5_IS_CONFIG_PRINCIPAL, HAVE_KRB5_GET_INIT_CREDS_OPT_SET_FAST_CCACHE_NAME: These checks are not needed anymore. All OS versions supported by Impala now have sufficiently recent versions of Kerberos. Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d --- M be/CMakeLists.txt M be/src/common/config.h.in 2 files changed, 0 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/10759/9 -- To view, visit http://gerrit.cloudera.org:8080/10759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d Gerrit-Change-Number: 10759 Gerrit-PatchSet: 9 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10905 Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. IMPALA-7006: [KSECURITY] Update security library integration This commit is part of a set of changes for IMPALA-7006. It started based on an original change (f51c4435), which integrated Kudu's security folder into our build. This change removes several compile time checks that are now either done in Kudu's own cmake files or that can be removed due to Impala deprecating support for older OS versions in the 3.x line. The removed checks are: HAVE_KRB5_GET_INIT_CREDS_OPT_SET_OUT_CCACHE: We now check for this in Kudu's code. HAVE_KRB5_IS_CONFIG_PRINCIPAL, HAVE_KRB5_GET_INIT_CREDS_OPT_SET_FAST_CCACHE_NAME: These checks are not needed anymore. All OS versions supported by Impala now have sufficiently recent versions of Kerberos. Change-Id: I9579eeb8b6a604bf91e81d080f5b245878b45afc --- M be/CMakeLists.txt M be/src/common/config.h.in 2 files changed, 0 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/10905/1 -- To view, visit http://gerrit.cloudera.org:8080/10905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9579eeb8b6a604bf91e81d080f5b245878b45afc Gerrit-Change-Number: 10905 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker
