[Impala-ASF-CR] IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12878 ) Change subject: IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2577/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I430b2e67e97dc0fc99f655fcfd7db2072b13 Gerrit-Change-Number: 12878 Gerrit-PatchSet: 2 Gerrit-Owner: Austin Nobis Gerrit-Reviewer: Austin Nobis Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 28 Mar 2019 19:01:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12878 ) Change subject: IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2575/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I430b2e67e97dc0fc99f655fcfd7db2072b13 Gerrit-Change-Number: 12878 Gerrit-PatchSet: 1 Gerrit-Owner: Austin Nobis Gerrit-Reviewer: Austin Nobis Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 28 Mar 2019 18:56:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12878 ) Change subject: IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12878/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12878/2//COMMIT_MSG@7 PS2, Line 7: create database or create table nit: can be shorten to create database/table http://gerrit.cloudera.org:8080/#/c/12878/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/12878/2/tests/authorization/test_ranger.py@52 PS2, Line 52: "admin" can we make this a variable similar to L42? http://gerrit.cloudera.org:8080/#/c/12878/2/tests/authorization/test_ranger.py@65 PS2, Line 65: getuser() we can use user variable declared in 42 instead. http://gerrit.cloudera.org:8080/#/c/12878/2/tests/authorization/test_ranger.py@73 PS2, Line 73: getuser() same as above -- To view, visit http://gerrit.cloudera.org:8080/12878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I430b2e67e97dc0fc99f655fcfd7db2072b13 Gerrit-Change-Number: 12878 Gerrit-PatchSet: 2 Gerrit-Owner: Austin Nobis Gerrit-Reviewer: Austin Nobis Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 28 Mar 2019 18:30:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled
Austin Nobis has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12878 ) Change subject: IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled .. IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled Previously, an exception would be thrown when a create database or create table command was run and Ranger was enabled. This patch removes the code that would throw the invalid exception from RangerCatalogdAuthorizationManager. Testing: - The python E2E test was updated to create and drop a database to cover the missing test case. - All E2E tests were run - All FE tests were run Change-Id: I430b2e67e97dc0fc99f655fcfd7db2072b13 --- M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java M tests/authorization/test_ranger.py 2 files changed, 23 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/12878/2 -- To view, visit http://gerrit.cloudera.org:8080/12878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I430b2e67e97dc0fc99f655fcfd7db2072b13 Gerrit-Change-Number: 12878 Gerrit-PatchSet: 2 Gerrit-Owner: Austin Nobis Gerrit-Reviewer: Austin Nobis Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
