[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 01 Aug 2019 04:50:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 2: Verified+1 Most of the parallel jobs succeeded and the straggler has many enough process. I'm going to verify optimistically so we can unblock other changes. I also tested on centos7 and it is working fine there too. -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 01 Aug 2019 01:45:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. IMPALA-8820: fix start-impala-cluster catalogd startup The catalogd process sometimes changes its name to "main" after an ubuntu 16.04 update. This avoids the issue by checking the first element of the command line instead, which should reflect the binary that was executed more reliably. Testing: This failed consistently before the change and now passes consistently on my development machine. Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Reviewed-on: http://gerrit.cloudera.org:8080/13971 Reviewed-by: Joe McDonnell Tested-by: Tim Armstrong --- M bin/start-impala-cluster.py M tests/common/impala_cluster.py 2 files changed, 17 insertions(+), 8 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Tim Armstrong: Verified -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4708/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 31 Jul 2019 22:14:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 2: Code-Review+2 This makes sense to me -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 31 Jul 2019 21:56:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4110/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 31 Jul 2019 21:15:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13971/1/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/13971/1/tests/common/impala_cluster.py@543 PS1, Line 543: u > flake8: E501 line too long (93 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 31 Jul 2019 20:37:00 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13971 to look at the new patch set (#2). Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. IMPALA-8820: fix start-impala-cluster catalogd startup The catalogd process sometimes changes its name to "main" after an ubuntu 16.04 update. This avoids the issue by checking the first element of the command line instead, which should reflect the binary that was executed more reliably. Testing: This failed consistently before the change and now passes consistently on my development machine. Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb --- M bin/start-impala-cluster.py M tests/common/impala_cluster.py 2 files changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/13971/2 -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4705/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 31 Jul 2019 20:36:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/4109/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 31 Jul 2019 20:36:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4704/ -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 31 Jul 2019 20:36:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13971/1/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/13971/1/tests/common/impala_cluster.py@543 PS1, Line 543: u flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Jul 2019 20:35:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 1: I'm going to rely on the precommit to flush out any additional issues with this. The testing I did locally gave me a reasonable degree of confidence that it should work. -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 31 Jul 2019 20:35:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4704/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Jul 2019 20:35:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13971 Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. IMPALA-8820: fix start-impala-cluster catalogd startup The catalogd process sometimes changes its name to "main" after an ubuntu 16.04 update. This avoids the issue by checking the first element of the command line instead, which should reflect the binary that was executed more reliably. Testing: This failed consistently before the change and now passes consistently on my development machine. Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb --- M bin/start-impala-cluster.py M tests/common/impala_cluster.py 2 files changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/13971/1 -- To view, visit http://gerrit.cloudera.org:8080/13971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9396669481e4194beb6247c8d8b6064cb5119bb Gerrit-Change-Number: 13971 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
