[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. IMPALA-9751: increase query log size to 100 This is both a flaky test fix and a change to the default. I believe the test was flaky because queries had been aged out of the log before the exec summary was fetched. We have also found in production that queries often age out of the log quickly, so the default size can be too small. IMPALA-9381 reduces the size of the query log entries, so hopefully means that the total query log size won't be significantly larger. Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Reviewed-on: http://gerrit.cloudera.org:8080/15972 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/service/impala-server.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 22 May 2020 10:35:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 22 May 2020 05:19:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5886/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 22 May 2020 05:19:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 2: Hit https://issues.apache.org/jira/browse/IMPALA-9057?jql=text%20~%20%22test_transactional_insert_events%22 -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 22 May 2020 05:19:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5884/ -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 22 May 2020 00:46:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5884/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 21 May 2020 19:31:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 21 May 2020 19:31:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 21 May 2020 18:46:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6125/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 21 May 2020 17:44:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 1: To be transparent, I wasn't able to reproduce the failure locally yet, but I looked at the code and logs and this was the only theory that made sense ot me. -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 21 May 2020 17:37:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15972 ) Change subject: IMPALA-9751: increase query log size to 100 .. Patch Set 1: Code-Review+1 Thanks for working on it! -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 21 May 2020 17:10:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9751: increase query log size to 100
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15972 Change subject: IMPALA-9751: increase query log size to 100 .. IMPALA-9751: increase query log size to 100 This is both a flaky test fix and a change to the default. I believe the test was flaky because queries had been aged out of the log before the exec summary was fetched. We have also found in production that queries often age out of the log quickly, so the default size can be too small. IMPALA-9381 reduces the size of the query log entries, so hopefully means that the total query log size won't be significantly larger. Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 --- M be/src/service/impala-server.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/15972/1 -- To view, visit http://gerrit.cloudera.org:8080/15972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I70a1f8195574287f5df048c13f4a79acd88a81b3 Gerrit-Change-Number: 15972 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
