[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi WangGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Sun, 04 Feb 2018 02:00:24 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This patch reserves SQL:2016 reserved words, excluding: 1. Impala builtin function names. 2. Time unit words(year, month, etc.). 3. An exception list based on a discussion. Some test cases are modified to avoid these words. A impalad and catalogd startup option reserved_words_version is added. The words are reserved if the option is set to "3.0.0". Change-Id: If1b295e6a77e840cf1b794c2eb73e1b9d2b8ddd6 Reviewed-on: http://gerrit.cloudera.org:8080/9096 Reviewed-by: Alex BehmReviewed-by: Philip Zeyliger Tested-by: Impala Public Jenkins (cherry picked from commit f0b3d9d122f2c6eb4137bf93e3512a489ff8fab0) Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Reviewed-on: http://gerrit.cloudera.org:8080/9198 Reviewed-by: Tianyi Wang Tested-by: Impala Public Jenkins --- M be/src/common/global-flags.cc M be/src/common/init.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java M fe/src/test/java/org/apache/impala/planner/StatsExtrapolationTest.java M fe/src/test/java/org/apache/impala/service/JdbcTest.java M testdata/workloads/functional-query/queries/QueryTest/empty-build-joins.test M testdata/workloads/functional-query/queries/QueryTest/exprs.test M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test M testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test M testdata/workloads/functional-query/queries/QueryTest/spilling-large-rows.test M testdata/workloads/functional-query/queries/QueryTest/values.test A tests/custom_cluster/test_reserved_words_version.py M tests/custom_cluster/test_stats_extrapolation.py M tests/query_test/test_sort.py 28 files changed, 574 insertions(+), 446 deletions(-) Approvals: Tianyi Wang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1881/ -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi WangGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Sat, 03 Feb 2018 22:06:51 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This patch reserves SQL:2016 reserved words, excluding: 1. Impala builtin function names. 2. Time unit words(year, month, etc.). 3. An exception list based on a discussion. Some test cases are modified to avoid these words. A impalad and catalogd startup option reserved_words_version is added. The words are reserved if the option is set to "3.0.0". Change-Id: If1b295e6a77e840cf1b794c2eb73e1b9d2b8ddd6 Reviewed-on: http://gerrit.cloudera.org:8080/9096 Reviewed-by: Alex BehmReviewed-by: Philip Zeyliger Tested-by: Impala Public Jenkins (cherry picked from commit f0b3d9d122f2c6eb4137bf93e3512a489ff8fab0) Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 --- M be/src/common/global-flags.cc M be/src/common/init.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java M fe/src/test/java/org/apache/impala/planner/StatsExtrapolationTest.java M fe/src/test/java/org/apache/impala/service/JdbcTest.java M testdata/workloads/functional-query/queries/QueryTest/empty-build-joins.test M testdata/workloads/functional-query/queries/QueryTest/exprs.test M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test M testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test M testdata/workloads/functional-query/queries/QueryTest/spilling-large-rows.test M testdata/workloads/functional-query/queries/QueryTest/values.test A tests/custom_cluster/test_reserved_words_version.py M tests/custom_cluster/test_stats_extrapolation.py M tests/query_test/test_sort.py 28 files changed, 574 insertions(+), 446 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/9198/3 -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1875/ -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi WangGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Sat, 03 Feb 2018 03:49:52 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: oops the regex_escape change is already in this branch. -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi WangGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Sat, 03 Feb 2018 03:49:28 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1869/ -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi WangGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Sat, 03 Feb 2018 03:33:46 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1869/ -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi WangGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Fri, 02 Feb 2018 23:53:18 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: Code-Review+2 Carry over Philip's +2 -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi WangGerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Fri, 02 Feb 2018 23:52:47 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This patch reserves SQL:2016 reserved words, excluding: 1. Impala builtin function names. 2. Time unit words(year, month, etc.). 3. An exception list based on a discussion. Some test cases are modified to avoid these words. A impalad and catalogd startup option reserved_words_version is added. The words are reserved if the option is set to "3.0.0". Change-Id: If1b295e6a77e840cf1b794c2eb73e1b9d2b8ddd6 Reviewed-on: http://gerrit.cloudera.org:8080/9096 Reviewed-by: Alex BehmReviewed-by: Philip Zeyliger Tested-by: Impala Public Jenkins (cherry picked from commit f0b3d9d122f2c6eb4137bf93e3512a489ff8fab0) Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 --- M be/src/common/global-flags.cc M be/src/common/init.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java M fe/src/test/java/org/apache/impala/planner/StatsExtrapolationTest.java M fe/src/test/java/org/apache/impala/service/JdbcTest.java M testdata/workloads/functional-query/queries/QueryTest/empty-build-joins.test M testdata/workloads/functional-query/queries/QueryTest/exprs.test M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test M testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test M testdata/workloads/functional-query/queries/QueryTest/spilling-large-rows.test M testdata/workloads/functional-query/queries/QueryTest/values.test A tests/custom_cluster/test_reserved_words_version.py M tests/custom_cluster/test_stats_extrapolation.py M tests/query_test/test_sort.py 28 files changed, 570 insertions(+), 442 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/9198/2 -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 1: Code-Review+2 The conflict was boring, yes? I'd prefer you change the default in a separate commit. -- To view, visit http://gerrit.cloudera.org:8080/9198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8 Gerrit-Change-Number: 9198 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi WangGerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Fri, 02 Feb 2018 20:23:36 + Gerrit-HasComments: No