[Impala-ASF-CR](2.x) IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9768 )

Change subject: IMPALA-6622: Backport parts of IMPALA-4924 to 2.x
..

IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

We enabled Decimal V2 by default on master (but not on the 2.x branch)
in IMPALA-4924. There were some other code changes that are not
specific to enableing Decimal V2 that are causing merge conflicts. In
this patch, we backport those changes to reduce the chance of
conflicts.

Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Reviewed-on: http://gerrit.cloudera.org:8080/9768
Reviewed-by: Taras Bobrovytsky 
Tested-by: Impala Public Jenkins
---
M be/src/exprs/expr-test.cc
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
M tests/hs2/test_hs2.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_decimal_casting.py
6 files changed, 127 insertions(+), 36 deletions(-)

Approvals:
  Taras Bobrovytsky: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Gerrit-Change-Number: 9768
Gerrit-PatchSet: 3
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR](2.x) IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9768 )

Change subject: IMPALA-6622: Backport parts of IMPALA-4924 to 2.x
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Gerrit-Change-Number: 9768
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 23 Mar 2018 04:10:53 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9768 )

Change subject: IMPALA-6622: Backport parts of IMPALA-4924 to 2.x
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2163/


--
To view, visit http://gerrit.cloudera.org:8080/9768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Gerrit-Change-Number: 9768
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 23 Mar 2018 00:32:04 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

[Taras Bobrovytsky (Code Review)]

Taras Bobrovytsky has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9768 )

Change subject: IMPALA-6622: Backport parts of IMPALA-4924 to 2.x
..


Patch Set 2: Code-Review+2

(1 comment)

Forwarding the +2

http://gerrit.cloudera.org:8080/#/c/9768/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9768/1//COMMIT_MSG@9
PS1, Line 9: We enabled Decimal V2 by default on master (but not on the 2.x 
branch)
> nit: typo
Done



--
To view, visit http://gerrit.cloudera.org:8080/9768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Gerrit-Change-Number: 9768
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 23 Mar 2018 00:31:36 +
Gerrit-HasComments: Yes

[Impala-ASF-CR](2.x) IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

[Taras Bobrovytsky (Code Review)]

Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9768

to look at the new patch set (#2).

Change subject: IMPALA-6622: Backport parts of IMPALA-4924 to 2.x
..

IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

We enabled Decimal V2 by default on master (but not on the 2.x branch)
in IMPALA-4924. There were some other code changes that are not
specific to enableing Decimal V2 that are causing merge conflicts. In
this patch, we backport those changes to reduce the chance of
conflicts.

Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
---
M be/src/exprs/expr-test.cc
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
M tests/hs2/test_hs2.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_decimal_casting.py
6 files changed, 127 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/9768/2
--
To view, visit http://gerrit.cloudera.org:8080/9768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Gerrit-Change-Number: 9768
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR](2.x) IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9768 )

Change subject: IMPALA-6622: Backport parts of IMPALA-4924 to 2.x
..


Patch Set 1:

(1 comment)

Thanks for backporting this.

http://gerrit.cloudera.org:8080/#/c/9768/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9768/1//COMMIT_MSG@9
PS1, Line 9: We enabled Deciaml V2 by default on master (but not on the 2.x 
branch)
nit: typo



--
To view, visit http://gerrit.cloudera.org:8080/9768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Gerrit-Change-Number: 9768
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 23 Mar 2018 00:08:44 +
Gerrit-HasComments: Yes

[Impala-ASF-CR](2.x) IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9768 )

Change subject: IMPALA-6622: Backport parts of IMPALA-4924 to 2.x
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2162/


--
To view, visit http://gerrit.cloudera.org:8080/9768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Gerrit-Change-Number: 9768
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 22 Mar 2018 23:25:37 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9768 )

Change subject: IMPALA-6622: Backport parts of IMPALA-4924 to 2.x
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Gerrit-Change-Number: 9768
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 22 Mar 2018 23:20:17 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

[Taras Bobrovytsky (Code Review)]

Taras Bobrovytsky has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9768


Change subject: IMPALA-6622: Backport parts of IMPALA-4924 to 2.x
..

IMPALA-6622: Backport parts of IMPALA-4924 to 2.x

We enabled Deciaml V2 by default on master (but not on the 2.x branch)
in IMPALA-4924. There were some other code changes that are not
specific to enableing Decimal V2 that are causing merge conflicts. In
this patch, we backport those changes to reduce the change of
conflicts.

Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
---
M be/src/exprs/expr-test.cc
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
M tests/hs2/test_hs2.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_decimal_casting.py
6 files changed, 127 insertions(+), 36 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/9768/1
--
To view, visit http://gerrit.cloudera.org:8080/9768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2504fb6ec7fa350296b058156b6fd7fb97bc4f9b
Gerrit-Change-Number: 9768
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky