[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9869 )

Change subject: [DOCS] Updates to the load balancing algorithms section
..

[DOCS] Updates to the load balancing algorithms section

Further refined the Load Balancing Algorithm section
with reviews and comments from SME.

Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Reviewed-on: http://gerrit.cloudera.org:8080/9869
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_proxy.xml
1 file changed, 55 insertions(+), 58 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9869 )

Change subject: [DOCS] Updates to the load balancing algorithms section
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 00:36:25 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9869 )

Change subject: [DOCS] Updates to the load balancing algorithms section
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/219/


--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 00:20:02 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9869 )

Change subject: [DOCS] Updates to the load balancing algorithms section
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 03 Apr 2018 00:19:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-03-30 Thread Alex Rodoni (Code Review)
Hello John Russell, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9869

to look at the new patch set (#4).

Change subject: [DOCS] Updates to the load balancing algorithms section
..

[DOCS] Updates to the load balancing algorithms section

Further refined the Load Balancing Algorithm section
with reviews and comments from SME.

Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
---
M docs/topics/impala_proxy.xml
1 file changed, 55 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/9869/4
--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-03-30 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9869 )

Change subject: [DOCS] Updates to the load balancing algorithms section
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9869/3/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

http://gerrit.cloudera.org:8080/#/c/9869/3/docs/topics/impala_proxy.xml@129
PS3, Line 129: .S
Sorry, didn't catch it before, one more missing space.



--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 30 Mar 2018 22:57:43 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-03-30 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9869 )

Change subject: [DOCS] Updates to the load balancing algorithms section
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9869/2/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

http://gerrit.cloudera.org:8080/#/c/9869/2/docs/topics/impala_proxy.xml@187
PS2, Line 187: 
> Having the  start with plain text causes weird wrapping like this when
Done


http://gerrit.cloudera.org:8080/#/c/9869/2/docs/topics/impala_proxy.xml@209
PS2, Line 209: setup
> 'set up' as a verb. (You might 'choose a setup' to use it as a noun, but pr
Done



--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 30 Mar 2018 22:46:02 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-03-30 Thread Alex Rodoni (Code Review)
Hello John Russell, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9869

to look at the new patch set (#3).

Change subject: [DOCS] Updates to the load balancing algorithms section
..

[DOCS] Updates to the load balancing algorithms section

Further refined the Load Balancing Algorithm section
with reviews and comments from SME.

Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
---
M docs/topics/impala_proxy.xml
1 file changed, 55 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/9869/3
--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-03-30 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9869 )

Change subject: [DOCS] Updates to the load balancing algorithms section
..


Patch Set 2: Code-Review+1

(2 comments)

Just a couple of minor touchups and it'll be ready for +2.

http://gerrit.cloudera.org:8080/#/c/9869/2/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

http://gerrit.cloudera.org:8080/#/c/9869/2/docs/topics/impala_proxy.xml@187
PS2, Line 187: 
Having the  start with plain text causes weird wrapping like this when you 
add a paragraph later. Wrap a  tag around the text immediately following the 
, "Sessions from the... in this case."

It often produces better source formatting and better line spacing in the HTML 
output to include a  inside tags where it's optional, such as  and . 
That's why you'll often see the extra layer of tags in the Impala doc source 
code - to allow the addition of a 2nd, 3rd, etc. paragraph without causing any 
source or output glitches.


http://gerrit.cloudera.org:8080/#/c/9869/2/docs/topics/impala_proxy.xml@209
PS2, Line 209: setup
'set up' as a verb. (You might 'choose a setup' to use it as a noun, but 
probably simpler just to use 2 words.)



--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 30 Mar 2018 22:31:31 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section

2018-03-30 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9869


Change subject: [DOCS] Updates to the load balancing algorithms section
..

[DOCS] Updates to the load balancing algorithms section

Further refined the Load Balancing Algorithm section
with reviews and comments from SME.

Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
---
M docs/topics/impala_proxy.xml
1 file changed, 48 insertions(+), 56 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/9869/1
--
To view, visit http://gerrit.cloudera.org:8080/9869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317
Gerrit-Change-Number: 9869
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni