[Impala-ASF-CR] Add missing PrintId() calls
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10716 ) Change subject: Add missing PrintId() calls .. Add missing PrintId() calls For consistency, add PrintId() around query_id() used in a stream, which was missing from this commit but needed for 2.x backport: IMPALA-5216: Make admission control queuing async This change was put into the cherry-pick for 2.x, so: Cherry-picks: not for 2.x Change-Id: Ifa53bf46411b09f33ccf38b080cd1c06dd3717ef Reviewed-on: http://gerrit.cloudera.org:8080/10716 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/scheduling/admission-controller.cc M be/src/service/client-request-state.cc 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifa53bf46411b09f33ccf38b080cd1c06dd3717ef Gerrit-Change-Number: 10716 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] Add missing PrintId() calls
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10716 ) Change subject: Add missing PrintId() calls .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa53bf46411b09f33ccf38b080cd1c06dd3717ef Gerrit-Change-Number: 10716 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Thu, 14 Jun 2018 04:49:02 + Gerrit-HasComments: No
[Impala-ASF-CR] Add missing PrintId() calls
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10716 ) Change subject: Add missing PrintId() calls .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa53bf46411b09f33ccf38b080cd1c06dd3717ef Gerrit-Change-Number: 10716 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Thu, 14 Jun 2018 01:28:27 + Gerrit-HasComments: No
[Impala-ASF-CR] Add missing PrintId() calls
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10716 ) Change subject: Add missing PrintId() calls .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2667/ -- To view, visit http://gerrit.cloudera.org:8080/10716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa53bf46411b09f33ccf38b080cd1c06dd3717ef Gerrit-Change-Number: 10716 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Thu, 14 Jun 2018 01:28:28 + Gerrit-HasComments: No
[Impala-ASF-CR] Add missing PrintId() calls
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10716 ) Change subject: Add missing PrintId() calls .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa53bf46411b09f33ccf38b080cd1c06dd3717ef Gerrit-Change-Number: 10716 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Thu, 14 Jun 2018 00:58:38 + Gerrit-HasComments: No
[Impala-ASF-CR] Add missing PrintId() calls
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10716 Change subject: Add missing PrintId() calls .. Add missing PrintId() calls For consistency, add PrintId() around query_id() used in a stream, which was missing from this commit but needed for 2.x backport: IMPALA-5216: Make admission control queuing async This change was put into the cherry-pick for 2.x, so: Cherry-picks: not for 2.x Change-Id: Ifa53bf46411b09f33ccf38b080cd1c06dd3717ef --- M be/src/scheduling/admission-controller.cc M be/src/service/client-request-state.cc 2 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/10716/1 -- To view, visit http://gerrit.cloudera.org:8080/10716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifa53bf46411b09f33ccf38b080cd1c06dd3717ef Gerrit-Change-Number: 10716 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
