[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 2: > This update is more about testing Gerrit/Jenkins integration after > a Gerrit plugin update. Sorry, I don't quite follow. -- To view, visit http://gerrit.cloudera.org:8080/12910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b Gerrit-Change-Number: 12910 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sun, 16 Feb 2020 02:28:26 + Gerrit-HasComments: No
[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5343/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b Gerrit-Change-Number: 12910 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sat, 28 Dec 2019 12:53:43 + Gerrit-HasComments: No
[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 2: This update is more about testing Gerrit/Jenkins integration after a Gerrit plugin update. -- To view, visit http://gerrit.cloudera.org:8080/12910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b Gerrit-Change-Number: 12910 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sat, 28 Dec 2019 12:24:44 + Gerrit-HasComments: No
[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh
Hello Impala Public Jenkins, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12910 to look at the new patch set (#2). Change subject: Don't build with shared objects in bootstrap_build.sh .. Don't build with shared objects in bootstrap_build.sh Building with shared objects is not supported currently because of various problems. All tested configurations of Impala are built with the supporting libraries being linked statically. The patch removes the '-so' flag from bootstrap_build.sh to make the compile-only check work the same way as the regular builds. Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b --- M bin/bootstrap_build.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/12910/2 -- To view, visit http://gerrit.cloudera.org:8080/12910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b Gerrit-Change-Number: 12910 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12910/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12910/1//COMMIT_MSG@9 PS1, Line 9: various : problems Is there a newer JIRA? The last I remember about this was years ago. -- To view, visit http://gerrit.cloudera.org:8080/12910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b Gerrit-Change-Number: 12910 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Wed, 03 Apr 2019 01:59:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/2610/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/12910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b Gerrit-Change-Number: 12910 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 02 Apr 2019 14:49:49 + Gerrit-HasComments: No
[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12910 Change subject: Don't build with shared objects in bootstrap_build.sh .. Don't build with shared objects in bootstrap_build.sh Building with shared objects is not supported currently because of various problems. All tested configurations of Impala are built with the supporting libraries being linked statically. The patch removes the '-so' flag from bootstrap_build.sh to make the compile-only check work the same way as the regular builds. Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b --- M bin/bootstrap_build.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/12910/1 -- To view, visit http://gerrit.cloudera.org:8080/12910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b Gerrit-Change-Number: 12910 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal
