[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Kim Jin Chul (Code Review)]

Kim Jin Chul has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..


Patch Set 4:

Thank you all for the reviews.


--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 4
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 05 Mar 2018 00:17:59 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 03 Mar 2018 02:12:05 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..

IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function

Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Reviewed-on: http://gerrit.cloudera.org:8080/9031
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_math_functions.xml
2 files changed, 76 insertions(+), 0 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 4
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/202/


--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 03 Mar 2018 02:09:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2040/


--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 03 Mar 2018 02:09:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2040/


--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 03 Mar 2018 01:17:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 2
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 03 Mar 2018 01:17:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 03 Mar 2018 01:17:47 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 2
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 02 Feb 2018 18:28:54 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Kim Jin Chul (Code Review)]

Kim Jin Chul has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9031 )

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..


Patch Set 1:

(5 comments)

Applied the update.

http://gerrit.cloudera.org:8080/#/c/9031/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9031/1//COMMIT_MSG@7
PS1, Line 7: [DOCS]
> Let's include a reference to the code JIRA:
Done


http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml
File docs/topics/impala_math_functions.xml:

http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@862
PS1, Line 862: 2.12.0
> rev="IMPALA-3651 2.12.0"
Done


http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@871
PS1, Line 871: https://en.wikipedia.org/wiki/MurmurHash
> Could you add an entry in ../impala_keydefs.ditamap for this wiki page, fol
Done


http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@878
PS1, Line 878: You might use the return value
> Is there some aspect of performance, collisions, or similar that would infl
Done


http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@907
PS1, Line 907: relatively low entropy
> Is this statement really true for murmur_hash()? For fnv_hash(), the corres
Done. Sorry, it's my mistake.



--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 1
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kim Jin Chul 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 25 Jan 2018 09:40:34 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

[Kim Jin Chul (Code Review)]

Hello John Russell, Tim Armstrong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9031

to look at the new patch set (#2).

Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function
..

IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function

Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_math_functions.xml
2 files changed, 76 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/9031/2
--
To view, visit http://gerrit.cloudera.org:8080/9031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b
Gerrit-Change-Number: 9031
Gerrit-PatchSet: 2
Gerrit-Owner: Kim Jin Chul 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong