[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9208 )

Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH 
query
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Sat, 03 Feb 2018 05:22:23 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9208 )

Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH 
query
..

IMPALA-4924 addendum: Change result type to decimal in a TPCH query

Change the expected result type of Kudu TPCH Q17 to Decimal because
DECIMAL_V2 is now enabled by default. This was not done earlier because
we were not running TPCH on Kudu regularly.

Cherry-picks: not for 2.x

Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Reviewed-on: http://gerrit.cloudera.org:8080/9208
Reviewed-by: Taras Bobrovytsky 
Tested-by: Impala Public Jenkins
---
M testdata/workloads/tpch/queries/tpch-kudu-q17.test
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Taras Bobrovytsky: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 3
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 


[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9208 )

Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH 
query
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1873/


--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Sat, 03 Feb 2018 01:42:47 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9208 )

Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH 
query
..


Patch Set 2: Code-Review+2

For some reason Change-Id was placed before "Cherry-picks" in the commit 
message. Fixed. Forwarding the +2


--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Sat, 03 Feb 2018 01:42:26 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/9208 )

Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH 
query
..

IMPALA-4924 addendum: Change result type to decimal in a TPCH query

Change the expected result type of Kudu TPCH Q17 to Decimal because
DECIMAL_V2 is now enabled by default. This was not done earlier because
we were not running TPCH on Kudu regularly.

Cherry-picks: not for 2.x

Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
---
M testdata/workloads/tpch/queries/tpch-kudu-q17.test
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/9208/2
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins


[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9208 )

Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH 
query
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1872/


--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Sat, 03 Feb 2018 01:35:48 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9208 )

Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH 
query
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Comment-Date: Sat, 03 Feb 2018 01:34:34 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9208


Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH 
query
..

IMPALA-4924 addendum: Change result type to decimal in a TPCH query

Change the expected result type of Kudu TPCH Q17 to Decimal because
DECIMAL_V2 is now enabled by default. This was not done earlier because
we were not running TPCH on Kudu regularly.

Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Cherry-picks: not for 2.x
---
M testdata/workloads/tpch/queries/tpch-kudu-q17.test
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/9208/1
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky