[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-09 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 19: (9 comments) Overall this looks very good and prior

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 19: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 19: Build Successful

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 19: Build started:

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-02 Thread Xianqing He (Code Review)
Xianqing He has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. IMPALA-5022 part 1/2: Outer join simplification Outer joins in SQL

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 18: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 18: Build started:

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-01 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 18: Code-Review+1 Looks good! -- To view, visit

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-01 Thread Xianqing He (Code Review)
Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 18: (2 comments)

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-09-01 Thread Xianqing He (Code Review)
Xianqing He has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. IMPALA-5022 part 1/2: Outer join simplification Outer joins in SQL

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-31 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 16: (5 comments) Looks good to me!

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-28 Thread Xianqing He (Code Review)
Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 16: (3 comments)

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-28 Thread Xianqing He (Code Review)
Xianqing He has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. IMPALA-5022 part 1/2: Outer join simplification As a general rule, an

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-28 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 15: (6 comments) Nice! Thanks for the rework. These two

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-27 Thread Xianqing He (Code Review)
Xianqing He has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. IMPALA-5022 part 1/2: Outer join simplification As a general rule, an

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-27 Thread Xianqing He (Code Review)
Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 14: (12 comments)

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. Patch Set 14: (3 comments)

[Impala-ASF-CR] IMPALA-5022 part 1/2: Outer join simplification

2020-08-27 Thread Xianqing He (Code Review)
Xianqing He has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1/2: Outer join simplification .. IMPALA-5022 part 1/2: Outer join simplification As a general rule, an