[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. IMPALA-5031: link fesupport so FE tests run with UBSAN This commit enables the frontend and JDBC tests to run under UBSAN. Before this comit, they fail with an error message about finding the UBSAN support functions like __ubsan_handle_load_invalid_value. Linking those functions into libfesupport.so requires using the linker flag --whole-archive so that these symbols, which are not directly referenced by the source code used to build libfesupport.so, are included. This patch also enables the custom cluster tests to run under UBSAN; they recently gained frontend tests in commit d72f3330c1edc9086ba120e6d3469a75c0aea083. Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Reviewed-on: http://gerrit.cloudera.org:8080/13710 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/service/CMakeLists.txt M bin/impala-config.sh 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 7 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 6 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 06:56:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4558/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 6 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 01:21:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 6 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 27 Jun 2019 01:21:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4545/ -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 5 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 06:19:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4545/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 5 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 00:38:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 5 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 00:38:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 22:49:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 09:37:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3731/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 04:31:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4532/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 04:03:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13710/2/be/src/service/CMakeLists.txt File be/src/service/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13710/2/be/src/service/CMakeLists.txt@57 PS2, Line 57: target_link_libraries(fesupport "-Wl,--whole-archive \ > Can you indent the code inside the if? We generally do this in CMake files. Done -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 03:53:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13710 to look at the new patch set (#3). Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. IMPALA-5031: link fesupport so FE tests run with UBSAN This commit enables the frontend and JDBC tests to run under UBSAN. Before this comit, they fail with an error message about finding the UBSAN support functions like __ubsan_handle_load_invalid_value. Linking those functions into libfesupport.so requires using the linker flag --whole-archive so that these symbols, which are not directly referenced by the source code used to build libfesupport.so, are included. This patch also enables the custom cluster tests to run under UBSAN; they recently gained frontend tests in commit d72f3330c1edc9086ba120e6d3469a75c0aea083. Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 --- M be/src/service/CMakeLists.txt M bin/impala-config.sh 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/13710/3 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13710/2/be/src/service/CMakeLists.txt File be/src/service/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13710/2/be/src/service/CMakeLists.txt@57 PS2, Line 57: target_link_libraries(fesupport "-Wl,--whole-archive \ Can you indent the code inside the if? We generally do this in CMake files. -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 24 Jun 2019 16:52:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 2: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4524/ This looks to me like https://issues.apache.org/jira/browse/IMPALA-8700 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Mon, 24 Jun 2019 01:10:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4524/ -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 22 Jun 2019 23:59:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3717/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 22 Jun 2019 19:23:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4524/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 22 Jun 2019 18:44:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13710 to look at the new patch set (#2). Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. IMPALA-5031: link fesupport so FE tests run with UBSAN This commit enables the frontend and JDBC tests to run under UBSAN. Before this comit, they fail with an error message about finding the UBSAN support functions like __ubsan_handle_load_invalid_value. Linking those functions into libfesupport.so requires using the linker flag --whole-archive so that these symbols, which are not directly referenced by the source code used to build libfesupport.so, are included. This patch also enables the custom cluster tests to run under UBSAN; they recently gained frontend tests in commit d72f3330c1edc9086ba120e6d3469a75c0aea083. Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 --- M be/src/service/CMakeLists.txt M bin/impala-config.sh 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/13710/2 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4523/ -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 22 Jun 2019 17:10:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4523/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 22 Jun 2019 15:43:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/3716/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 22 Jun 2019 15:39:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13710 Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. IMPALA-5031: link fesupport so FE tests run with UBSAN This commit enables the frontend and JDBC tests to run under UBSAN. Before this comit, they fail with an error message about finding the UBSAN support functions like __ubsan_handle_load_invalid_value. Linking those functions into libfesupport.so requires using the linker flag --whole-archive so that these symbols, which are not directly referenced by the source code used to build libfesupport.so, are included. This patch also enables the custom cluster tests to run under UBSAN; they recently gained frontend tests in commit d72f3330c1edc9086ba120e6d3469a75c0aea083. Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 --- M be/src/service/CMakeLists.txt 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/13710/1 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
