[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9155/1/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/9155/1/be/src/util/runtime-profile-counters.h@308 PS1, Line 308: DCHECK_GE(offset_, -1); > That's a good point. The intent was to add it to sw_.ElapsedTime() in MarkE Uh, I seem to have missed that. Tim, let me know if you'd like to fix it, or prefer for me to take over this change. I don't think clamping offset is necessary. -- To view, visit http://gerrit.cloudera.org:8080/9155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62317149cb8428f7d29e945a538f6cc8dd45342f Gerrit-Change-Number: 9155 Gerrit-PatchSet: 1 Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Tue, 30 Jan 2018 01:15:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9155/1/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/9155/1/be/src/util/runtime-profile-counters.h@308 PS1, Line 308: DCHECK_GE(offset_, -1); > I can't even find where offset_ is used... That's a good point. The intent was to add it to sw_.ElapsedTime() in MarkEvent() but that code is obviously not there. -- To view, visit http://gerrit.cloudera.org:8080/9155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62317149cb8428f7d29e945a538f6cc8dd45342f Gerrit-Change-Number: 9155 Gerrit-PatchSet: 1 Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Tue, 30 Jan 2018 01:09:46 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9155/1/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/9155/1/be/src/util/runtime-profile-counters.h@308 PS1, Line 308: DCHECK_GE(offset_, -1); > does anything bad happen when offset_ == -1? I.e. the fix of the DCHECK is I can't even find where offset_ is used... -- To view, visit http://gerrit.cloudera.org:8080/9155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62317149cb8428f7d29e945a538f6cc8dd45342f Gerrit-Change-Number: 9155 Gerrit-PatchSet: 1 Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Tue, 30 Jan 2018 00:23:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62317149cb8428f7d29e945a538f6cc8dd45342f Gerrit-Change-Number: 9155 Gerrit-PatchSet: 1 Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Lars Volker Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Tue, 30 Jan 2018 00:12:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9155 Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. IMPALA-6450: loosen DCHECK in EventSequence::Start() It looks like this newly-added DCHECK is being hit because of the same underlying issue as IMPALA-4631. This patch loosens the DCHECK to accept time going backward 1 tick, the same as the original workaround for IMPALA-4631. Change-Id: I62317149cb8428f7d29e945a538f6cc8dd45342f --- M be/src/util/runtime-profile-counters.h 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/9155/1 -- To view, visit http://gerrit.cloudera.org:8080/9155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I62317149cb8428f7d29e945a538f6cc8dd45342f Gerrit-Change-Number: 9155 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong