[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. IMPALA-6661 Make NaN values equal for grouping

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 23: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 23: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 23: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 23: Build started:

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Paul Rogers, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#23). Change subject: IMPALA-6661 Make NaN values equal for grouping

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 22: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 22: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 22: Build started:

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Paul Rogers, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#22). Change subject: IMPALA-6661 Make NaN values equal for grouping

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 20: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 20: Build started:

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 19: There seems to be other test failures in

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 19: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-26 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Paul Rogers, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#19). Change subject: IMPALA-6661 Make NaN values equal for grouping

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 18: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 18: Build started:

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 18: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 17: (2 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Paul Rogers, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#17). Change subject: IMPALA-6661 Make NaN values equal for grouping

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: Code-Review+2 (2 comments) LGTM. Two minor

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-22 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: (3 comments) > Patch Set 16: > > (3

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-22 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: (3 comments) A few more comments as I learn

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: (3 comments) Hey sorry for not getting back

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-18 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: (5 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-18 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: (5 comments) Good stuff. A few random

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-18 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-17 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#16). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-16 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-16 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-16 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 15: (1 comment) > Patch Set 14: > > (1

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-15 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#15). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-15 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-15 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#14). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-15 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-12 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#13). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-12 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 13: (4 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 11: (8 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-10 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 11: (4 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-10 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#11). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-10 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 10: (24 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-10 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#10). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 9: (25 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 6: Build Failed

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#6). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 5: (2 comments) I plan to take a look.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 5: Code-Review+1 (1 comment) Did anyone else

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#5). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#4). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 3: > Patch Set 3: > > (1 comment) > > Did

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 3: (1 comment) Did you mean to push out PS4?

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-01 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-01 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 3: (19 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 3: (20 comments) Mostly comments about style

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-01 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#3). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-09-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-09-27 Thread Michal Ostrowski (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#2). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.