[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. IMPALA-7818: Standardize use of Expr predicates

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 5: (5 comments) Thanks Vuk for the review. Addressed your

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11887 to look at the new patch set (#5). Change subject: IMPALA-7818: Standardize use of Expr predicates

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 4: (2 comments) Fixed check style warnings.

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11887 to look at the new patch set (#4). Change subject: IMPALA-7818: Standardize use of Expr predicates

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 3: Code-Review+1 LGTM apart from the bot's style

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 3: Dry-run passed:

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11887 Change subject: IMPALA-7818: Standardize use of Expr predicates .. IMPALA-7818: Standardize use of Expr predicates The Expr node provids