[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2020-06-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( 
http://gerrit.cloudera.org:8080/12497 )

Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..


Abandoned

Looks like this is no longer relevant since we removed impala-lzo support.
--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 


[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2019-02-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12497 )

Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..


Patch Set 3:

Please see my reviews in https://gerrit.cloudera.org/#/c/12495/. I don't think 
it's appropriate for buildall to move git checkouts around.


--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 15 Feb 2019 17:46:38 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2019-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12497 )

Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 15 Feb 2019 10:39:04 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2019-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12497 )

Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3781/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 15 Feb 2019 06:25:29 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2019-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12497 )

Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/2136/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 15 Feb 2019 03:27:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2019-02-14 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12497

to look at the new patch set (#2).

Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..

IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

Impala depends on the Impala-lzo project in builds. However, Impala-lzo
is evolving. Different branches of Impala depends on different versions
of Impala-lzo. This patch adds a variable in bin/impala-config-branch.sh
to specify the depended version for Impala-lzo.

Using this variable(IMPALA_LZO_VERSION), buildall.sh will checkout to
the right version at each run.

Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
---
M bin/impala-config-branch.sh
M buildall.sh
2 files changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/12497/2
--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2019-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12497 )

Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3780/


--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 15 Feb 2019 02:37:15 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2019-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12497 )

Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..


Patch Set 1:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/2135/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 15 Feb 2019 02:28:06 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2019-02-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12497


Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..

IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

Impala depends on the Impala-lzo project in builds. However, Impala-lzo
is evolving. Different branches of Impala depends on different versions
of Impala-lzo. This patch adds a variable in bin/impala-config-branch.sh
to specify the depended version for Impala-lzo.

Using this variable(IMPALA_LZO_VERSION), buildall.sh will checkout to
the right version at each run.

Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
---
M bin/impala-config-branch.sh
M buildall.sh
2 files changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/12497/1
--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 


[Impala-ASF-CR] IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh

2019-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12497 )

Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in 
buildall.sh
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3780/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/12497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4
Gerrit-Change-Number: 12497
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 15 Feb 2019 02:11:53 +
Gerrit-HasComments: No