[Impala-ASF-CR] Logging current database context when logging analyzing queries.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Logging current database context when logging analyzing queries. The "analyzing query" log message is a reliable way to correlate queries with ther thread ids, but the session database name is missing there. Adding it in. Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Reviewed-on: http://gerrit.cloudera.org:8080/12301 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/service/Frontend.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] Logging current database context when logging analyzing queries.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 20 Feb 2019 23:37:18 + Gerrit-HasComments: No
[Impala-ASF-CR] Logging current database context when logging analyzing queries.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 20 Feb 2019 19:34:08 + Gerrit-HasComments: No
[Impala-ASF-CR] Logging current database context when logging analyzing queries.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3806/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 20 Feb 2019 19:34:09 + Gerrit-HasComments: No
[Impala-ASF-CR] Logging current database context when logging analyzing queries.
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12301/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/12301/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1243 PS1, Line 1243: + queryCtx.session.database); > I'm not using accessor methods because that was the local style. No problem. Let's leave it as is. -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 20 Feb 2019 19:26:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Logging current database context when logging analyzing queries.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12301/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/12301/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1243 PS1, Line 1243: + queryCtx.session.database); > In Java, a general rule is to use accessor methods, but since this is Thrif I'm not using accessor methods because that was the local style. It's a little selfish, but if the query doesn't have newlines in it (as many queries don't), then you get one query per log line, which is super handy for grep. I can certainly move the db up, like: Analyzing query (default db: ...): if you think that looks better. -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 20 Feb 2019 19:21:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Logging current database context when logging analyzing queries.
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 1: (1 comment) This is a one-line change, so of course I have comments... http://gerrit.cloudera.org:8080/#/c/12301/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/12301/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1243 PS1, Line 1243: + queryCtx.session.database); In Java, a general rule is to use accessor methods, but since this is Thrift, I suppose it is not essential. Verified that both fields are required, so seems no worry about NPE. The statement can be huge. With this formatting you'll get: Analyzing query SELECT ... ... ... db: foo Would it make sense to log this as two lines? Or maybe: Analyzing query for db: foo\n SELECT ... ... ... -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Thu, 31 Jan 2019 22:19:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Logging current database context when logging analyzing queries.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1926/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Wed, 30 Jan 2019 01:53:01 + Gerrit-HasComments: No
[Impala-ASF-CR] Logging current database context when logging analyzing queries.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12301 Change subject: Logging current database context when logging analyzing queries. .. Logging current database context when logging analyzing queries. The "analyzing query" log message is a reliable way to correlate queries with ther thread ids, but the session database name is missing there. Adding it in. Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 --- M fe/src/main/java/org/apache/impala/service/Frontend.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/12301/1 -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger
