[Impala-ASF-CR] Remove unused THROW IF ERROR WITH LOGGING, THROW IF EXC, and RETURN IF EXC.

2019-03-05 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12658 )

Change subject: Remove unused THROW_IF_ERROR_WITH_LOGGING, THROW_IF_EXC, and 
RETURN_IF_EXC.
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12658/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12658/1//COMMIT_MSG@7
PS1, Line 7: Remove unused THROW_IF_ERROR_WITH_LOGGING, THROW_IF_EXC, and 
RETURN_IF_EXC.
> nit: Add "IMPALA-8250: "
Done


http://gerrit.cloudera.org:8080/#/c/12658/1//COMMIT_MSG@9
PS1, Line 9: These macros have no references, so removing them. Found while
> So were these removed purely for cleanup purposes, or was there something w
Added to the commit message. Some of them were broken.

Note how ExceptionClear() is called after CallStaticObjectMethod()...

-jthrowable exc = (env)->ExceptionOccurred(); \
-if (exc != nullptr) { \
-  DCHECK((throwable_to_string_id_) != nullptr); \
-  jstring stack = (jstring) 
env->CallStaticObjectMethod(JniUtil::jni_util_class(), \
-  (JniUtil::throwable_to_stack_trace_id()), exc); \
-  jboolean is_copy; \
-  const char* c_stack = \
-  reinterpret_cast((env)->GetStringUTFChars(stack, 
_copy)); \
-  (env)->ExceptionClear(); \



--
To view, visit http://gerrit.cloudera.org:8080/12658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic63b498e0e4da57c7ec15cf1ad8070a6afdb3d96
Gerrit-Change-Number: 12658
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 05 Mar 2019 19:07:56 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove unused THROW IF ERROR WITH LOGGING, THROW IF EXC, and RETURN IF EXC.

2019-03-05 Thread Sahil Takiar (Code Review) 
Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12658 )

Change subject: Remove unused THROW_IF_ERROR_WITH_LOGGING, THROW_IF_EXC, and 
RETURN_IF_EXC.
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12658/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12658/1//COMMIT_MSG@7
PS1, Line 7: Remove unused THROW_IF_ERROR_WITH_LOGGING, THROW_IF_EXC, and 
RETURN_IF_EXC.
nit: Add "IMPALA-8250: "


http://gerrit.cloudera.org:8080/#/c/12658/1//COMMIT_MSG@9
PS1, Line 9: These macros have no references, so removing them. Found while
So were these removed purely for cleanup purposes, or was there something wrong 
with their implementation as well?



--
To view, visit http://gerrit.cloudera.org:8080/12658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic63b498e0e4da57c7ec15cf1ad8070a6afdb3d96
Gerrit-Change-Number: 12658
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 05 Mar 2019 16:47:03 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove unused THROW IF ERROR WITH LOGGING, THROW IF EXC, and RETURN IF EXC.

2019-03-04 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12658 )

Change subject: Remove unused THROW_IF_ERROR_WITH_LOGGING, THROW_IF_EXC, and 
RETURN_IF_EXC.
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/2346/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/12658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic63b498e0e4da57c7ec15cf1ad8070a6afdb3d96
Gerrit-Change-Number: 12658
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 05 Mar 2019 01:38:59 +
Gerrit-HasComments: No

[Impala-ASF-CR] Remove unused THROW IF ERROR WITH LOGGING, THROW IF EXC, and RETURN IF EXC.

2019-03-04 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12658


Change subject: Remove unused THROW_IF_ERROR_WITH_LOGGING, THROW_IF_EXC, and 
RETURN_IF_EXC.
..

Remove unused THROW_IF_ERROR_WITH_LOGGING, THROW_IF_EXC, and RETURN_IF_EXC.

These macros have no references, so removing them. Found while
investigating JNI warnings in IMPALA-8250.

The following one-liner does a hap-hazard job of finding similar issues.
There are relatively few left, and none of them seemed problematic.

  (for x in $(git grep '#define' be/src | grep -v be/src/kudu | grep -v 
be/src/gutil | grep -v be/src/thirdparty | grep -v be/src/transport/config.h | 
awk '{ print $2 }' | sed -e 's,(.*,,' | sort | uniq); do echo -n "$x "; git 
grep -e $x | wc -l; done) | awk '$2 == 1 { print }'

Change-Id: Ic63b498e0e4da57c7ec15cf1ad8070a6afdb3d96
---
M be/src/util/jni-util.h
1 file changed, 0 insertions(+), 41 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12658/1
--
To view, visit http://gerrit.cloudera.org:8080/12658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic63b498e0e4da57c7ec15cf1ad8070a6afdb3d96
Gerrit-Change-Number: 12658
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger